use more default copy ctors

if ctor should be private or protected explicitly default them.
boost::optional has copy ctors, so use them.

Change-Id: If1855626b297e739afef0dc5ad57958f7ad199bc
Reviewed-on: https://gerrit.libreoffice.org/42363Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

basic/source/sbx/sbxvar.cxx

@@ -49,12 +49,6 @@ class SbxVariableImpl
     SbxVariableImpl()
         : m_pComListenerParentBasic( nullptr )
     {}
-    SbxVariableImpl( const SbxVariableImpl& r )
-        : m_aDeclareClassName( r.m_aDeclareClassName )
-        , m_xComListener( r.m_xComListener )
-        , m_pComListenerParentBasic( r.m_pComListenerParentBasic )
-    {
-    }
 };
 
 

chart2/source/view/axes/VAxisProperties.cxx

@@ -177,36 +177,6 @@ AxisProperties::AxisProperties( const uno::Reference< XAxis >& xAxisModel
 {
 }
 
-AxisProperties::AxisProperties( const AxisProperties& rAxisProperties )
-    : m_xAxisModel( rAxisProperties.m_xAxisModel )
-    , m_nDimensionIndex( rAxisProperties.m_nDimensionIndex )
-    , m_bIsMainAxis( rAxisProperties.m_bIsMainAxis )
-    , m_bSwapXAndY( rAxisProperties.m_bSwapXAndY )
-    , m_eCrossoverType( rAxisProperties.m_eCrossoverType )
-    , m_eLabelPos( rAxisProperties.m_eLabelPos )
-    , m_eTickmarkPos( rAxisProperties.m_eTickmarkPos )
-    , m_bCrossingAxisHasReverseDirection( rAxisProperties.m_bCrossingAxisHasReverseDirection )
-    , m_bCrossingAxisIsCategoryAxes( rAxisProperties.m_bCrossingAxisIsCategoryAxes )
-    , maLabelAlignment( rAxisProperties.maLabelAlignment )
-    , m_bDisplayLabels( rAxisProperties.m_bDisplayLabels )
-    , m_bTryStaggeringFirst( rAxisProperties.m_bTryStaggeringFirst )
-    , m_nNumberFormatKey( rAxisProperties.m_nNumberFormatKey )
-    , m_nMajorTickmarks( rAxisProperties.m_nMajorTickmarks )
-    , m_nMinorTickmarks( rAxisProperties.m_nMinorTickmarks )
-    , m_aTickmarkPropertiesList( rAxisProperties.m_aTickmarkPropertiesList )
-    , m_aLineProperties( rAxisProperties.m_aLineProperties )
-    //for category axes
-    , m_nAxisType( rAxisProperties.m_nAxisType )
-    , m_bComplexCategories( rAxisProperties.m_bComplexCategories )
-    , m_pExplicitCategoriesProvider( rAxisProperties.m_pExplicitCategoriesProvider )
-    , m_xAxisTextProvider( rAxisProperties.m_xAxisTextProvider )
-{
-    if( rAxisProperties.m_pfMainLinePositionAtOtherAxis )
-        m_pfMainLinePositionAtOtherAxis.reset(*rAxisProperties.m_pfMainLinePositionAtOtherAxis);
-    if( rAxisProperties.m_pfExrtaLinePositionAtOtherAxis )
-        m_pfExrtaLinePositionAtOtherAxis.reset(*rAxisProperties.m_pfExrtaLinePositionAtOtherAxis);
-}
-
 LabelAlignment lcl_getLabelAlignmentForZAxis( const AxisProperties& rAxisProperties )
 {
     LabelAlignment aRet( LABEL_ALIGN_RIGHT );

chart2/source/view/axes/VAxisProperties.hxx

@@ -141,7 +141,6 @@ struct AxisProperties final
 
     AxisProperties( const css::uno::Reference< css::chart2::XAxis >& xAxisModel
                   , ExplicitCategoriesProvider* pExplicitCategoriesProvider );
-    AxisProperties( const AxisProperties& rAxisProperties );
 
     void init(bool bCartesian=false);//init from model data (m_xAxisModel)
 

chart2/source/view/charttypes/CategoryPositionHelper.cxx

@@ -30,14 +30,6 @@ CategoryPositionHelper::CategoryPositionHelper( double fSeriesCount, double fCat
 {
 }
 
-CategoryPositionHelper::CategoryPositionHelper( const CategoryPositionHelper& rSource )
-    : m_fSeriesCount( rSource.m_fSeriesCount )
-    , m_fCategoryWidth( rSource.m_fCategoryWidth )
-    , m_fInnerDistance( rSource.m_fInnerDistance )
-    , m_fOuterDistance( rSource.m_fOuterDistance )
-{
-}
-
 CategoryPositionHelper::~CategoryPositionHelper()
 {
 }

chart2/source/view/charttypes/CategoryPositionHelper.hxx

@@ -27,7 +27,6 @@ class CategoryPositionHelper
 {
 public:
     CategoryPositionHelper( double fSeriesCount, double CategoryWidth = 1.0);
-    CategoryPositionHelper( const CategoryPositionHelper& rSource );
     virtual ~CategoryPositionHelper();
 
     double getScaledSlotWidth() const;

configmgr/source/localizedvaluenode.cxx

@@ -53,10 +53,6 @@ void LocalizedValueNode::setValue(int layer, css::uno::Any const & value)
         value_ = value;
 }
 
-LocalizedValueNode::LocalizedValueNode(LocalizedValueNode const & other):
-    Node(other), value_(other.value_)
-{}
-
 LocalizedValueNode::~LocalizedValueNode() {}
 
 Node::Kind LocalizedValueNode::kind() const {

configmgr/source/localizedvaluenode.hxx

@@ -49,7 +49,7 @@ public:
     void setValue(int layer, css::uno::Any const & value);
 
 private:
-    LocalizedValueNode(LocalizedValueNode const & other);
+    LocalizedValueNode(LocalizedValueNode const&) = default;
 
     virtual ~LocalizedValueNode() override;
 

configmgr/source/propertynode.cxx

@@ -81,13 +81,6 @@ void PropertyNode::setExternal(int layer, OUString const & descriptor) {
     externalDescriptor_ = descriptor;
 }
 
-
-PropertyNode::PropertyNode(PropertyNode const & other):
-    Node(other), staticType_(other.staticType_), nillable_(other.nillable_),
-    extension_(other.extension_), externalDescriptor_(other.externalDescriptor_),
-    value_(other.value_)
-{}
-
 PropertyNode::~PropertyNode() {}
 
 Node::Kind PropertyNode::kind() const {

configmgr/source/propertynode.hxx

@@ -55,7 +55,7 @@ public:
     bool isExtension() const { return extension_;}
 
 private:
-    PropertyNode(PropertyNode const & other);
+    PropertyNode(PropertyNode const&) = default;
 
     virtual ~PropertyNode() override;
 

dbaccess/source/ui/dlg/optionalboolitem.cxx

@@ -29,12 +29,6 @@ namespace dbaui
     {
     }
 
-    OptionalBoolItem::OptionalBoolItem( const OptionalBoolItem& _rSource )
-        :SfxPoolItem( _rSource )
-        ,m_aValue( _rSource.m_aValue )
-    {
-    }
-
     bool OptionalBoolItem::operator==( const SfxPoolItem& _rItem ) const
     {
         const OptionalBoolItem* pCompare = dynamic_cast<const OptionalBoolItem*>( &_rItem  );

dbaccess/source/ui/dlg/optionalboolitem.hxx

@@ -34,7 +34,6 @@ namespace dbaui
 
     public:
         explicit OptionalBoolItem( sal_Int16 nWhich );
-        OptionalBoolItem( const OptionalBoolItem& _rSource );
 
         virtual bool             operator==( const SfxPoolItem& _rItem ) const override;
         virtual SfxPoolItem*     Clone( SfxItemPool* _pPool = nullptr ) const override;

extensions/source/abpilot/datasourcehandling.cxx

@@ -304,20 +304,9 @@ namespace abp
             : xORB(_rxORB)
         {
         }
-
-        ODataSourceImpl( const ODataSourceImpl& _rSource );
     };
 
 
-    ODataSourceImpl::ODataSourceImpl( const ODataSourceImpl& _rSource )
-        :xORB( _rSource.xORB )
-        ,xDataSource( _rSource.xDataSource )
-        ,xConnection( _rSource.xConnection )
-        ,aTables( _rSource.aTables )
-        ,sName( _rSource.sName )
-    {
-    }
-
     ODataSource::ODataSource( const ODataSource& _rSource )
         :m_pImpl( nullptr )
     {