Skip to content
Projeler
Gruplar
Parçacıklar
Yardım
Yükleniyor...
Oturum aç / Kaydol
Gezinmeyi değiştir
C
core
Proje
Proje
Ayrıntılar
Etkinlik
Cycle Analytics
Depo (repository)
Depo (repository)
Dosyalar
Kayıtlar (commit)
Dallar (branch)
Etiketler
Katkıda bulunanlar
Grafik
Karşılaştır
Grafikler
Konular (issue)
0
Konular (issue)
0
Liste
Pano
Etiketler
Kilometre Taşları
Birleştirme (merge) Talepleri
0
Birleştirme (merge) Talepleri
0
CI / CD
CI / CD
İş akışları (pipeline)
İşler
Zamanlamalar
Grafikler
Paketler
Paketler
Wiki
Wiki
Parçacıklar
Parçacıklar
Üyeler
Üyeler
Collapse sidebar
Close sidebar
Etkinlik
Grafik
Grafikler
Yeni bir konu (issue) oluştur
İşler
Kayıtlar (commit)
Konu (issue) Panoları
Kenar çubuğunu aç
LibreOffice
core
Commits
6661bdb0
Kaydet (Commit)
6661bdb0
authored
Mar 13, 2017
tarafından
Stephan Bergmann
Dosyalara gözat
Seçenekler
Dosyalara Gözat
İndir
Eposta Yamaları
Sade Fark
Minor loplugin:unnecessaryoverride improvement
Change-Id: I3afb31b642a47e767dda0614d223b6b7f22e5d54
üst
e20d9867
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
8 additions
and
14 deletions
+8
-14
unnecessaryoverride.cxx
compilerplugins/clang/unnecessaryoverride.cxx
+8
-10
unotbl.hxx
sw/inc/unotbl.hxx
+0
-1
swmodeltestbase.hxx
sw/qa/extras/inc/swmodeltestbase.hxx
+0
-3
No files found.
compilerplugins/clang/unnecessaryoverride.cxx
Dosyayı görüntüle @
6661bdb0
...
...
@@ -114,10 +114,6 @@ bool UnnecessaryOverride::VisitCXXMethodDecl(const CXXMethodDecl* methodDecl)
// operator to change from being an obsolete feature to being a standard
// feature. That difference is not taken into account here.
auto
cls
=
methodDecl
->
getParent
();
if
(
methodDecl
->
isVirtual
()
&&
cls
->
getNumBases
()
==
0
)
{
return
true
;
}
if
(
methodDecl
->
getAccess
()
!=
AS_public
)
{
return
true
;
...
...
@@ -131,6 +127,7 @@ bool UnnecessaryOverride::VisitCXXMethodDecl(const CXXMethodDecl* methodDecl)
// if it's virtual, but it has a base-class with a non-virtual destructor
if
(
methodDecl
->
isVirtual
())
{
bool
baseWithVirtualDtor
=
false
;
for
(
auto
baseSpecifier
=
cls
->
bases_begin
();
baseSpecifier
!=
cls
->
bases_end
();
++
baseSpecifier
)
{
const
RecordType
*
baseRecordType
=
baseSpecifier
->
getType
()
->
getAs
<
RecordType
>
();
...
...
@@ -138,15 +135,16 @@ bool UnnecessaryOverride::VisitCXXMethodDecl(const CXXMethodDecl* methodDecl)
{
const
CXXRecordDecl
*
baseRecordDecl
=
dyn_cast
<
CXXRecordDecl
>
(
baseRecordType
->
getDecl
());
if
(
baseRecordDecl
&&
baseRecordDecl
->
getDestructor
()
&&
!
baseRecordDecl
->
getDestructor
()
->
isVirtual
())
&&
baseRecordDecl
->
getDestructor
()
->
isVirtual
())
{
return
true
;
baseWithVirtualDtor
=
true
;
break
;
}
}
else
{
return
true
;
// dependent base
}
}
if
(
!
baseWithVirtualDtor
)
{
return
true
;
}
}
// corner case
...
...
sw/inc/unotbl.hxx
Dosyayı görüntüle @
6661bdb0
...
...
@@ -245,7 +245,6 @@ public:
SwUnoCursor
&
GetCursor
();
sw
::
UnoCursorPointer
m_pUnoCursor
;
SwFrameFormat
*
GetFrameFormat
()
const
{
return
const_cast
<
SwFrameFormat
*>
(
static_cast
<
const
SwFrameFormat
*>
(
GetRegisteredIn
()));
}
virtual
~
SwXTextTableCursor
()
override
{
};
};
struct
SwRangeDescriptor
...
...
sw/qa/extras/inc/swmodeltestbase.hxx
Dosyayı görüntüle @
6661bdb0
...
...
@@ -192,9 +192,6 @@ public:
maTempFile
.
EnableKillingFile
();
}
virtual
~
SwModelTestBase
()
override
{}
virtual
void
setUp
()
override
{
test
::
BootstrapFixture
::
setUp
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment