weld SvxConnectionDialog

Change-Id: Id240f3cc62775888d23634a203ae8e2de07f7caf
Reviewed-on: https://gerrit.libreoffice.org/61082
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

cui/source/factory/dlgfact.cxx

@@ -1370,8 +1370,8 @@ VclPtr<SfxAbstractDialog> AbstractDialogFactory_Impl::CreateSfxDialog(vcl::Windo
             return VclPtr<CuiAbstractController_Impl>::Create(o3tl::make_unique<SvxMeasureDialog>(pParent ? pParent->GetFrameWeld() : nullptr, rAttr, pView));
         }
         case RID_SVXPAGE_CONNECTION :
-            pDlg = VclPtr<SvxConnectionDialog>::Create( pParent, rAttr, pView );
-            break;
+            return VclPtr<CuiAbstractController_Impl>::Create(o3tl::make_unique<SvxConnectionDialog>(pParent ? pParent->GetFrameWeld() : nullptr, rAttr, pView));
+
         case RID_SFXPAGE_DBREGISTER :
             pDlg = VclPtr<DatabaseRegistrationDialog>::Create( pParent, rAttr );
             break;

cui/source/inc/connect.hxx

@@ -75,11 +75,11 @@ public:
 
 /* Derived from SfxSingleTabDialog, in order to be informed about
    virtual methods by the control. */
-class SvxConnectionDialog : public SfxSingleTabDialog
+class SvxConnectionDialog : public SfxSingleTabDialogController
 {
 public:
-    SvxConnectionDialog( vcl::Window* pParent, const SfxItemSet& rAttr,
-                       const SdrView* pView );
+    SvxConnectionDialog(weld::Window* pParent, const SfxItemSet& rAttr,
+                        const SdrView* pView);
 };
 
 #endif // INCLUDED_CUI_SOURCE_INC_CONNECT_HXX

cui/source/tabpages/connect.cxx

@@ -49,17 +49,17 @@ const sal_uInt16 SvxConnectionPage::pRanges[] =
 |*
 \************************************************************************/
 
-SvxConnectionDialog::SvxConnectionDialog( vcl::Window* pParent, const SfxItemSet& rInAttrs,
-                                const SdrView* pSdrView )
-    : SfxSingleTabDialog(pParent, rInAttrs)
+SvxConnectionDialog::SvxConnectionDialog(weld::Window* pParent, const SfxItemSet& rInAttrs, const SdrView* pSdrView)
+    : SfxSingleTabDialogController(pParent, rInAttrs)
 {
-    VclPtrInstance<SvxConnectionPage> _pPage( get_content_area(), rInAttrs );
+    TabPageParent pPageParent(get_content_area(), this);
+    VclPtrInstance<SvxConnectionPage> pPage(pPageParent, rInAttrs);
 
-    _pPage->SetView( pSdrView );
-    _pPage->Construct();
+    pPage->SetView(pSdrView);
+    pPage->Construct();
 
-    SetTabPage( _pPage );
-    SetText(CuiResId( RID_SVXSTR_CONNECTOR ));
+    SetTabPage(pPage);
+    m_xDialog->set_title(CuiResId( RID_SVXSTR_CONNECTOR));
 }
 
 /*************************************************************************

cui/uiconfig/ui/connectortabpage.ui

@@ -73,7 +73,7 @@
             <child>
               <object class="GtkComboBoxText" id="LB_TYPE">
                 <property name="visible">True</property>
-                <property name="can_focus">True</property>
+                <property name="can_focus">False</property>
               </object>
               <packing>
                 <property name="expand">False</property>