Kaydet (Commit) 604df2f6 authored tarafından Stephan Bergmann's avatar Stephan Bergmann

[API CHANGE] Fix typo in prop implemented by stardiv.UnoControls.FrameControl

There is exactly one implementation of css.frame.FrameControl (which demands a
property named "ComponentUrl" not "ComponentURL"), and exactly one place where
that property is used.  So switch those two places to use the spelling of the
property name as documented in the UNOIDL service.  (Even though that can be
considered an incompatible change, in the unlikely case that 3rd party code
expects to be able to access the given implementation's property with the mis-
spelled name.)

Change-Id: I4fa3f21851b61079c09deea1a24aac22bc96f36f
Reviewed-on: https://gerrit.libreoffice.org/51766Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
üst 119d8137
......@@ -344,7 +344,7 @@ IPropertyArrayHelper& FrameControl::getInfoHelper()
// attention: properties need to be sorted by name!
static OPropertyArrayHelper ourPropertyInfo(
Property( "ComponentURL", PropertyHandle::Componenturl, cppu::UnoType<OUString>::get(),
Property( "ComponentUrl", PropertyHandle::Componenturl, cppu::UnoType<OUString>::get(),
PropertyAttribute::BOUND | PropertyAttribute::CONSTRAINED ),
Property( "Frame", PropertyHandle::Frame, cppu::UnoType<XFrame>::get(),
PropertyAttribute::BOUND | PropertyAttribute::TRANSIENT ),
......@@ -493,8 +493,7 @@ void Test::createInstance(
{"com.sun.star.comp.report.OFormattedField", "TextColor"},
{"com.sun.star.comp.report.OFormattedField", "TextLineColor"},
{"com.sun.star.comp.report.OFormattedField", "TreatAsNumber"},
{"stardiv.Toolkit.UnoControlRoadmapModel", "Interactive"},
{"stardiv.UnoControls.FrameControl", "ComponentUrl"}};
{"stardiv.Toolkit.UnoControlRoadmapModel", "Interactive"}};
if (blacklist.find({implementationName, prop->getName()}) != blacklist.end()) {
......@@ -147,7 +147,7 @@ void SwOneExampleFrame::CreateControl()
xPrSet->setPropertyValue( "LoaderArguments", aArgs );
//save and set readonly???
xPrSet->setPropertyValue("ComponentURL", aURL);
xPrSet->setPropertyValue("ComponentUrl", aURL);
m_bServiceAvailable = true;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment