Skip to content

C
core
Kaydet (Commit) 5eac2e6b authored tarafından Stephan Bergmann's avatar Stephan Bergmann
Dosyalara gözat
Seçenekler

Remove misguided FALLTHROUGH comments 

...between adjacent switch labels without any intervening statements

Change-Id: Ieb8a0d9f71ea4382b5f7d005cdf7111d06aeb5d0
Reviewed-on: https://gerrit.libreoffice.org/64789
Tested-by: Jenkins
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
üst 8a4d80bc
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 70 deletions
canvas/source/cairo/cairo_canvashelper_text.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -248,7 +248,6 @@ namespace cairocanvas
switch( textDirection )
{
case rendering::TextDirection::WEAK_LEFT_TO_RIGHT:
// FALLTHROUGH intended
case rendering::TextDirection::STRONG_LEFT_TO_RIGHT:
nLayoutMode |= ComplexTextLayoutFlags::BiDiStrong;
nLayoutMode |= ComplexTextLayoutFlags::TextOriginLeft;
......
canvas/source/directx/dx_canvashelper.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -664,7 +664,6 @@ namespace dxcanvas
switch( nMode )
{
case rendering::CompositeOperation::OVER:
// FALLTHROUGH intended
case rendering::CompositeOperation::CLEAR:
aRet = Gdiplus::CompositingModeSourceOver;
break;
......@@ -674,25 +673,15 @@ namespace dxcanvas
break;
case rendering::CompositeOperation::DESTINATION:
// FALLTHROUGH intended
case rendering::CompositeOperation::UNDER:
// FALLTHROUGH intended
case rendering::CompositeOperation::INSIDE:
// FALLTHROUGH intended
case rendering::CompositeOperation::INSIDE_REVERSE:
// FALLTHROUGH intended
case rendering::CompositeOperation::OUTSIDE:
// FALLTHROUGH intended
case rendering::CompositeOperation::OUTSIDE_REVERSE:
// FALLTHROUGH intended
case rendering::CompositeOperation::ATOP:
// FALLTHROUGH intended
case rendering::CompositeOperation::ATOP_REVERSE:
// FALLTHROUGH intended
case rendering::CompositeOperation::XOR:
// FALLTHROUGH intended
case rendering::CompositeOperation::ADD:
// FALLTHROUGH intended
case rendering::CompositeOperation::SATURATE:
// TODO(F2): Problem, because GDI+ only knows about two compositing modes
aRet = Gdiplus::CompositingModeSourceOver;
......
canvas/source/directx/dx_canvashelper_texturefill.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -440,7 +440,6 @@ namespace dxcanvas
break;
case ::canvas::ParametricPolyPolygon::GradientType::Elliptical:
// FALLTHROUGH intended
case ::canvas::ParametricPolyPolygon::GradientType::Rectangular:
fillPolygonalGradient( rValues,
rColors,
......
canvas/source/directx/dx_vcltools.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -252,11 +252,8 @@ namespace dxcanvas
// to hand-formulate the following
// formats, too.
case ScanlineFormat::N1BitMsbPal:
// FALLTHROUGH intended
case ScanlineFormat::N4BitMsnPal:
// FALLTHROUGH intended
case ScanlineFormat::N16BitTcLsbMask:
// FALLTHROUGH intended
case ScanlineFormat::N32BitTcMask:
{
Scanline pAScan = pAlphaReadAccess->GetScanline( y );
......@@ -281,23 +278,14 @@ namespace dxcanvas
break;
case ScanlineFormat::N1BitLsbPal:
// FALLTHROUGH intended
case ScanlineFormat::N4BitLsnPal:
// FALLTHROUGH intended
case ScanlineFormat::N8BitTcMask:
// FALLTHROUGH intended
case ScanlineFormat::N24BitTcRgb:
// FALLTHROUGH intended
case ScanlineFormat::N16BitTcMsbMask:
// FALLTHROUGH intended
case ScanlineFormat::N32BitTcAbgr:
// FALLTHROUGH intended
case ScanlineFormat::N32BitTcArgb:
// FALLTHROUGH intended
case ScanlineFormat::N32BitTcBgra:
// FALLTHROUGH intended
case ScanlineFormat::N32BitTcRgba:
// FALLTHROUGH intended
default:
ENSURE_OR_THROW( false,
"::dxcanvas::tools::bitmapFromVCLBitmapEx(): "
......@@ -403,11 +391,8 @@ namespace dxcanvas
// to hand-formulate the following
// formats, too.
case ScanlineFormat::N1BitMsbPal:
// FALLTHROUGH intended
case ScanlineFormat::N4BitMsnPal:
// FALLTHROUGH intended
case ScanlineFormat::N16BitTcLsbMask:
// FALLTHROUGH intended
case ScanlineFormat::N32BitTcMask:
{
Scanline pMScan = pMaskReadAccess->GetScanline( y );
......@@ -431,23 +416,14 @@ namespace dxcanvas
break;
case ScanlineFormat::N1BitLsbPal:
// FALLTHROUGH intended
case ScanlineFormat::N4BitLsnPal:
// FALLTHROUGH intended
case ScanlineFormat::N8BitTcMask:
// FALLTHROUGH intended
case ScanlineFormat::N24BitTcRgb:
// FALLTHROUGH intended
case ScanlineFormat::N16BitTcMsbMask:
// FALLTHROUGH intended
case ScanlineFormat::N32BitTcAbgr:
// FALLTHROUGH intended
case ScanlineFormat::N32BitTcArgb:
// FALLTHROUGH intended
case ScanlineFormat::N32BitTcBgra:
// FALLTHROUGH intended
case ScanlineFormat::N32BitTcRgba:
// FALLTHROUGH intended
default:
ENSURE_OR_THROW( false,
"::dxcanvas::tools::bitmapFromVCLBitmapEx(): "
......
canvas/source/opengl/ogl_canvashelper.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -875,7 +875,6 @@ namespace oglcanvas
o_action.meDstBlendMode=GL_ZERO;
break;
case rendering::CompositeOperation::UNDER:
// FALLTHROUGH intended - but correct?!
case rendering::CompositeOperation::DESTINATION:
o_action.meSrcBlendMode=GL_ZERO;
o_action.meDstBlendMode=GL_ONE;
......
canvas/source/vcl/canvashelper.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -579,7 +579,6 @@ namespace vclcanvas
switch( textDirection )
{
case rendering::TextDirection::WEAK_LEFT_TO_RIGHT:
// FALLTHROUGH intended
case rendering::TextDirection::STRONG_LEFT_TO_RIGHT:
nLayoutMode |= ComplexTextLayoutFlags::BiDiStrong;
nLayoutMode |= ComplexTextLayoutFlags::TextOriginLeft;
......
canvas/source/vcl/canvashelper_texturefill.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -418,7 +418,6 @@ namespace vclcanvas
break;
case ::canvas::ParametricPolyPolygon::GradientType::Elliptical:
// FALLTHROUGH intended
case ::canvas::ParametricPolyPolygon::GradientType::Rectangular:
fillPolygonalGradient( rOutDev,
rTextureTransform,
......
cppcanvas/source/mtfrenderer/implrenderer.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -1273,7 +1273,6 @@ namespace cppcanvas
break;
case MetaActionType::TEXTLANGUAGE:
// FALLTHROUGH intended
case MetaActionType::REFPOINT:
// handled via pCurrAct->Execute( &rVDev )
break;
......
cppcanvas/source/mtfrenderer/mtftools.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -416,16 +416,12 @@ namespace cppcanvas
switch( rTextLineInfo.mnOverlineStyle )
{
case LINESTYLE_NONE: // nothing to do
// FALLTHROUGH intended
case LINESTYLE_DONTKNOW:
break;
case LINESTYLE_DOUBLEWAVE:
// FALLTHROUGH intended
case LINESTYLE_SMALLWAVE:
// FALLTHROUGH intended
case LINESTYLE_BOLDWAVE:
// FALLTHROUGH intended
case LINESTYLE_WAVE:
appendWaveline(
rTextLinesPolyPoly,
......@@ -498,16 +494,12 @@ namespace cppcanvas
switch( rTextLineInfo.mnUnderlineStyle )
{
case LINESTYLE_NONE: // nothing to do
// FALLTHROUGH intended
case LINESTYLE_DONTKNOW:
break;
case LINESTYLE_DOUBLEWAVE:
// FALLTHROUGH intended
case LINESTYLE_SMALLWAVE:
// FALLTHROUGH intended
case LINESTYLE_BOLDWAVE:
// FALLTHROUGH intended
case LINESTYLE_WAVE:
appendWaveline(
rTextLinesPolyPoly,
......@@ -579,12 +571,10 @@ namespace cppcanvas
switch( rTextLineInfo.mnStrikeoutStyle )
{
case STRIKEOUT_NONE: // nothing to do
// FALLTHROUGH intended
case STRIKEOUT_DONTKNOW:
break;
case STRIKEOUT_SLASH: // TODO(Q1): we should handle this in the text layer
// FALLTHROUGH intended
case STRIKEOUT_X:
break;
......
filter/source/svg/presentation_engine.js
Dosyayı görüntüle @ 5eac2e6b
......@@ -14802,9 +14802,7 @@ function createActivity( aActivityParamSet, aAnimationNode, aAnimation, aInterpo
log( 'createActivity: unexpected calculation mode: ' + eCalcMode );
// FALLTHROUGH intended
case CALC_MODE_PACED :
// FALLTHROUGH intended
case CALC_MODE_SPLINE :
// FALLTHROUGH intended
case CALC_MODE_LINEAR:
return createValueListActivity( aActivityParamSet,
aAnimationNode,
......@@ -14837,9 +14835,7 @@ function createActivity( aActivityParamSet, aAnimationNode, aAnimation, aInterpo
log( 'createActivity: unexpected calculation mode: ' + eCalcMode );
// FALLTHROUGH intended
case CALC_MODE_PACED :
// FALLTHROUGH intended
case CALC_MODE_SPLINE :
// FALLTHROUGH intended
case CALC_MODE_LINEAR:
return createFromToByActivity( aActivityParamSet,
aAnimationNode,
......
sd/source/filter/ppt/pptinanimations.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -1294,9 +1294,7 @@ sal_Int16 AnimationImporter::implGetColorSpace( sal_Int32 nMode, sal_Int32 /*nA*
switch( nMode )
{
case 2: // index
// FALLTHROUGH intended
default:
// FALLTHROUGH intended
case 0: // rgb
return AnimationColorSpace::RGB;
......
sdext/source/pdfimport/wrapper/wrapper.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -401,7 +401,6 @@ void Parser::readLineCap()
switch( readInt32() )
{
default:
// FALLTHROUGH intended
case 0: nCap = rendering::PathCapType::BUTT; break;
case 1: nCap = rendering::PathCapType::ROUND; break;
case 2: nCap = rendering::PathCapType::SQUARE; break;
......@@ -434,7 +433,6 @@ void Parser::readLineJoin()
switch( readInt32() )
{
default:
// FALLTHROUGH intended
case 0: nJoin = rendering::PathJoinType::MITER; break;
case 1: nJoin = rendering::PathJoinType::ROUND; break;
case 2: nJoin = rendering::PathJoinType::BEVEL; break;
......
slideshow/source/engine/animationnodes/animationtransformnode.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -51,7 +51,6 @@ AnimationActivitySharedPtr AnimationTransformNode::createActivity() const
"Unknown transform type" );
case animations::AnimationTransformType::TRANSLATE:
// FALLTHROUGH intended
case animations::AnimationTransformType::SCALE:
return ActivitiesFactory::createAnimateActivity(
aParms,
......
slideshow/source/engine/slide/targetpropertiescreator.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -188,19 +188,12 @@ namespace internal
break;
case animations::AnimationNodeType::CUSTOM:
// FALLTHROUGH intended
case animations::AnimationNodeType::ANIMATE:
// FALLTHROUGH intended
case animations::AnimationNodeType::ANIMATEMOTION:
// FALLTHROUGH intended
case animations::AnimationNodeType::ANIMATECOLOR:
// FALLTHROUGH intended
case animations::AnimationNodeType::ANIMATETRANSFORM:
// FALLTHROUGH intended
case animations::AnimationNodeType::TRANSITIONFILTER:
// FALLTHROUGH intended
case animations::AnimationNodeType::AUDIO:
// FALLTHROUGH intended
/*default:
// ignore this node, no valuable content for now.
break;*/
......
slideshow/source/engine/transitions/slidetransitionfactory.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -1063,9 +1063,7 @@ NumberAnimationSharedPtr TransitionFactory::createSlideTransition(
// TODO(F1): Implement toColor/fromColor fades
case animations::TransitionSubType::FADETOCOLOR:
// FALLTHROUGH intended
case animations::TransitionSubType::FADEFROMCOLOR:
// FALLTHROUGH intended
case animations::TransitionSubType::FADEOVERCOLOR:
if (pLeavingSlide) {
// only generate, if fade
......
vcl/win/window/salframe.cxx
Dosyayı görüntüle @ 5eac2e6b
......@@ -5512,7 +5512,6 @@ static LRESULT CALLBACK SalFrameWndProc( HWND hWnd, UINT nMsg, WPARAM wParam, LP
break;
case WM_MOUSEWHEEL:
// FALLTHROUGH intended
case WM_MOUSEHWHEEL:
// protect against recursion, in case the message is returned
// by IE or the external window
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment