Skip to content

C
core
Kaydet (Commit) 5c90069d authored tarafından Caolán McNamara's avatar Caolán McNamara
Dosyalara gözat
Seçenekler

coverity#1326211 Unchecked dynamic_cast 

Change-Id: I09892b8e17aacf32db51764d8fd766603a8542e1
üst 95ddc77f
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 6 deletions
sd/source/ui/dlg/navigatr.cxx
Dosyayı görüntüle @ 5c90069d
...@@ -871,9 +871,8 @@ void SdNavigatorControllerItem::StateChanged( sal_uInt16 nSId, ...@@ -871,9 +871,8 @@ void SdNavigatorControllerItem::StateChanged( sal_uInt16 nSId,
{ {
if( eState >= SfxItemState::DEFAULT && nSId == SID_NAVIGATOR_STATE ) if( eState >= SfxItemState::DEFAULT && nSId == SID_NAVIGATOR_STATE )
{ {
const SfxUInt32Item* pStateItem = dynamic_cast< const SfxUInt32Item* >( pItem ); const SfxUInt32Item& rStateItem = dynamic_cast<const SfxUInt32Item&>(*pItem);
DBG_ASSERT( pStateItem, "SfxUInt16Item expected"); sal_uInt32 nState = rStateItem.GetValue();
sal_uInt32 nState = pStateItem->GetValue();
// pen // pen
if( nState & NAVBTN_PEN_DISABLED && if( nState & NAVBTN_PEN_DISABLED &&
...@@ -955,9 +954,8 @@ void SdPageNameControllerItem::StateChanged( sal_uInt16 nSId, ...@@ -955,9 +954,8 @@ void SdPageNameControllerItem::StateChanged( sal_uInt16 nSId,
NavDocInfo* pInfo = pNavigatorWin->GetDocInfo(); NavDocInfo* pInfo = pNavigatorWin->GetDocInfo();
if( pInfo && pInfo->IsActive() ) if( pInfo && pInfo->IsActive() )
{ {
const SfxStringItem* pStateItem = dynamic_cast<const SfxStringItem*>( pItem ); const SfxStringItem& rStateItem = dynamic_cast<const SfxStringItem&>(*pItem);
DBG_ASSERT( pStateItem, "SfxStringItem expected"); OUString aPageName = rStateItem.GetValue();
OUString aPageName = pStateItem->GetValue();
if( !pNavigatorWin->maTlbObjects->HasSelectedChildren( aPageName ) ) if( !pNavigatorWin->maTlbObjects->HasSelectedChildren( aPageName ) )
{ {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment