osl: Windows pipe converted from OSL_ASSERT to assert/SAL_WARNs
Explanation for each conversion: - osl_acceptPipe() - don't worry about an invalid oslPipe sent as function parameter, we check for the error returned by ConnectNamedPipe(), and without a valid pipe we just need to return nullptr - warn if INVALID_HANDLE_VALUE for the file handle, should be handled by ConnectNamedPipe() - createPipeImpl() allocates and initializes memory for the oslPipeImpl structure, if it can't do this then something has been done wrongly - osl_receivePipe() - invalid pipe needs to assert because ResetEvent needs valid pPipe->m_ReadEvent - osl_sendPipe() - invalid pipe needs to assert because ResetEvent needs valid pPipe->m_ReadEvent - osl_writePipe() - really just a thin wrapper around osl_sendPipe() - osl_readPipe() - really just a thin wrapper around osl_receivePipe() Change-Id: I581f8aa996375a8691eafaa384d3f63f0c92b0a2 Reviewed-on: https://gerrit.libreoffice.org/40262Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Showing
Please
register
or
sign in
to comment