svtools: remove function with unused return value

and inline only functionality

Change-Id: I79b0ec29dcc35e9dc92aaac9fb191c882a9b0621
Reviewed-on: https://gerrit.libreoffice.org/41362Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

compilerplugins/clang/unusedmethods.unused-returns.results

@@ -246,8 +246,6 @@ include/sax/fshelper.hxx:206
     class sax_fastparser::FastSerializerHelper * sax_fastparser::FastSerializerHelper::write(long)
 include/sax/fshelper.hxx:209
     class sax_fastparser::FastSerializerHelper * sax_fastparser::FastSerializerHelper::writeEscaped(const char *)
-include/svtools/treelistbox.hxx:536
-    short SvTreeListBox::GetHeightOffset(const class Image &,class Size &)
 include/test/sheet/xnamedrange.hxx:22
     class com::sun::star::uno::Reference<class com::sun::star::uno::XInterface> apitest::XNamedRange::init()
 include/test/sheet/xsheetannotation.hxx:36

include/svtools/treelistbox.hxx

@@ -526,8 +526,6 @@ public:
 protected:
     using SvListView::SelectAll;
 
-    SVT_DLLPRIVATE short        GetHeightOffset( const Image& rBmp, Size& rLogicSize);
-
     SVT_DLLPRIVATE void         SetEntryHeight( SvTreeListEntry const * pEntry );
     SVT_DLLPRIVATE void         AdjustEntryHeight( const Image& rBmp );
     SVT_DLLPRIVATE void         AdjustEntryHeight();

svtools/source/contnr/svimpbox.cxx

@@ -1567,8 +1567,7 @@ void SvImpLBox::CollapsingEntry( SvTreeListEntry* pEntry )
 
 void SvImpLBox::SetNodeBmpYOffset( const Image& rBmp )
 {
-    Size aSize;
-    pView->GetHeightOffset( rBmp, aSize );
+    const Size aSize( rBmp.GetSizePixel() );
     nNodeBmpWidth = aSize.Width();
 }
 

svtools/source/contnr/treelistbox.cxx

@@ -2129,15 +2129,6 @@ void SvTreeListBox::SetDragDropMode( DragDropMode nDDMode )
     pImpl->SetDragDropMode( nDDMode );
 }
 
-short SvTreeListBox::GetHeightOffset(const Image& rBmp, Size& aSizeLogic )
-{
-    short nOffset = 0;
-    aSizeLogic = rBmp.GetSizePixel();
-    if( GetEntryHeight() > aSizeLogic.Height() )
-        nOffset = ( GetEntryHeight() - (short)aSizeLogic.Height()) / 2;
-    return nOffset;
-}
-
 void SvTreeListBox::SetEntryHeight( SvTreeListEntry const * pEntry )
 {
     short nHeightMax=0;
@@ -2181,8 +2172,7 @@ void SvTreeListBox::SetEntryWidth( short nWidth )
 
 void SvTreeListBox::AdjustEntryHeight( const Image& rBmp )
 {
-    Size aSize;
-    GetHeightOffset( rBmp, aSize );
+    const Size aSize( rBmp.GetSizePixel() );
     if( aSize.Height() > nEntryHeight )
     {
         nEntryHeight = (short)aSize.Height() + nEntryHeightOffs;