cppcheck: fix duplicateBranch
Git history shows it was like this since first commit (2009-12-15) Moreover I noticed these lines: 220 if ( mpCGM->pElement->nAspectSourceFlags & ASF_FILLCOLOR ) 221 nFillColor = mpCGM->pElement->pFillBundle->GetColor(); 222 else 223 nFillColor = mpCGM->pElement->aFillBundle.GetColor(); even if nFillColor can have another value in case below 249 case FIS_GEOPATTERN : 250 { 251 if ( mpCGM->pElement->eTransparency == T_ON ) 252 nFillColor = mpCGM->pElement->nAuxiliaryColor; 253 eFS = drawing::FillStyle_NONE; 254 } this change is still safe since it's just a simplification. Change-Id: Icf41dbeee6405780483649e0968dd30e8a533882
Showing
Please
register
or
sign in
to comment