loplugin:constfields in scripting

Change-Id: I1484d920649817680f70de4ca00a3d46e1faf42a
Reviewed-on: https://gerrit.libreoffice.org/61554
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

scripting/source/basprov/baslibnode.hxx

@@ -44,12 +44,12 @@ namespace basprov
     {
     private:
         css::uno::Reference< css::uno::XComponentContext >    m_xContext;
-        OUString                                              m_sScriptingContext;
-        BasicManager*                                         m_pBasicManager;
+        OUString const                                        m_sScriptingContext;
+        BasicManager* const                                   m_pBasicManager;
         css::uno::Reference< css::script::XLibraryContainer > m_xLibContainer;
         css::uno::Reference< css::container::XNameContainer > m_xLibrary;
-        OUString                                              m_sLibName;
-        bool                                                  m_bIsAppScript;
+        OUString const                                        m_sLibName;
+        bool const                                            m_bIsAppScript;
 
     public:
         BasicLibraryNodeImpl( const css::uno::Reference< css::uno::XComponentContext >& rxContext,

scripting/source/basprov/basmethnode.hxx

@@ -53,9 +53,9 @@ namespace basprov
     {
     private:
         css::uno::Reference< css::uno::XComponentContext >    m_xContext;
-        OUString m_sScriptingContext;
+        OUString const m_sScriptingContext;
         SbMethod* m_pMethod;
-        bool m_bIsAppScript;
+        bool const m_bIsAppScript;
 
         // properties
         OUString m_sURI;

scripting/source/basprov/basmodnode.hxx

@@ -43,9 +43,9 @@ namespace basprov
     {
     private:
         css::uno::Reference< css::uno::XComponentContext >    m_xContext;
-        OUString m_sScriptingContext;
+        OUString const m_sScriptingContext;
         SbModule* m_pModule;
-        bool m_bIsAppScript;
+        bool const m_bIsAppScript;
 
     public:
         BasicModuleNodeImpl( const css::uno::Reference< css::uno::XComponentContext >& rxContext,

scripting/source/basprov/basscript.hxx

@@ -51,7 +51,7 @@ namespace basprov
     {
     private:
         SbMethodRef         m_xMethod;
-        OUString            m_funcName;
+        OUString const      m_funcName;
         BasicManager*       m_documentBasicManager;
         css::uno::Reference< css::document::XScriptInvocationContext >
                             m_xDocumentScriptContext;

scripting/source/dlgprov/dlgevtatt.cxx

@@ -81,7 +81,7 @@ namespace dlgprov
     Reference< awt::XControl > m_xControl;
         Reference< XInterface > m_xHandler;
     Reference< beans::XIntrospectionAccess > m_xIntrospectionAccess;
-    bool m_bDialogProviderMode;
+    bool const m_bDialogProviderMode;
 
         virtual void firing_impl( const script::ScriptEvent& aScriptEvent, uno::Any* pRet ) override;
 
@@ -99,7 +99,7 @@ namespace dlgprov
     {
         protected:
         OUString msDialogCodeName;
-        OUString msDialogLibName;
+        OUString const msDialogLibName;
         Reference<  script::XScriptListener > mxListener;
         virtual void firing_impl( const script::ScriptEvent& aScriptEvent, uno::Any* pRet ) override;
         public:

scripting/source/dlgprov/dlgevtatt.hxx

@@ -85,8 +85,8 @@ namespace dlgprov
     {
     private:
         css::uno::Reference< css::script::XScriptListener > m_xScriptListener;
-        OUString m_sScriptType;
-        OUString m_sScriptCode;
+        OUString const m_sScriptType;
+        OUString const m_sScriptCode;
 
         void firing_impl( const css::script::AllEventObject& Event, css::uno::Any* pRet );
 

scripting/source/provider/ProviderCache.hxx

@@ -83,7 +83,7 @@ private:
     css::uno::Sequence< OUString >  m_sBlackList;
     ProviderDetails_hash  m_hProviderDetailsCache;
     osl::Mutex m_mutex;
-    css::uno::Sequence< css::uno::Any >  m_Sctx;
+    css::uno::Sequence< css::uno::Any > const  m_Sctx;
     css::uno::Reference< css::uno::XComponentContext > m_xContext;
     css::uno::Reference< css::lang::XMultiComponentFactory > m_xMgr;
 

scripting/source/stringresource/stringresource.cxx

@@ -1307,7 +1307,7 @@ void StringResourcePersistenceImpl::implWriteLocaleBinary
 
 class BinaryInput
 {
-    Sequence< sal_Int8 >                    m_aData;
+    Sequence< sal_Int8 > const              m_aData;
     Reference< XComponentContext >          m_xContext;
 
     const sal_Int8*                         m_pData;

scripting/source/vbaevents/eventhelper.cxx

@@ -178,8 +178,8 @@ typedef std::unordered_map<
 
 struct TranslatePropMap
 {
-    OUString sEventInfo;   //OO event name
-    TranslateInfo aTransInfo;
+    OUString const sEventInfo;   //OO event name
+    TranslateInfo const aTransInfo;
 };
 
 static bool ApproveAll(const ScriptEvent& evt, void const * pPara); //allow all types of controls to execute the event
@@ -190,7 +190,7 @@ static bool DenyMouseDrag(const ScriptEvent& evt, void const * pPara); //used fo
 struct TypeList
 {
     uno::Type const * pTypeList;
-    int nListLength;
+    int const nListLength;
 };
 
 Type const typeXFixedText = cppu::UnoType<awt::XFixedText>::get();
@@ -296,7 +296,7 @@ public:
 private:
     Reference< XComponentContext > m_xCtx;
     Reference< XInterface > m_xControl;
-    bool m_bDispose;
+    bool const m_bDispose;
 };
 
 static bool