loplugin:unusedmethods

Change-Id: I085394e0f4b780dc5b376d5ac0e9d761434e3ead
Reviewed-on: https://gerrit.libreoffice.org/68301
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

basctl/source/basicide/moduldl2.cxx

@@ -219,24 +219,6 @@ SvTreeListEntry* CheckBox::FindEntry( const OUString& rName )
     return nullptr;
 }
 
-void CheckBox::CheckEntryPos( sal_uLong nPos )
-{
-    if ( nPos < GetEntryCount() )
-    {
-        SvTreeListEntry* pEntry = GetEntry( nPos );
-
-        if ( GetCheckButtonState( pEntry ) != SvButtonState::Checked )
-            SetCheckButtonState( pEntry, SvButtonState::Checked );
-    }
-}
-
-bool CheckBox::IsChecked( sal_uLong nPos ) const
-{
-    if ( nPos < GetEntryCount() )
-        return GetCheckButtonState(GetEntry(nPos)) == SvButtonState::Checked;
-    return false;
-}
-
 void CheckBox::InitEntry(SvTreeListEntry* pEntry, const OUString& rTxt,
     const Image& rImg1, const Image& rImg2, SvLBoxButtonKind eButtonKind )
 {

basctl/source/basicide/moduldlg.hxx

@@ -123,9 +123,6 @@ public:
     SvTreeListEntry*    DoInsertEntry( const OUString& rStr, sal_uLong nPos = LISTBOX_APPEND );
     SvTreeListEntry*    FindEntry( const OUString& rName );
 
-    void            CheckEntryPos( sal_uLong nPos );
-    bool            IsChecked( sal_uLong nPos ) const;
-
     virtual void    InitEntry(SvTreeListEntry*, const OUString&, const Image&, const Image&, SvLBoxButtonKind eButtonKind) override;
     virtual bool    EditingEntry( SvTreeListEntry* pEntry, Selection& rSel ) override;
     virtual bool    EditedEntry( SvTreeListEntry* pEntry, const OUString& rNewText ) override;

compilerplugins/clang/unusedmethods.unused-returns.results

@@ -20,7 +20,7 @@ extensions/source/scanner/sanedlg.hxx:103
     _Bool SaneDlg::SetAdjustedNumericalValue(const char *,double,int)
 filter/source/flash/swfexporter.hxx:85
     _Bool swf::FlashExporter::exportAll(const class com::sun::star::uno::Reference<class com::sun::star::lang::XComponent> &,const class com::sun::star::uno::Reference<class com::sun::star::io::XOutputStream> &,const class com::sun::star::uno::Reference<class com::sun::star::task::XStatusIndicator> &)
-i18nlangtag/source/languagetag/languagetag.cxx:275
+i18nlangtag/source/languagetag/languagetag.cxx:276
     const class rtl::OUString & LanguageTagImpl::getBcp47() const
 idlc/inc/aststack.hxx:38
     class AstStack * AstStack::push(class AstScope *)
@@ -162,7 +162,7 @@ include/svl/poolitem.hxx:169
     class SvStream & SfxPoolItem::Store(class SvStream &,unsigned short) const
 include/svx/checklbx.hxx:76
     void * SvxCheckListBox::SetEntryData(unsigned long,void *)
-include/svx/dlgctrl.hxx:105
+include/svx/dlgctrl.hxx:106
     class Point SvxRectCtl::SetActualRPWithoutInvalidate(enum RectPoint)
 include/svx/framelink.hxx:195
     class svx::frame::Style & svx::frame::Style::MirrorSelf()
@@ -192,6 +192,8 @@ include/vcl/bitmap.hxx:171
     _Bool Bitmap::Dither()
 include/vcl/bitmapex.hxx:241
     _Bool BitmapEx::Rotate(long,const class Color &)
+include/vcl/filter/PngImageReader.hxx:31
+    _Bool vcl::PngImageReader::read(class BitmapEx &)
 include/vcl/fontcharmap.hxx:49
     class tools::SvRef<class FontCharMap> FontCharMap::GetDefaultMap(_Bool)
 include/vcl/gdimtf.hxx:185
@@ -208,7 +210,11 @@ include/vcl/texteng.hxx:275
     _Bool TextEngine::Read(class SvStream &,const class TextSelection *)
 include/vcl/toolbox.hxx:513
     _Bool ToolBox::ChangeHighlightUpDn(_Bool)
-include/vcl/weld.hxx:1219
+include/vcl/weld.hxx:320
+    _Bool weld::Dialog::runAsync(const class std::function<void (int)> &)
+include/vcl/weld.hxx:596
+    _Bool weld::TreeView::iter_nth_child(class weld::TreeIter &,int) const
+include/vcl/weld.hxx:1321
     _Bool weld::TextView::get_selection_bounds(int &,int &)
 lotuswordpro/inc/lwpsvstream.hxx:76
     class LwpSvStream & LwpSvStream::ReadUInt8(unsigned char &)
@@ -216,15 +222,15 @@ lotuswordpro/inc/lwpsvstream.hxx:77
     class LwpSvStream & LwpSvStream::ReadUInt16(unsigned short &)
 lotuswordpro/inc/lwpsvstream.hxx:78
     class LwpSvStream & LwpSvStream::ReadUInt32(unsigned int &)
-sc/inc/document.hxx:1404
+sc/inc/document.hxx:1412
     _Bool ScDocument::GetDataAreaSubrange(class ScRange &) const
-sc/inc/document.hxx:2126
+sc/inc/document.hxx:2134
     const struct ScDocumentThreadSpecific & ScDocument::CalculateInColumnInThread(struct ScInterpreterContext &,const class ScAddress &,unsigned long,unsigned int,unsigned int)
 sc/inc/orcusfilters.hxx:44
     _Bool ScOrcusFilters::importODS_Styles(class ScDocument &,class rtl::OUString &) const
-sc/source/core/opencl/formulagroupcl.cxx:1084
+sc/source/core/opencl/formulagroupcl.cxx:1086
     unsigned long sc::opencl::DynamicKernelSlidingArgument::GenReductionLoopHeader(class std::__cxx11::basic_stringstream<char> &,_Bool &)
-sc/source/core/opencl/formulagroupcl.cxx:1529
+sc/source/core/opencl/formulagroupcl.cxx:1531
     unsigned long sc::opencl::ParallelReductionVectorRef::GenReductionLoopHeader(class std::__cxx11::basic_stringstream<char> &,int,_Bool &)
 sc/source/filter/inc/workbookhelper.hxx:259
     _Bool oox::xls::WorkbookHelper::importOoxFragment(const class rtl::Reference<class oox::core::FragmentHandler> &,class oox::core::FastParser &)
@@ -278,11 +284,11 @@ sw/inc/authfld.hxx:98
     unsigned short SwAuthorityFieldType::AppendField(const class SwAuthEntry &)
 sw/inc/calc.hxx:114
     class SwSbxValue & SwSbxValue::MakeDouble()
-sw/inc/doc.hxx:1077
+sw/inc/doc.hxx:1080
     _Bool SwDoc::ReplaceNumRule(const struct SwPosition &,const class rtl::OUString &,const class rtl::OUString &)
-sw/inc/doc.hxx:1238
+sw/inc/doc.hxx:1241
     _Bool SwDoc::SetColRowWidthHeight(class SwTableBox &,enum TableChgWidthHeightType,long,long)
-sw/inc/doc.hxx:1263
+sw/inc/doc.hxx:1266
     _Bool SwDoc::SplitTable(const struct SwPosition &,enum SplitTable_HeadlineOption,_Bool)
 sw/inc/editsh.hxx:266
     _Bool SwEditShell::GetPaMParAttr(class SwPaM *,class SfxItemSet &) const
@@ -308,7 +314,7 @@ ucb/source/ucp/webdav-neon/ContentProperties.hxx:169
     _Bool webdav_ucp::CachableContentProperties::containsAllNames(const class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,class std::__debug::vector<class rtl::OUString, class std::allocator<class rtl::OUString> > &) const
 ucb/source/ucp/webdav-neon/NeonSession.hxx:240
     _Bool webdav_ucp::NeonSession::UNLOCK(struct ne_lock *)
-vcl/inc/font/FeatureCollector.hxx:48
+vcl/inc/font/FeatureCollector.hxx:47
     _Bool vcl::font::FeatureCollector::collect()
 vcl/inc/opengl/salbmp.hxx:100
     _Bool OpenGLSalBitmap::ImplScaleFilter(const class rtl::Reference<class OpenGLContext> &,const double &,const double &,unsigned int)

include/svtools/simptabl.hxx

@@ -55,7 +55,6 @@ class SVT_DLLPUBLIC SvSimpleTable : public SvHeaderTabListBox
 private:
     SvSimpleTableContainer& m_rParentTableContainer;
 
-    Link<SvSimpleTable*, void> aHeaderBarClickLink;
     Link<SvSimpleTable*, void> aCommandLink;
     CommandEvent        aCEvt;
     VclPtr<HeaderBar>   aHeaderBar;
@@ -109,7 +108,6 @@ public:
     void            DisableTable();
     bool            IsEnabled() const;
 
-    sal_uInt16      GetSelectedCol();
     void            SortByCol(sal_uInt16, bool bDir=true);
     bool            GetSortDirection(){ return bSortDirection;}
     sal_uInt16      GetSortedCol(){ return nSortCol;}
@@ -119,7 +117,6 @@ public:
     bool     IsFocusOnCellEnabled() const { return IsCellFocusEnabled(); }
     void            SetCommandHdl( const Link<SvSimpleTable*,void>& rLink ) { aCommandLink = rLink; }
 
-    void            SetHeaderBarClickHdl( const Link<SvSimpleTable*,void>& rLink ) { aHeaderBarClickLink = rLink; }
     HeaderBar&      GetTheHeaderBar() { return *aHeaderBar; }
 };
 

include/svx/langbox.hxx

@@ -68,7 +68,6 @@ public:
     void            InsertSystemLanguage();
     void            InsertLanguage( const LanguageType eLangType,
                                     bool bCheckEntry );
-    void            RemoveLanguage( const LanguageType eLangType );
     void            SelectLanguage( const LanguageType eLangType );
     LanguageType    GetSelectedLanguage() const;
     bool            IsLanguageSelected( const LanguageType eLangType ) const;

include/svx/txencbox.hxx

@@ -59,8 +59,6 @@ public:
      */
     void                FillWithMimeAndSelectBest();
 
-    void                InsertTextEncoding( const rtl_TextEncoding nEnc );
-
     void                InsertTextEncoding( const rtl_TextEncoding nEnc,
                             const OUString& rEntry );
 

include/unotools/confignode.hxx

@@ -149,7 +149,6 @@ namespace utl
 
         /// checks whether or not a direct child with a given name exists
         bool hasByName(const OUString& _rName) const throw();
-        bool hasByName( const sal_Char* _pAsciiName ) const { return hasByName( OUString::createFromAscii( _pAsciiName ) ); }
 
         /// checks whether or not a descendent (no matter if direct or indirect) with the given name exists
         bool hasByHierarchicalName( const OUString& _rName ) const throw();

include/vcl/ctrl.hxx

@@ -164,7 +164,6 @@ public:
 
     void            SetGetFocusHdl( const Link<Control&,void>& rLink ) { maGetFocusHdl = rLink; }
     void            SetLoseFocusHdl( const Link<Control&,void>& rLink ) { maLoseFocusHdl = rLink; }
-    const Link<Control&,void>& GetLoseFocusHdl() const { return maLoseFocusHdl; }
 
     /** determines whether the control currently has the focus
     */

sd/source/ui/dlg/sdtreelb.cxx

@@ -712,24 +712,6 @@ OUString SdPageObjsTLB::GetSelectedEntry()
     return GetEntryText( GetCurEntry() );
 }
 
-std::vector<OUString> SdPageObjsTLB::GetSelectEntryList( const sal_uInt16 nDepth ) const
-{
-    std::vector<OUString> aEntries;
-    SvTreeListEntry* pEntry = FirstSelected();
-
-    while( pEntry )
-    {
-        sal_uInt16 nListDepth = GetModel()->GetDepth( pEntry );
-
-        if( nListDepth == nDepth )
-            aEntries.push_back(GetEntryText(pEntry));
-
-        pEntry = NextSelected( pEntry );
-    }
-
-    return aEntries;
-}
-
 /**
  * Entries are inserted only by request (double click)
  */

sd/source/ui/inc/sdtreelb.hxx

@@ -212,12 +212,6 @@ public:
     void                    SetSaveTreeItemStateFlag(bool bState){mbSaveTreeItemState = bState;}
     void                    SaveExpandedTreeItemState(SvTreeListEntry* pEntry, std::vector<OUString>& vectTreeItem);
 
-    /** return selected entries
-          nDepth == 0 -> pages
-          nDepth == 1 -> objects  */
-
-    std::vector<OUString> GetSelectEntryList (const sal_uInt16 nDepth) const;
-
     SdDrawDocument*         GetBookmarkDoc(SfxMedium* pMedium = nullptr);
 
     bool                    IsLinkableSelected() const { return mbLinkableSelected; }

svtools/source/contnr/simptabl.cxx

@@ -267,11 +267,6 @@ bool SvSimpleTable::IsEnabled() const
     return m_rParentTableContainer.IsEnabled();
 }
 
-sal_uInt16 SvSimpleTable::GetSelectedCol()
-{
-    return (aHeaderBar->GetCurItemId()-1);
-}
-
 void SvSimpleTable::SortByCol(sal_uInt16 nCol, bool bDir)
 {
     if(nSortCol!=0xFFFF)
@@ -326,8 +321,6 @@ void SvSimpleTable::HBarClick()
     {
         SortByCol(nId-1,bSortDirection);
     }
-
-    aHeaderBarClickLink.Call(this);
 }
 
 void SvSimpleTable::HBarDrag()

svx/source/dialog/langbox.cxx

@@ -402,15 +402,6 @@ void SvxLanguageBoxBase::InsertLanguage( const LanguageType nLangType,
 }
 
 
-void SvxLanguageBoxBase::RemoveLanguage( const LanguageType eLangType )
-{
-    sal_Int32 nAt = ImplTypeToPos( eLangType );
-
-    if ( nAt != LISTBOX_ENTRY_NOTFOUND )
-        ImplRemoveEntryAt( nAt );
-}
-
-
 LanguageType SvxLanguageBoxBase::GetSelectedLanguage() const
 {
     sal_Int32     nPos   = ImplGetSelectedEntryPos();

svx/source/dialog/txencbox.cxx

@@ -217,16 +217,6 @@ void SvxTextEncodingBox::InsertTextEncoding( const rtl_TextEncoding nEnc,
 }
 
 
-void SvxTextEncodingBox::InsertTextEncoding( const rtl_TextEncoding nEnc )
-{
-    const OUString& rEntry = SvxTextEncodingTable::GetTextString(nEnc);
-    if ( !rEntry.isEmpty() )
-        InsertTextEncoding( nEnc, rEntry );
-    else
-        SAL_WARN( "svx.dialog", "SvxTextEncodingBox::InsertTextEncoding: no resource string for text encoding: " << static_cast<sal_Int32>( nEnc ) );
-}
-
-
 rtl_TextEncoding SvxTextEncodingBox::GetSelectTextEncoding() const
 {
     sal_Int32 nPos = GetSelectedEntryPos();

svx/source/unodialogs/textconversiondlgs/chinese_dictionarydialog.hxx

@@ -66,8 +66,6 @@ public:
     DictionaryEntry* getEntryOnPos( sal_Int32 nPos ) const;
     DictionaryEntry* getFirstSelectedEntry() const;
 
-    void sortByColumn( sal_uInt16 nSortColumnIndex, bool bSortAtoZ );
-
     void set_size_request(int nWidth, int nHeight) { m_xControl->set_size_request(nWidth, nHeight); }
     void hide() { m_xControl->hide(); }
     void show() { m_xControl->show(); }

xmlsecurity/inc/certificateviewer.hxx

@@ -113,7 +113,6 @@ private:
     std::unique_ptr<weld::TextView> m_xValueDetails;
 
     DECL_LINK(ElementSelectHdl, weld::TreeView&, void);
-    void                Clear();
     void                InsertElement(const OUString& rField, const OUString& rValue,
                                       const OUString& rDetails, bool bFixedWidthFont = false);
 public:
@@ -148,7 +147,6 @@ private:
 
     DECL_LINK(ViewCertHdl, weld::Button&, void);
     DECL_LINK(CertSelectHdl, weld::TreeView&, void);
-    void                Clear();
     void                InsertCert(weld::TreeIter* pParent, const OUString& _rName,
                                    const css::uno::Reference< css::security::XCertificate >& rxCert,
                                    bool bValid);

xmlsecurity/source/dialogs/certificateviewer.cxx

@@ -143,13 +143,6 @@ CertificateViewerGeneralTP::CertificateViewerGeneralTP(weld::Container* pParent,
     }
 }
 
-void CertificateViewerDetailsTP::Clear()
-{
-    m_xValueDetails->set_text(OUString());
-    m_aUserData.clear();
-    m_xElementsLB->clear();
-}
-
 void CertificateViewerDetailsTP::InsertElement(const OUString& rField, const OUString& rValue,
                                                const OUString& rDetails, bool bFixedWidthFont)
 {
@@ -360,13 +353,6 @@ IMPL_LINK_NOARG(CertificateViewerCertPathTP, CertSelectHdl, weld::TreeView&, voi
     mxViewCertPB->set_sensitive(bSensitive);
 }
 
-void CertificateViewerCertPathTP::Clear()
-{
-    mxCertStatusML->set_text(OUString());
-    maUserData.clear();
-    mxCertPathLB->clear();
-}
-
 void CertificateViewerCertPathTP::InsertCert(weld::TreeIter* pParent, const OUString& rName,
                                              const css::uno::Reference< css::security::XCertificate >& rxCert,
                                              bool bValid)