Kaydet (Commit) 34806c91 authored tarafından Stephan Bergmann's avatar Stephan Bergmann

Don't use bitfield bool members in MenuBarManager

For one, there's likely few enough instances of MenuBarManager that the code
pessimization of using bitfields probably weighs worse than the space
optimization.  For another, the code generated by at least Clang trunk tends to
confuse Valgrind, <https://bugs.kde.org/show_bug.cgi?id=242137> "Valgrind on
LLVM compiled code reports tons of 'Conditional jump or move depends on
uninitialised' false positives".

Change-Id: I4c2ef22e7e54e2a220e2cb490ca0566af4f81f52
üst b6fc8ae0
......@@ -202,15 +202,15 @@ class MenuBarManager : public css::frame::XStatusListener ,
void Init(const css::uno::Reference< css::frame::XFrame >& rFrame,Menu* pAddonMenu,bool bDelete,bool bDeleteChildren,bool _bHandlePopUp);
void SetHdl();
bool m_bDisposed : 1,
m_bInitialized : 1,
m_bDeleteMenu : 1,
m_bDeleteChildren : 1,
m_bActive : 1,
m_bIsBookmarkMenu : 1,
m_bShowMenuImages : 1;
bool m_bRetrieveImages : 1,
m_bAcceleratorCfg : 1;
bool m_bDisposed;
bool m_bInitialized;
bool m_bDeleteMenu;
bool m_bDeleteChildren;
bool m_bActive;
bool m_bIsBookmarkMenu;
bool m_bShowMenuImages;
bool m_bRetrieveImages;
bool m_bAcceleratorCfg;
bool m_bModuleIdentified;
bool m_bHasMenuBar;
OUString m_aMenuItemCommand;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment