Calling ActivatePage directly is unnecessary

After this commit:
b426b026

Change-Id: I15d491d4cf63db4436ad8d3db0320cd2e26bb3ea
Reviewed-on: https://gerrit.libreoffice.org/47078Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>

cui/source/inc/cuitabarea.hxx

@@ -113,8 +113,6 @@ class SvxAreaTabDialog final : public SfxTabDialog
     XPatternListRef       mpPatternList;
     XPatternListRef       mpNewPatternList;
 
-    const SfxItemSet&   mrOutAttrs;
-
     ChangeType          mnColorListState;
     ChangeType          mnBitmapListState;
     ChangeType          mnPatternListState;

cui/source/inc/cuitabline.hxx

@@ -37,8 +37,6 @@ class SvxLineTabDialog final : public SfxTabDialog
     SdrModel*           pDrawModel;
     const SdrObject*    pObj;
 
-    const SfxItemSet&   rOutAttrs;
-
     XColorListRef         pColorList;
     XColorListRef         mpNewColorList;
     XDashListRef          pDashList;

cui/source/tabpages/tabarea.cxx

@@ -59,7 +59,6 @@ SvxAreaTabDialog::SvxAreaTabDialog
     mpNewBitmapList      ( pModel->GetBitmapList() ),
     mpPatternList        ( pModel->GetPatternList() ),
     mpNewPatternList     ( pModel->GetPatternList() ),
-    mrOutAttrs           ( *pAttr ),
 
     mnColorListState ( ChangeType::NONE ),
     mnBitmapListState ( ChangeType::NONE ),
@@ -248,8 +247,6 @@ void SvxAreaTabDialog::PageCreated( sal_uInt16 nId, SfxTabPage &rPage )
             static_cast<SvxAreaTabPage&>(rPage).SetBmpChgd( &mnBitmapListState );
             static_cast<SvxAreaTabPage&>(rPage).SetPtrnChgd( &mnPatternListState );
             static_cast<SvxAreaTabPage&>(rPage).SetColorChgd( &mnColorListState );
-            // ActivatePge() is not called the first time
-            static_cast<SvxAreaTabPage&>(rPage).ActivatePage( mrOutAttrs );
     }
     else if (nId == m_nShadowTabPage)
     {

cui/source/tabpages/tabline.cxx

@@ -49,7 +49,6 @@ SvxLineTabDialog::SvxLineTabDialog
     m_nEndTabPage(0),
     pDrawModel      ( pModel ),
     pObj            ( pSdrObj ),
-    rOutAttrs       ( *pAttr ),
     pColorList      ( pModel->GetColorList() ),
     mpNewColorList  ( pModel->GetColorList() ),
     pDashList       ( pModel->GetDashList() ),
@@ -198,8 +197,6 @@ void SvxLineTabDialog::PageCreated( sal_uInt16 nId, SfxTabPage &rPage )
         static_cast<SvxLineTabPage&>(rPage).SetObjSelected( bObjSelected );
         static_cast<SvxLineTabPage&>(rPage).Construct();
         static_cast<SvxLineTabPage&>(rPage).SetColorChgd( &mnColorListState );
-        // ActivatePage() is not called the first time
-        static_cast<SvxLineTabPage&>(rPage).ActivatePage( rOutAttrs );
     }
     else if(nId == m_nStyleTabPage)
     {