loplugin:passstuffbyref in editeng

Change-Id: I11deb7c73a1c160d587d74c9851ff10c875c972b

editeng/source/editeng/editeng.cxx

@@ -1526,7 +1526,7 @@ void EditEngine::SetImportHdl( const Link<ImportInfo&,void>& rLink )
     pImpEditEngine->aImportHdl = rLink;
 }
 
-Link<ImportInfo&,void> EditEngine::GetImportHdl() const
+const Link<ImportInfo&,void>& EditEngine::GetImportHdl() const
 {
     return pImpEditEngine->aImportHdl;
 }
@@ -2101,7 +2101,7 @@ void EditEngine::SetWordDelimiters( const OUString& rDelimiters )
         pImpEditEngine->aWordDelimiters += OUStringLiteral1<CH_FEATURE>();
 }
 
-OUString EditEngine::GetWordDelimiters() const
+const OUString& EditEngine::GetWordDelimiters() const
 {
     return pImpEditEngine->aWordDelimiters;
 }

editeng/source/editeng/impedit.hxx

@@ -650,7 +650,7 @@ private:
     const ParaPortion*  GetNextVisPortion( const ParaPortion* pCurPortion ) const;
 
     void                SetBackgroundColor( const Color& rColor ) { maBackgroundColor = rColor; }
-    Color               GetBackgroundColor() const { return maBackgroundColor; }
+    const Color&        GetBackgroundColor() const { return maBackgroundColor; }
 
     long                CalcVertLineSpacing(Point& rStartPos) const;
 
@@ -832,7 +832,7 @@ public:
     bool            IsModified() const      { return aEditDoc.IsModified(); }
     void            SetModifyFlag( bool b ) { aEditDoc.SetModified( b ); }
     void            SetModifyHdl( const Link<LinkParamNone*,void>& rLink ) { aModifyHdl = rLink; }
-    Link<LinkParamNone*,void> GetModifyHdl() const { return aModifyHdl; }
+    const Link<LinkParamNone*,void>& GetModifyHdl() const { return aModifyHdl; }
 
     bool            IsInSelectionMode() { return bInSelection; }
 
@@ -848,10 +848,10 @@ public:
     EditSelection*  SelectParagraph( sal_Int32 nPara );
 
     void            SetStatusEventHdl( const Link<EditStatus&, void>& rLink ) { aStatusHdlLink = rLink; }
-    Link<EditStatus&,void> GetStatusEventHdl() const               { return aStatusHdlLink; }
+    const Link<EditStatus&,void>& GetStatusEventHdl() const               { return aStatusHdlLink; }
 
     void            SetNotifyHdl( const Link<EENotify&,void>& rLink )     { aNotifyHdl = rLink; }
-    Link<EENotify&,void>   GetNotifyHdl() const            { return aNotifyHdl; }
+    const Link<EENotify&,void>&   GetNotifyHdl() const            { return aNotifyHdl; }
 
     void            FormatAndUpdate( EditView* pCurView = nullptr );
     inline void     IdleFormatAndUpdate( EditView* pCurView = nullptr );
@@ -902,7 +902,7 @@ public:
                         GetSpeller();
     void                SetSpeller( css::uno::Reference< css::linguistic2::XSpellChecker1 >  &xSpl )
                             { xSpeller = xSpl; }
-    css::uno::Reference< css::linguistic2::XHyphenator >
+    const css::uno::Reference< css::linguistic2::XHyphenator >&
                         GetHyphenator() const { return xHyphenator; }
     void                SetHyphenator( css::uno::Reference< css::linguistic2::XHyphenator >  &xHyph )
                             { xHyphenator = xHyph; }
@@ -1012,11 +1012,11 @@ public:
 
     /** sets a link that is called at the beginning of a drag operation at an edit view */
     void                SetBeginDropHdl( const Link<EditView*,void>& rLink ) { maBeginDropHdl = rLink; }
-    Link<EditView*,void>  GetBeginDropHdl() const { return maBeginDropHdl; }
+    const Link<EditView*,void>&  GetBeginDropHdl() const { return maBeginDropHdl; }
 
     /** sets a link that is called at the end of a drag operation at an edit view */
     void            SetEndDropHdl( const Link<EditView*,void>& rLink ) { maEndDropHdl = rLink; }
-    Link<EditView*,void>  GetEndDropHdl() const { return maEndDropHdl; }
+    const Link<EditView*,void>&  GetEndDropHdl() const { return maEndDropHdl; }
 
     /// specifies if auto-correction should capitalize the first word or not (default is on)
     void            SetFirstWordCapitalization( bool bCapitalize )  { bFirstWordCapitalization = bCapitalize; }

include/editeng/brushitem.hxx

@@ -102,8 +102,8 @@ public:
     sal_Int32               GetShadingValue() const     { return nShadingValue; }
     const Graphic*          GetGraphic(OUString const & referer = OUString()/*TODO*/) const;
     const GraphicObject*    GetGraphicObject(OUString const & referer = OUString()/*TODO*/) const;
-    OUString                GetGraphicLink() const      { return maStrLink; }
-    OUString                GetGraphicFilter() const    { return maStrFilter; }
+    const OUString&         GetGraphicLink() const      { return maStrLink; }
+    const OUString&         GetGraphicFilter() const    { return maStrFilter; }
 
     void                SetShadingValue( const sal_Int32 nNew );
 

include/editeng/bulletitem.hxx

@@ -69,13 +69,13 @@ public:
 
     OUString            GetFullText() const;
     sal_Unicode         GetSymbol() const { return cSymbol; }
-    OUString            GetPrevText() const { return aPrevText; }
-    OUString            GetFollowText() const { return aFollowText; }
+    const OUString&     GetPrevText() const { return aPrevText; }
+    const OUString&     GetFollowText() const { return aFollowText; }
 
     sal_uInt16          GetStart() const { return nStart; }
     long                GetWidth() const { return nWidth; }
     SvxBulletStyle      GetStyle() const { return nStyle; }
-    vcl::Font           GetFont() const { return aFont; }
+    const vcl::Font&    GetFont() const { return aFont; }
     sal_uInt16          GetScale() const { return nScale; }
 
     const GraphicObject& GetGraphicObject() const;

include/editeng/editeng.hxx

@@ -377,7 +377,7 @@ public:
     Link<EENotify&,void>  GetNotifyHdl() const;
 
     void            SetImportHdl( const Link<ImportInfo&,void>& rLink );
-    Link<ImportInfo&,void> GetImportHdl() const;
+    const Link<ImportInfo&,void>& GetImportHdl() const;
 
     // Do not evaluate font formatting => For Outliner
     bool            IsFlatMode() const;
@@ -410,7 +410,7 @@ public:
     SfxStyleSheet* GetStyleSheet( sal_Int32 nPara );
 
     void            SetWordDelimiters( const OUString& rDelimiters );
-    OUString        GetWordDelimiters() const;
+    const OUString& GetWordDelimiters() const;
 
     void            EraseVirtualDevice();
 

include/editeng/flditem.hxx

@@ -320,7 +320,7 @@ public:
                                 SvxFileType eType = SVXFILETYPE_VAR,
                                 SvxFileFormat eFormat = SVXFILEFORMAT_FULLPATH );
 
-    OUString           GetFile() const { return aFile; }
+    const OUString&         GetFile() const { return aFile; }
     void                    SetFile( const OUString& rString ) { aFile = rString; }
 
     SvxFileType             GetType() const { return eType; }

include/editeng/numitem.hxx

@@ -173,7 +173,7 @@ public:
     void            SetBulletRelSize(sal_uInt16 nSet) {nBulletRelSize = nSet;}
     sal_uInt16          GetBulletRelSize() const { return nBulletRelSize;}
     void            SetBulletColor(Color nSet){nBulletColor = nSet;}
-    Color           GetBulletColor()const {return nBulletColor;}
+    const Color&    GetBulletColor()const {return nBulletColor;}
 
     void            SetIncludeUpperLevels( sal_uInt8 nSet ) { nInclUpperLevels = nSet;}
     sal_uInt8           GetIncludeUpperLevels()const  { return nInclUpperLevels;}

include/editeng/optitems.hxx

@@ -49,7 +49,7 @@ public:
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
     virtual bool            operator==( const SfxPoolItem& ) const override;
 
-    css::uno::Reference< css::linguistic2::XSpellChecker1 >
+    const css::uno::Reference< css::linguistic2::XSpellChecker1 >&
             GetXSpellChecker() const { return xSpellCheck; }
 
 private:

include/editeng/outliner.hxx

@@ -750,11 +750,11 @@ public:
 
     void            ParagraphInsertedHdl();
     void            SetParaInsertedHdl(const Link<Outliner*,void>& rLink){aParaInsertedHdl=rLink;}
-    Link<Outliner*,void> GetParaInsertedHdl() const { return aParaInsertedHdl; }
+    const Link<Outliner*,void>& GetParaInsertedHdl() const { return aParaInsertedHdl; }
 
     void            ParagraphRemovingHdl();
     void            SetParaRemovingHdl(const Link<Outliner*,void>& rLink){aParaRemovingHdl=rLink;}
-    Link<Outliner*,void> GetParaRemovingHdl() const { return aParaRemovingHdl; }
+    const Link<Outliner*,void>& GetParaRemovingHdl() const { return aParaRemovingHdl; }
 
     NonOverflowingText *GetNonOverflowingText() const;
     OverflowingText *GetOverflowingText() const;
@@ -766,7 +766,7 @@ public:
 
     void            DepthChangedHdl();
     void            SetDepthChangedHdl(const Link<Outliner*,void>& rLink){aDepthChangedHdl=rLink;}
-    Link<Outliner*,void> GetDepthChangedHdl() const { return aDepthChangedHdl; }
+    const Link<Outliner*,void>& GetDepthChangedHdl() const { return aDepthChangedHdl; }
     sal_Int16       GetPrevDepth() const { return static_cast<sal_Int16>(nDepthChangedHdlPrevDepth); }
     ParaFlag        GetPrevFlags() const { return mnDepthChangeHdlPrevFlags; }
 
@@ -778,7 +778,7 @@ public:
     sal_Int32       GetSelPageCount() const { return nDepthChangedHdlPrevDepth; }
 
     void            SetCalcFieldValueHdl(const Link<EditFieldInfo*,void>& rLink ) { aCalcFieldValueHdl= rLink; }
-    Link<EditFieldInfo*,void> GetCalcFieldValueHdl() const { return aCalcFieldValueHdl; }
+    const Link<EditFieldInfo*,void>& GetCalcFieldValueHdl() const { return aCalcFieldValueHdl; }
 
     void            SetDrawPortionHdl(const Link<DrawPortionInfo*,void>& rLink){aDrawPortionHdl=rLink;}
 
@@ -875,9 +875,9 @@ public:
     void            SetControlWord( EEControlBits nWord );
     EEControlBits   GetControlWord() const;
 
-    Link<Outliner*,void> GetBeginMovingHdl() const { return aBeginMovingHdl; }
+    const Link<Outliner*,void>& GetBeginMovingHdl() const { return aBeginMovingHdl; }
     void            SetBeginMovingHdl(const Link<Outliner*,void>& rLink) {aBeginMovingHdl=rLink;}
-    Link<Outliner*,void> GetEndMovingHdl() const {return aEndMovingHdl;}
+    const Link<Outliner*,void>& GetEndMovingHdl() const {return aEndMovingHdl;}
     void            SetEndMovingHdl( const Link<Outliner*,void>& rLink){aEndMovingHdl=rLink;}
 
     sal_uLong           GetLineCount( sal_Int32 nParagraph ) const;

include/editeng/splwrap.hxx

@@ -98,7 +98,7 @@ public:
     inline bool     IsAllRight()        { return bAllRight; }
 
 protected:
-    css::uno::Reference< css::uno::XInterface >
+    const css::uno::Reference< css::uno::XInterface >&
                      GetLast()      { return xLast; }
     void             SetLast(const css::uno::Reference< css::uno::XInterface >  &xNewLast)
                             { xLast = xNewLast; }