clang-tidy performance-unnecessary-value-param in starmath

Change-Id: Ic8d319dac1d18f548d47ac84e489c04412a38d1a

starmath/inc/document.hxx

@@ -141,7 +141,7 @@ class SM_DLLPUBLIC SmDocShell : public SfxObjectShell, public SfxListener
      */
     void                InvalidateCursor();
 
-    bool writeFormulaOoxml(::sax_fastparser::FSHelperPtr pSerializer,
+    bool writeFormulaOoxml(const ::sax_fastparser::FSHelperPtr& pSerializer,
             oox::core::OoxmlVersion version,
             oox::drawingml::DocumentType documentType);
     void writeFormulaRtf(OStringBuffer& rBuffer, rtl_TextEncoding nEncoding);

starmath/source/document.cxx

@@ -888,7 +888,7 @@ bool SmDocShell::ConvertTo( SfxMedium &rMedium )
 }
 
 bool SmDocShell::writeFormulaOoxml(
-        ::sax_fastparser::FSHelperPtr const pSerializer,
+        ::sax_fastparser::FSHelperPtr const& pSerializer,
         oox::core::OoxmlVersion const version,
         oox::drawingml::DocumentType const documentType)
 {

starmath/source/mathmlexport.cxx

@@ -251,8 +251,8 @@ bool SmXMLExportWrapper::Export(SfxMedium &rMedium)
 
 /// export through an XML exporter component (output stream version)
 bool SmXMLExportWrapper::WriteThroughComponent(
-    Reference<io::XOutputStream> xOutputStream,
-    Reference<XComponent> xComponent,
+    const Reference<io::XOutputStream>& xOutputStream,
+    const Reference<XComponent>& xComponent,
     Reference<uno::XComponentContext> & rxContext,
     Reference<beans::XPropertySet> & rPropSet,
     const sal_Char* pComponentName )
@@ -303,7 +303,7 @@ bool SmXMLExportWrapper::WriteThroughComponent(
 /// export through an XML exporter component (storage version)
 bool SmXMLExportWrapper::WriteThroughComponent(
     const Reference < embed::XStorage >& xStorage,
-    Reference<XComponent> xComponent,
+    const Reference<XComponent>& xComponent,
     const sal_Char* pStreamName,
     Reference<uno::XComponentContext> & rxContext,
     Reference<beans::XPropertySet> & rPropSet,

starmath/source/mathmlexport.hxx

@@ -49,15 +49,15 @@ public:
     void SetFlat(bool bIn) {bFlat = bIn;}
 
     static bool WriteThroughComponent(
-        css::uno::Reference< css::io::XOutputStream >   xOutputStream,
-        css::uno::Reference< css::lang::XComponent >    xComponent,
+        const css::uno::Reference< css::io::XOutputStream >&   xOutputStream,
+        const css::uno::Reference< css::lang::XComponent >&    xComponent,
         css::uno::Reference< css::uno::XComponentContext > & rxContext,
         css::uno::Reference< css::beans::XPropertySet > & rPropSet,
         const sal_Char* pComponentName );
 
     static bool WriteThroughComponent(
         const css::uno::Reference< css::embed::XStorage >& xStor,
-        css::uno::Reference< css::lang::XComponent > xComponent,
+        const css::uno::Reference< css::lang::XComponent >& xComponent,
         const sal_Char* pStreamName,
         css::uno::Reference< css::uno::XComponentContext > & rxContext,
         css::uno::Reference< css::beans::XPropertySet > & rPropSet,

starmath/source/mathmlimport.cxx

@@ -237,8 +237,8 @@ sal_uLong SmXMLImportWrapper::Import(SfxMedium &rMedium)
 
 /// read a component (file + filter version)
 sal_uLong SmXMLImportWrapper::ReadThroughComponent(
-    Reference<io::XInputStream> xInputStream,
-    Reference<XComponent> xModelComponent,
+    const Reference<io::XInputStream>& xInputStream,
+    const Reference<XComponent>& xModelComponent,
     Reference<uno::XComponentContext> & rxContext,
     Reference<beans::XPropertySet> & rPropSet,
     const sal_Char* pFilterName,
@@ -334,7 +334,7 @@ sal_uLong SmXMLImportWrapper::ReadThroughComponent(
 
 sal_uLong SmXMLImportWrapper::ReadThroughComponent(
     const uno::Reference< embed::XStorage >& xStorage,
-    Reference<XComponent> xModelComponent,
+    const Reference<XComponent>& xModelComponent,
     const sal_Char* pStreamName,
     const sal_Char* pCompatibilityStreamName,
     Reference<uno::XComponentContext> & rxContext,

starmath/source/mathmlimport.hxx

@@ -48,8 +48,8 @@ public:
     sal_uLong Import(SfxMedium &rMedium);
 
     static sal_uLong ReadThroughComponent(
-        css::uno::Reference< css::io::XInputStream > xInputStream,
-        css::uno::Reference< css::lang::XComponent > xModelComponent,
+        const css::uno::Reference< css::io::XInputStream >& xInputStream,
+        const css::uno::Reference< css::lang::XComponent >& xModelComponent,
         css::uno::Reference< css::uno::XComponentContext > & rxContext,
         css::uno::Reference< css::beans::XPropertySet > & rPropSet,
         const sal_Char* pFilterName,
@@ -57,7 +57,7 @@ public:
 
     static sal_uLong ReadThroughComponent(
         const css::uno::Reference< css::embed::XStorage >& xStorage,
-        css::uno::Reference< css::lang::XComponent > xModelComponent,
+        const css::uno::Reference< css::lang::XComponent >& xModelComponent,
         const sal_Char* pStreamName,
         const sal_Char* pCompatibilityStreamName,
         css::uno::Reference< css::uno::XComponentContext > & rxContext,

starmath/source/ooxmlexport.cxx

@@ -24,7 +24,7 @@ SmOoxmlExport::SmOoxmlExport(const SmNode *const pIn, OoxmlVersion const v,
 {
 }
 
-bool SmOoxmlExport::ConvertFromStarMath( ::sax_fastparser::FSHelperPtr serializer )
+bool SmOoxmlExport::ConvertFromStarMath( const ::sax_fastparser::FSHelperPtr& serializer )
 {
     if( m_pTree == nullptr )
         return false;

starmath/source/ooxmlexport.hxx

@@ -24,7 +24,7 @@ class SmOoxmlExport : public SmWordExportBase
 public:
     SmOoxmlExport(const SmNode* pIn, oox::core::OoxmlVersion version,
             oox::drawingml::DocumentType documentType);
-    bool ConvertFromStarMath( ::sax_fastparser::FSHelperPtr m_pSerializer );
+    bool ConvertFromStarMath( const ::sax_fastparser::FSHelperPtr& m_pSerializer );
 private:
     virtual void HandleVerticalStack( const SmNode* pNode, int nLevel ) override;
     virtual void HandleText( const SmNode* pNode, int nLevel ) override;