loplugin:unnecessaryvirtual

Change-Id: I3fe82f6e3aad299fe42d6256c0deaba1339df0c1
Reviewed-on: https://gerrit.libreoffice.org/58708
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

compilerplugins/clang/unnecessaryvirtual-dead.results

@@ -8,18 +8,14 @@ include/canvas/base/graphicdevicebase.hxx:302
     void canvas::GraphicDeviceBase::removePropertyChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XPropertyChangeListener> &,)
 include/canvas/base/graphicdevicebase.hxx:315
     void canvas::GraphicDeviceBase::removeVetoableChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XVetoableChangeListener> &,)
-include/svtools/valueset.hxx:498
-    void SvtValueSet::UserDraw(const class UserDrawEvent &,)
-slideshow/source/engine/animationfactory.cxx:442
+slideshow/source/engine/animationfactory.cxx:443
     void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch(const class std::shared_ptr<class slideshow::internal::AnimatableShape> &,const class std::shared_ptr<class slideshow::internal::ShapeAttributeLayer> &,)
 vcl/inc/salframe.hxx:135
     void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
 vcl/inc/salmenu.hxx:80
     void SalMenu::RemoveMenuBarButton(unsigned short,)
-vcl/inc/salobj.hxx:46
+vcl/inc/salobj.hxx:48
     void SalObject::Enable(_Bool,)
-vcl/inc/unx/saldata.hxx:68
-    void X11SalData::initNWF()
 vcl/inc/unx/saldata.hxx:69
     void X11SalData::deInitNWF()
 writerfilter/source/ooxml/OOXMLFactory.hxx:71
@@ -29,4 +25,4 @@ writerfilter/source/ooxml/OOXMLFactory.hxx:72
 writerfilter/source/ooxml/OOXMLFactory.hxx:73
     void writerfilter::ooxml::OOXMLFactory_ns::endAction(class writerfilter::ooxml::OOXMLFastContextHandler *,)
 writerfilter/source/ooxml/OOXMLFactory.hxx:74
-    void writerfilter::ooxml::OOXMLFactory_ns::attributeAction(class writerfilter::ooxml::OOXMLFastContextHandler *,int,const class std::shared_ptr<class writerfilter::ooxml::OOXMLValue> &,)
+    void writerfilter::ooxml::OOXMLFactory_ns::attributeAction(class writerfilter::ooxml::OOXMLFastContextHandler *,int,const class tools::SvRef<class writerfilter::ooxml::OOXMLValue> &,)

include/svl/undo.hxx

@@ -199,16 +199,16 @@ public:
                             SfxUndoManager( size_t nMaxUndoActionCount = 20 );
     virtual                 ~SfxUndoManager();
 
-    virtual void            SetMaxUndoActionCount( size_t nMaxUndoActionCount );
+    void                    SetMaxUndoActionCount( size_t nMaxUndoActionCount );
     virtual void            AddUndoAction( SfxUndoAction *pAction, bool bTryMerg=false );
     virtual size_t          GetUndoActionCount( bool const i_currentLevel = CurrentLevel ) const;
-    virtual OUString        GetUndoActionComment( size_t nNo=0, bool const i_currentLevel = CurrentLevel ) const;
-    virtual SfxUndoAction*  GetUndoAction( size_t nNo=0 ) const;
+    OUString                GetUndoActionComment( size_t nNo=0, bool const i_currentLevel = CurrentLevel ) const;
+    SfxUndoAction*          GetUndoAction( size_t nNo=0 ) const;
     /// Get info about all undo actions (comment, view shell id, etc.)
     OUString                GetUndoActionsInfo() const;
     virtual size_t          GetRedoActionCount( bool const i_currentLevel = CurrentLevel ) const;
-    virtual OUString        GetRedoActionComment( size_t nNo=0, bool const i_currentLevel = CurrentLevel ) const;
-    virtual SfxUndoAction*  GetRedoAction() const;
+    OUString                GetRedoActionComment( size_t nNo=0, bool const i_currentLevel = CurrentLevel ) const;
+    SfxUndoAction*          GetRedoAction() const;
     /// Get info about all redo actions (comment, view shell id, etc.)
     OUString                GetRedoActionsInfo() const;
     virtual bool            Undo();
@@ -228,20 +228,20 @@ public:
         followed by <code>Clear()</code>. The only difference to this calling sequence is that Reset is an
         atomic operation, also resulting in only one notification.
     */
-    virtual void            Reset();
+    void                    Reset();
     /** determines whether an Undo or Redo is currently running
     */
-    virtual bool            IsDoing() const;
-    virtual size_t          GetRepeatActionCount() const;
-    virtual OUString        GetRepeatActionComment( SfxRepeatTarget &rTarget) const;
-    virtual bool            Repeat( SfxRepeatTarget &rTarget );
-    virtual bool            CanRepeat( SfxRepeatTarget &rTarget ) const;
+    bool                    IsDoing() const;
+    size_t                  GetRepeatActionCount() const;
+    OUString                GetRepeatActionComment( SfxRepeatTarget &rTarget) const;
+    bool                    Repeat( SfxRepeatTarget &rTarget );
+    bool                    CanRepeat( SfxRepeatTarget &rTarget ) const;
     virtual void            EnterListAction(const OUString &rComment, const OUString& rRepeatComment, sal_uInt16 nId, ViewShellId nViewShellId);
     /** Leaves the list action entered with EnterListAction
         @return the number of the sub actions in the list which has just been left. Note that in case no such
             actions exist, the list action does not contribute to the Undo stack, but is silently removed.
     */
-    virtual size_t          LeaveListAction();
+    size_t                  LeaveListAction();
 
     /** Leaves the list action entered with EnterListAction, and forcefully merges the previous
         action on the stack into the newly created list action.
@@ -258,13 +258,13 @@ public:
         @return the number of the sub actions in the list which has just been left. Note that in case no such
             actions exist, the list action does not contribute to the Undo stack, but is silently removed.
     */
-    virtual size_t          LeaveAndMergeListAction();
+    size_t                  LeaveAndMergeListAction();
     /// determines whether we're within a ListAction context, i.e. a LeaveListAction/LeaveAndMergeListAction call is pending
-    virtual bool            IsInListAction() const;
+    bool                    IsInListAction() const;
     /// Determines how many nested list actions are currently open
-    virtual size_t          GetListActionDepth() const;
+    size_t                  GetListActionDepth() const;
     /** Clears the redo stack and removes the top undo action */
-    virtual void            RemoveLastUndoAction();
+    void                    RemoveLastUndoAction();
     /** enables (true) or disables (false) recording of undo actions
 
         If undo actions are added while undo is disabled, they are deleted.
@@ -273,15 +273,15 @@ public:
         Multiple calls to <code>EnableUndo</code> are not cumulative. That is, calling <code>EnableUndo( false )</code>
         twice, and then calling <code>EnableUndo( true )</code> means that Undo is enable afterwards.
     */
-    virtual void            EnableUndo( bool bEnable );
+    void                    EnableUndo( bool bEnable );
     /// returns true if undo is currently enabled.
     /// This returns false if undo was disabled using EnableUndo( false ) and
     /// also during the runtime of the Undo() and Redo() methods.
-    virtual bool            IsUndoEnabled() const;
+    bool                    IsUndoEnabled() const;
     /// Adds a new listener to be notified about changes in the UndoManager's state
-    virtual void            AddUndoListener( SfxUndoListener& i_listener );
-    virtual void            RemoveUndoListener( SfxUndoListener& i_listener );
-    virtual bool            IsEmptyActions() const;
+    void                    AddUndoListener( SfxUndoListener& i_listener );
+    void                    RemoveUndoListener( SfxUndoListener& i_listener );
+    bool                    IsEmptyActions() const;
 
 
     /** marks the current top-level element of the Undo stack, and returns a unique ID for it

include/svtools/treelistbox.hxx

@@ -715,7 +715,7 @@ public:
     virtual bool    Collapse( SvTreeListEntry* pParent );
     virtual bool    Select( SvTreeListEntry* pEntry, bool bSelect=true );
     sal_uLong       SelectChildren( SvTreeListEntry* pParent, bool bSelect );
-    virtual void    SelectAll( bool bSelect, bool bPaint = true );
+    void            SelectAll( bool bSelect, bool bPaint = true );
 
     void SetCurEntry( SvTreeListEntry* _pEntry );
     SvTreeListEntry* GetCurEntry() const;

sc/source/ui/inc/StatisticsTwoVariableDialog.hxx

@@ -44,7 +44,7 @@ protected:
     virtual ScRange ApplyOutput(ScDocShell* pDocShell) = 0;
     virtual const char* GetUndoNameId() = 0;
     virtual bool InputRangesValid();
-    virtual void ValidateDialogInput();
+    void ValidateDialogInput();
 
     // Widgets
     VclPtr<FixedText>          mpVariable1RangeLabel;

sd/source/ui/framework/module/SlideSorterModule.hxx

@@ -60,7 +60,7 @@ public:
     */
     void AddActiveMainView (const OUString& rsMainViewURL);
     bool IsResourceActive (const OUString& rsMainViewURL);
-    virtual void SaveResourceState();
+    void SaveResourceState();
 
     virtual void SAL_CALL disposing() override;