some OSL_FAIL to SAL_WARN

Change-Id: I5101e42b7a34cca9055fc805d9a392ba4f920a3d

slideshow/source/engine/activitiesqueue.cxx

@@ -55,12 +55,9 @@ namespace slideshow
                 for( const auto& pActivity : maCurrentActivitiesReinsert )
                     pActivity->dispose();
             }
-            catch (uno::Exception &)
+            catch (const uno::Exception&)
             {
-                OSL_FAIL( OUStringToOString(
-                                comphelper::anyToString(
-                                    cppu::getCaughtException() ),
-                                RTL_TEXTENCODING_UTF8 ).getStr() );
+                SAL_WARN( "slideshow", "" << comphelper::anyToString(cppu::getCaughtException() ) );
             }
         }
 

slideshow/source/engine/eventqueue.cxx

@@ -73,12 +73,9 @@ namespace slideshow
                 {
                     maEvents.top().pEvent->dispose();
                 }
-                catch (uno::Exception &)
+                catch (const uno::Exception&)
                 {
-                    OSL_FAIL( OUStringToOString(
-                                    comphelper::anyToString(
-                                        cppu::getCaughtException() ),
-                                    RTL_TEXTENCODING_UTF8 ).getStr() );
+                    SAL_WARN( "slideshow", "" << comphelper::anyToString(cppu::getCaughtException() ) );
                 }
                 maEvents.pop();
             }

slideshow/source/engine/rehearsetimingsactivity.cxx

@@ -179,12 +179,9 @@ RehearseTimingsActivity::~RehearseTimingsActivity()
     {
         stop();
     }
-    catch (uno::Exception &)
+    catch (const uno::Exception&)
     {
-        OSL_FAIL( OUStringToOString(
-                        comphelper::anyToString(
-                            cppu::getCaughtException() ),
-                        RTL_TEXTENCODING_UTF8 ).getStr() );
+        SAL_WARN( "slideshow", "" << comphelper::anyToString(cppu::getCaughtException() ) );
     }
 }
 

slideshow/source/engine/shapesubset.cxx

@@ -79,12 +79,9 @@ namespace slideshow
                 // if not done yet: revoke subset from original
                 disableSubsetShape();
             }
-            catch (uno::Exception &)
+            catch (const uno::Exception&)
             {
-                OSL_FAIL( OUStringToOString(
-                                comphelper::anyToString(
-                                    cppu::getCaughtException() ),
-                                RTL_TEXTENCODING_UTF8 ).getStr() );
+                SAL_WARN( "slideshow", "" << comphelper::anyToString(cppu::getCaughtException() ) );
             }
         }
 

slideshow/source/engine/slide/userpaintoverlay.cxx

@@ -487,12 +487,9 @@ namespace slideshow
                 mrMultiplexer.removeViewHandler( mpHandler );
                 mpHandler->dispose();
             }
-            catch (uno::Exception &)
+            catch (const uno::Exception&)
             {
-                OSL_FAIL( OUStringToOString(
-                                comphelper::anyToString(
-                                    cppu::getCaughtException() ),
-                                RTL_TEXTENCODING_UTF8 ).getStr() );
+                SAL_WARN( "slideshow", "" << comphelper::anyToString(cppu::getCaughtException() ) );
             }
         }
     }

slideshow/source/engine/transitions/shapetransitionfactory.cxx

@@ -110,12 +110,9 @@ ClippingAnimation::~ClippingAnimation()
     {
         end_();
     }
-    catch (uno::Exception &)
+    catch (const uno::Exception&)
     {
-        OSL_FAIL( OUStringToOString(
-                        comphelper::anyToString(
-                            cppu::getCaughtException() ),
-                        RTL_TEXTENCODING_UTF8 ).getStr() );
+        SAL_WARN( "slideshow", "" << comphelper::anyToString(cppu::getCaughtException() ) );
     }
 }
 
@@ -354,9 +351,6 @@ AnimationActivitySharedPtr createShapeTransitionByType(
         SAL_WARN("slideshow",
             "createShapeTransitionByType(): Unknown type/subtype combination encountered: "
             << xTransition->getTransition() << " " << xTransition->getSubtype() );
-        OSL_FAIL(
-            "createShapeTransitionByType(): Unknown type/subtype "
-            "combination encountered" );
     }
 
     return pGeneratedActivity;

slideshow/source/engine/usereventqueue.cxx

@@ -558,11 +558,9 @@ UserEventQueue::~UserEventQueue()
         // unregister all handlers
         clear();
     }
-    catch (uno::Exception &) {
-        OSL_FAIL( OUStringToOString(
-                        comphelper::anyToString(
-                            cppu::getCaughtException() ),
-                        RTL_TEXTENCODING_UTF8 ).getStr() );
+    catch (const uno::Exception&)
+    {
+        SAL_WARN( "slideshow", "" << comphelper::anyToString(cppu::getCaughtException() ) );
     }
 }
 

svx/source/svdraw/svdoole2.cxx

@@ -945,14 +945,11 @@ void SdrOle2Obj::CheckFileLink_Impl()
                 }
             }
         }
-        catch( css::uno::Exception& )
+        catch (const css::uno::Exception&)
         {
-            OSL_FAIL(
-                OString(OString("SdrOle2Obj::CheckFileLink_Impl(), "
-                        "exception caught: ") +
-                OUStringToOString(
-                    comphelper::anyToString( cppu::getCaughtException() ),
-                    RTL_TEXTENCODING_UTF8 )).getStr() );
+            SAL_WARN( "svx", "SdrOle2Obj::CheckFileLink_Impl(),"
+                        "exception caught: "
+                 << comphelper::anyToString(cppu::getCaughtException() ) );
         }
     }
 }