• Tor Lillqvist's avatar
    Bin a line of apparently meaningless and wrong Mac OS X code · fbd82ae8
    Tor Lillqvist yazdı
    When LibreOffice is compiled against the 10.6 SDK and run under gdb,
    the apple_remote code caused "cannot init a class object" exception
    messages to be printed.
    
    Upon closer inspection this was caused by the call to [super init] in
    the sendDistributedNotification class method of the RemoteControl
    class.
    
    As far as I understand, calling [super init] and assigning its return
    value to self, even, is pointless and wrong in a class method.
    
    This code apparently has not been causing any harm when built against
    the 10.4 SDK. This is probably just accidental thanks to a more
    lenient Objective-C runtime getting used?
    
    When built against the 10.6 SDK, though, the resulting Objective-C
    exception seemed to make input event handling non-functional. After
    this fix LibreOffice built this way works better.
    
    Change-Id: I I I383611753f3f83a9efa4694b1900c8b66ed1a8e3
    fbd82ae8
RemoteControl.m 5.6 KB