-
Michael Stahl yazdı
SwUndoTOXChange was effectively dead code since commit 60732d71 "#i42807# clear undo stack before changing of TOX properties, update TOX after changing properties" and was resurrected by commit 4f0b568e. * Calling Update() from Undo is wrong, as there is no guarantee that the index was up-to-date before the change * Calling Update() from Redo is pointless, as there will be a Redo of SwUndoUpdateIndex anyway, given that the only caller of ChangeTOX, namely, SwTOXMgr::UpdateOrInsertTOX(), does that * SwUndoTOXChange cannot retain a pointer to SwTOXBase as its life-time is tied to the SwSectionNode * Repeat applying the same attributes to the same ToX is utterly pointless Change-Id: I84a9de3176d1062d1a43acbc9270c547fde7936a Reviewed-on: https://gerrit.libreoffice.org/72118 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
eb8e0300