Verified Kaydet (Commit) 6a5b5fab authored tarafından Erdem Ersoy's avatar Erdem Ersoy

Some changes:

- Fix "Uninstall" menu item function
- Simplify some "Install" menu item function code
üst eb1bbca8
...@@ -38,7 +38,7 @@ gettext.install("flatpak-gui", "po/") ...@@ -38,7 +38,7 @@ gettext.install("flatpak-gui", "po/")
class InstallWindow(object): class InstallWindow(object):
def __init__(self, application, apptoinstrealname, apptoinstarch, def __init__(self, application, apptoinstrealname, apptoinstarch,
apptoinstbranch, apptoinstremote, flatpakinstallation, apptoinstbranch, apptoinstremote, flatpakinstallation,
liststore, treeviewmain, runmenuitem, installmenuitem, treeview, runmenuitem, installmenuitem,
uninstallmenuitem): uninstallmenuitem):
self.Application = application self.Application = application
...@@ -68,8 +68,7 @@ class InstallWindow(object): ...@@ -68,8 +68,7 @@ class InstallWindow(object):
self.AppToInstall.format_ref(), self.AppToInstall.format_ref(),
None) None)
self.ListStoreMain = liststore self.TreeViewMain = treeview
self.TreeViewMain = treeviewmain
self.Selection = self.TreeViewMain.get_selection() self.Selection = self.TreeViewMain.get_selection()
self.TreeModel, self.TreeIter = self.Selection.get_selected() self.TreeModel, self.TreeIter = self.Selection.get_selected()
...@@ -165,14 +164,8 @@ class InstallWindow(object): ...@@ -165,14 +164,8 @@ class InstallWindow(object):
listitem.get_arch() == Flatpak.get_default_arch() and \ listitem.get_arch() == Flatpak.get_default_arch() and \
listitem.get_branch() == self.AppToInstallBranch and \ listitem.get_branch() == self.AppToInstallBranch and \
listitem.get_name() == self.AppToInstallRealName: listitem.get_name() == self.AppToInstallRealName:
if listitem in flathubrefslist: if listitem not in flathubrefslist:
RemoteName = "flathub" RemoteName = "flathub"
DownloadSize = listitem.get_download_size()
DownloadSizeMiB = DownloadSize / 1048576
DownloadSizeMiBAsString = f"{DownloadSizeMiB:.2f}" + " MiB"
Name = ""
else:
RemoteName = ""
DownloadSizeMiBAsString = "" DownloadSizeMiBAsString = ""
Name = listitem.get_appdata_name() Name = listitem.get_appdata_name()
......
...@@ -482,7 +482,9 @@ class MainWindow(object): ...@@ -482,7 +482,9 @@ class MainWindow(object):
UninstallWindow(self.Application, AppToUninstallRealName, UninstallWindow(self.Application, AppToUninstallRealName,
AppToUninstallArch, AppToUninstallBranch, AppToUninstallArch, AppToUninstallBranch,
self.FlatpakInstallation, self.ListStoreMain) self.FlatpakInstallation, self.TreeViewMain,
self.RunMenuItem, self.InstallMenuItem,
self.UninstallMenuItem)
def onInstall(self, menuitem): def onInstall(self, menuitem):
Selection = self.TreeViewMain.get_selection() Selection = self.TreeViewMain.get_selection()
...@@ -511,8 +513,8 @@ class MainWindow(object): ...@@ -511,8 +513,8 @@ class MainWindow(object):
InstallWindow(self.Application, AppToInstallRealName, InstallWindow(self.Application, AppToInstallRealName,
AppToInstallArch, AppToInstallBranch, AppToInstallArch, AppToInstallBranch,
AppToInstallRemote, self.FlatpakInstallation, AppToInstallRemote, self.FlatpakInstallation,
self.ListStoreMain, self.TreeViewMain, self.TreeViewMain, self.RunMenuItem,
self.RunMenuItem, self.InstallMenuItem, self.UninstallMenuItem) self.InstallMenuItem, self.UninstallMenuItem)
def onInstallFromEntry(self, menuitem): def onInstallFromEntry(self, menuitem):
InstallFromEntryWindow(self.Application, self.FlatpakInstallation, InstallFromEntryWindow(self.Application, self.FlatpakInstallation,
......
...@@ -36,7 +36,8 @@ gettext.install("pardus-flatpak-gui", "po/") ...@@ -36,7 +36,8 @@ gettext.install("pardus-flatpak-gui", "po/")
class UninstallWindow(object): class UninstallWindow(object):
def __init__(self, application, realname, arch, branch, def __init__(self, application, realname, arch, branch,
flatpakinstallation, liststore): flatpakinstallation, treeview, runmenuitem,
installmenuitem, uninstallmenuitem):
self.Application = application self.Application = application
self.AppToUninstallRealName = realname self.AppToUninstallRealName = realname
...@@ -59,7 +60,16 @@ class UninstallWindow(object): ...@@ -59,7 +60,16 @@ class UninstallWindow(object):
"app/" + self.AppToUninstallRealName + "/" + "app/" + self.AppToUninstallRealName + "/" +
self.AppToUninstallArch + "/" + self.AppToUninstallBranch) self.AppToUninstallArch + "/" + self.AppToUninstallBranch)
self.ListStoreMain = liststore self.TreeViewMain = treeview
self.Selection = self.TreeViewMain.get_selection()
self.TreeModel, self.TreeIter = self.Selection.get_selected()
self.TreePath = self.TreeModel.get_path(self.TreeIter)
self.SelectedRowIndex = self.TreePath.get_indices()[0]
self.RunMenuItem = runmenuitem
self.InstallMenuItem = installmenuitem
self.UninstallMenuItem = uninstallmenuitem
try: try:
UninstallGUIFile = "ui/actionwindow.glade" UninstallGUIFile = "ui/actionwindow.glade"
...@@ -129,15 +139,11 @@ class UninstallWindow(object): ...@@ -129,15 +139,11 @@ class UninstallWindow(object):
self.FlatpakTransaction.disconnect(self.handler_id_error) self.FlatpakTransaction.disconnect(self.handler_id_error)
time.sleep(0.5) time.sleep(0.5)
GLib.idle_add(self.ListStoreMain.clear,
data=None,
priority=GLib.PRIORITY_DEFAULT)
flatpakrefslist = \ flatpakrefslist = \
self.FlatpakInstallation.list_installed_refs() self.FlatpakInstallation.list_installed_refs()
flathubrefslist = \ flathubrefslist = \
self.FlatpakInstallation.list_remote_refs_sync( self.FlatpakInstallation.list_remote_refs_sync(
"flathub", Gio.Cancellable.new()) "flathub", Gio.Cancellable.new())
for item in flatpakrefslist: for item in flatpakrefslist:
for item2 in flathubrefslist: for item2 in flathubrefslist:
...@@ -147,30 +153,38 @@ class UninstallWindow(object): ...@@ -147,30 +153,38 @@ class UninstallWindow(object):
for listitem in flatpakrefslist: for listitem in flatpakrefslist:
if listitem.get_kind() == Flatpak.RefKind.APP and \ if listitem.get_kind() == Flatpak.RefKind.APP and \
listitem.get_arch() == Flatpak.get_default_arch(): listitem.get_arch() == Flatpak.get_default_arch() and \
listitem.get_branch() == self.AppToUninstallBranch and \
listitem.get_name() == self.AppToUninstallRealName:
if listitem in flathubrefslist: if listitem in flathubrefslist:
RemoteName = "flathub" RemoteName = "flathub"
DownloadSize = listitem.get_download_size() DownloadSize = listitem.get_download_size()
DownloadSizeMiB = DownloadSize / 1048576 DownloadSizeMiB = DownloadSize / 1048576
DownloadSizeMiBAsString = f"{DownloadSizeMiB:.2f}" + " MiB" DownloadSizeMiBAsString = f"{DownloadSizeMiB:.2f}" + " MiB"
Name = "" Name = ""
else:
RemoteName = ""
DownloadSizeMiBAsString = ""
Name = listitem.get_appdata_name()
InstalledSize = listitem.get_installed_size() InstalledSize = listitem.get_installed_size()
InstalledSizeMiB = InstalledSize / 1048576 InstalledSizeMiB = InstalledSize / 1048576
InstalledSizeMiBAsString = \ InstalledSizeMiBAsString = \
f"{InstalledSizeMiB:.2f}" + " MiB" f"{InstalledSizeMiB:.2f}" + " MiB"
self.ListStoreMain.append([listitem.get_name(), self.TreeModel.set_row(self.TreeIter, [listitem.get_name(),
listitem.get_arch(), listitem.get_arch(),
listitem.get_branch(), listitem.get_branch(),
RemoteName, RemoteName,
InstalledSizeMiBAsString, InstalledSizeMiBAsString,
DownloadSizeMiBAsString, DownloadSizeMiBAsString,
Name]) Name])
self.RunMenuItem.set_sensitive(False)
self.UninstallMenuItem.set_sensitive(False)
self.InstallMenuItem.set_sensitive(True)
GLib.idle_add(self.TreeModel.refilter,
data=None,
priority=GLib.PRIORITY_DEFAULT)
time.sleep(0.25)
break
else: else:
continue continue
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment