• Mike Kaganski's avatar
    tdf#120703 PVS: V547 Fix activation of launched process' window · de26ed22
    Mike Kaganski yazdı
    V547 Expression 'procHandle != nullptr' is always false.
    
    The code was nonsensical overall. First, the launched process handle
    was never returned by ShellExecuteExW, because SEE_MASK_NOCLOSEPROCESS
    wasn't used, so GetProcessId couldn't succeed. Then, nullptr window
    handle was passed to GetWindowThreadProcessId, thus never returning a
    meaningful result.
    
    This reimplements this to find the launched process' main window by
    first waiting for process idle (up to 1-second delay is possible),
    then enumerating all the top-level windows and checking their process.
    
    Change-Id: I5fb4c04147b3f9414e27650a023f7844523c18bd
    Reviewed-on: https://gerrit.libreoffice.org/62478
    Tested-by: Jenkins
    Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
    de26ed22
Adı
Son kayıt (commit)
Son güncelleme
..
inc Loading commit data...
qa/zip Loading commit data...
source Loading commit data...
CppunitTest_shell_zip.mk Loading commit data...
CustomTarget_shlxthdl_res.mk Loading commit data...
CustomTarget_spsupp_idl.mk Loading commit data...
CustomTarget_x64.mk Loading commit data...
Executable_lngconvex.mk Loading commit data...
Executable_regsvrex.mk Loading commit data...
Executable_senddoc.mk Loading commit data...
Executable_uri_encode.mk Loading commit data...
Library_cmdmail.mk Loading commit data...
Library_desktopbe.mk Loading commit data...
Library_kde4be.mk Loading commit data...
Library_kde5be.mk Loading commit data...
Library_localebe.mk Loading commit data...
Library_losessioninstall.mk Loading commit data...
Library_macbe.mk Loading commit data...
Library_ooofilt.mk Loading commit data...
Library_ooofilt_x64.mk Loading commit data...
Library_propertyhdl.mk Loading commit data...
Library_propertyhdl_x64.mk Loading commit data...
Library_recentfile.mk Loading commit data...
Library_shlxthdl.mk Loading commit data...
Library_shlxthdl_x64.mk Loading commit data...
Library_smplmail.mk Loading commit data...
Library_spsupp.mk Loading commit data...
Library_spsupp_x64.mk Loading commit data...
Library_syssh.mk Loading commit data...
Library_wininetbe.mk Loading commit data...
Makefile Loading commit data...
Module_shell.mk Loading commit data...
Package_senddoc.mk Loading commit data...
README Loading commit data...
StaticLibrary_shlxthandler_common.mk Loading commit data...
StaticLibrary_shlxthandler_common_x64.mk Loading commit data...
StaticLibrary_xmlparser.mk Loading commit data...
StaticLibrary_xmlparser_x64.mk Loading commit data...
WinResTarget_shlxthdl.mk Loading commit data...
WinResTarget_spsupp.mk Loading commit data...