• Noel Grandin's avatar
    tdf#100894 freeze when editing calc file with bazillions of cond formatting · d70f53a8
    Noel Grandin yazdı
    This does not fix the root cause of this problem, which is simply that
    the document has a bazillion style sheets. Either the program which
    exported this document is broken, or our importer is not correctly de-
    duplicating the imported stylesheets.
    
    Anyhow, I made performance improvements until I realised that it was
    simply going to be impossible to display that many stylesheets in our
    UI.
    
    But still, this bug was useful in flushing out some performance issues.
    
    The improvements, in order of decreasing importance are:
    
    (*) Use SfxStyleSheetIterator in SvxStyleToolBoxControl::FillStyleBox to
    avoid an O(n^2) situation where the pool repeatedly marks all the
    stylesheets as not-used, and then walks the document finding out if a
    stylesheet is used. Which is a waste of time because we're searching the
    documents pool, so of course they are all used.
    
    (*) Add a virtual method to avoid dynamic_cast
    
    (*) return raw pointers instead of returning rtl::Reference by value to
    avoid unnecessary reference counting.
    
    SfxStyleSheetIterator
    
    Change-Id: I15ff9c1846d3ed3e6f5655fa44c762f7619d547a
    Reviewed-on: https://gerrit.libreoffice.org/55751Tested-by: 's avatarJenkins <ci@libreoffice.org>
    Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
    d70f53a8
Adı
Son kayıt (commit)
Son güncelleme
..
inc Loading commit data...
qa Loading commit data...
res Loading commit data...
sdi Loading commit data...
source Loading commit data...
uiconfig Loading commit data...
util Loading commit data...
workben Loading commit data...
xml Loading commit data...
xsl Loading commit data...
AllLangMoTarget_sd.mk Loading commit data...
CppunitTest_sd_activex_controls_tests.mk Loading commit data...
CppunitTest_sd_dialogs_test.mk Loading commit data...
CppunitTest_sd_export_ooxml1.mk Loading commit data...
CppunitTest_sd_export_ooxml2.mk Loading commit data...
CppunitTest_sd_export_tests.mk Loading commit data...
CppunitTest_sd_filters_test.mk Loading commit data...
CppunitTest_sd_html_export_tests.mk Loading commit data...
CppunitTest_sd_import_tests.mk Loading commit data...
CppunitTest_sd_import_tests_smartart.mk Loading commit data...
CppunitTest_sd_misc_tests.mk Loading commit data...
CppunitTest_sd_svg_export_tests.mk Loading commit data...
CppunitTest_sd_tiledrendering.mk Loading commit data...
CppunitTest_sd_uimpress.mk Loading commit data...
IwyuFilter_sd.yaml Loading commit data...
JunitTest_sd_unoapi.mk Loading commit data...
Library_sd.mk Loading commit data...
Library_sdd.mk Loading commit data...
Library_sdfilt.mk Loading commit data...
Library_sdui.mk Loading commit data...
Makefile Loading commit data...
Module_sd.mk Loading commit data...
Package_opengl.mk Loading commit data...
Package_web.mk Loading commit data...
Package_xml.mk Loading commit data...
README Loading commit data...
README_REMOTE Loading commit data...
UIConfig_sdraw.mk Loading commit data...
UIConfig_simpress.mk Loading commit data...