• Mike Kaganski's avatar
    Install UCRT from MSUs, not using nested VC Redist install · b8424437
    Mike Kaganski yazdı
    Using nested install is bad because (1) MS advises against it (though it
    most possibly doesn't relate to our specific case, when we install the
    vc redist exe package in UI part, so actually only a single MSI session
    is active at any time); (2) because it adds some extra interactions
    (user sees something "unrelated" being installed, which raises concerns;
    additional admin authentication required); and (3) because it runs in
    InstallUISequence, thus only installing the UCRT when doing interactive
    installation (unattended installs, including GPO, need to install UCRT
    separately).
    
    This patch aims to incorporate the original UCRT MSU (Windows Update)
    packages (https://support.microsoft.com/en-us/help/2999226) available as
    a zip archive from
    https://www.microsoft.com/en-us/download/details.aspx?id=48234
    - the same as used in VC redists for VS 2015 and 2017. This obsoletes
    the separate installation of the redist; since we also have the redist
    as merge module in our MSI, that is enough (and removes redundancy).
    The MSUs are installed using wusa.exe in a custom action (deferred,
    non-impersonating).
    
    As a small bonus, embedding MSUs instead of redist EXE allows us to
    shrink the size of installer a little (~10 MB).
    
    As deferred custom actions cannot access current installer database,
    we workaround this by using initial immediate impersonating action to
    extract the binaries into a temporary location. To ensure that the file
    gets removed upon completion (both successful and failed), we use an
    additional cleanup action.
    
    Commit 61b1d631 is effectively reverted.
    
    Change-Id: I1529356fdcc67ff24b232c01ddf8bb3a31bb00bd
    Reviewed-on: https://gerrit.libreoffice.org/52923Tested-by: 's avatarJenkins <ci@libreoffice.org>
    Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
    b8424437
Adı
Son kayıt (commit)
Son güncelleme
..
packimages Loading commit data...
qa Loading commit data...
signing Loading commit data...
CppunitTest_services.mk Loading commit data...
CustomTarget_check_dynamic_objects.mk Loading commit data...
CustomTarget_fontconfig.mk Loading commit data...
CustomTarget_images.mk Loading commit data...
CustomTarget_registry.mk Loading commit data...
CustomTarget_signing.mk Loading commit data...
Makefile Loading commit data...
Module_postprocess.mk Loading commit data...
Package_fontconfig.mk Loading commit data...
Package_images.mk Loading commit data...
Package_registry.mk Loading commit data...
README Loading commit data...
Rdb_services.mk Loading commit data...