• Stephan Bergmann's avatar
    Avoid overflow when scaling column width · 7af48113
    Stephan Bergmann yazdı
    With -fsanitize=float-cast-overflow, `--convert-to pdf csv/fdo40053-1.csv` with
    csv/fdo40053-1.csv as obtained by bin/get-bugzilla-attachments-by-mimetype
    (i.e., the attachment at
    <https://bugs.documentfoundation.org/show_bug.cgi?id=40053#c0>) fails with
    
    > sc/source/core/data/fillinfo.cxx:445:65: runtime error: 88326.7 is outside the range of representable values of type 'unsigned short'
    >  #0 in ScDocument::FillInfo(ScTableInfo&, short, int, short, int, short, double, double, bool, bool, ScMarkData const*) at sc/source/core/data/fillinfo.cxx:445:65 (instdir/program/../program/libsclo.so +0xdb7913d)
    >  #1 in ScPrintFunc::PrintArea(short, int, short, int, long, long, bool, bool, bool, bool) at sc/source/ui/view/printfun.cxx:1597:11 (instdir/program/../program/libsclo.so +0x130c0f91)
    >  #2 in ScPrintFunc::PrintPage(long, short, int, short, int, bool, ScPreviewLocationData*) at sc/source/ui/view/printfun.cxx:2284:9 (instdir/program/../program/libsclo.so +0x130dbf41)
    >  #3 in ScPrintFunc::DoPrint(MultiSelection const&, long, long, bool, ScPreviewLocationData*) at sc/source/ui/view/printfun.cxx:2702:29 (instdir/program/../program/libsclo.so +0x130e8cde)
    >  #4 in ScModelObj::render(int, com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at sc/source/ui/unoobj/docuno.cxx:2064:23 (instdir/program/../program/libsclo.so +0x124fea63)
    >  #5 in PDFExport::ExportSelection(vcl::PDFWriter&, com::sun::star::uno::Reference<com::sun::star::view::XRenderable> const&, com::sun::star::uno::Any const&, StringRangeEnumerator const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, int) at filter/source/pdf/pdfexport.cxx:227:34 (instdir/program/../program/libpdffilterlo.so +0x2db3b6)
    >  #6 in PDFExport::Export(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at filter/source/pdf/pdfexport.cxx:939:28 (instdir/program/../program/libpdffilterlo.so +0x2f3751)
    >  #7 in PDFFilter::implExport(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at filter/source/pdf/pdffilter.cxx:155:24 (instdir/program/../program/libpdffilterlo.so +0x33d7df)
    >  #8 in PDFFilter::filter(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) at filter/source/pdf/pdffilter.cxx:216:23 (instdir/program/../program/libpdffilterlo.so +0x33e64f)
    >  #9 in SfxObjectShell::ExportTo(SfxMedium&) at sfx2/source/doc/objstor.cxx:2422:25 (instdir/program/libsfxlo.so +0x4a03623)
    [...]
    
    where nX = 2, nTab = 0, GetColWidth(0,2) = 50075, and fColScale = 1.76389.
    Given csv/fdo40053-1.csv has rather much text in the third column, these values
    do not look completely implausible (whatever the column width unit of measure
    is, though)---which of course begs the question whether sal_uInt16 is an
    appropriate data type here.
    
    But assuming sal_uInt16 is a useful choice, just clamp the calculated width
    accordingly.  (Using std::clamp, we can get rid of the following lines that
    ensure nThisWidth >= 1.)
    
    Change-Id: Ifa7a666abedc2a2f0a335f4da0ea74961f33870c
    Reviewed-on: https://gerrit.libreoffice.org/73267
    Tested-by: Jenkins
    Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
    7af48113
Adı
Son kayıt (commit)
Son güncelleme
..
inc Loading commit data...
qa Loading commit data...
res/xml Loading commit data...
sdi Loading commit data...
source Loading commit data...
uiconfig/scalc Loading commit data...
util Loading commit data...
workben Loading commit data...
AllLangMoTarget_sc.mk Loading commit data...
CppunitTest_sc_addin_functions_test.mk Loading commit data...
CppunitTest_sc_anchor_test.mk Loading commit data...
CppunitTest_sc_annotationobj.mk Loading commit data...
CppunitTest_sc_annotationshapeobj.mk Loading commit data...
CppunitTest_sc_annotationsobj.mk Loading commit data...
CppunitTest_sc_arealinkobj.mk Loading commit data...
CppunitTest_sc_arealinksobj.mk Loading commit data...
CppunitTest_sc_array_functions_test.mk Loading commit data...
CppunitTest_sc_autoformatobj.mk Loading commit data...
CppunitTest_sc_autoformatsobj.mk Loading commit data...
CppunitTest_sc_bugfix_test.mk Loading commit data...
CppunitTest_sc_cache_test.mk Loading commit data...
CppunitTest_sc_cellcursorobj.mk Loading commit data...
CppunitTest_sc_cellfieldsobj.mk Loading commit data...
CppunitTest_sc_cellformatsenumeration.mk Loading commit data...
CppunitTest_sc_cellformatsobj.mk Loading commit data...
CppunitTest_sc_cellobj.mk Loading commit data...
CppunitTest_sc_cellrangeobj.mk Loading commit data...
CppunitTest_sc_cellrangesobj.mk Loading commit data...
CppunitTest_sc_cellsearchobj.mk Loading commit data...
CppunitTest_sc_cellsenumeration.mk Loading commit data...
CppunitTest_sc_cellsobj.mk Loading commit data...
CppunitTest_sc_chart2dataprovider.mk Loading commit data...
CppunitTest_sc_chart_regression_test.mk Loading commit data...
CppunitTest_sc_chartobj.mk Loading commit data...
CppunitTest_sc_chartsobj.mk Loading commit data...
CppunitTest_sc_check_data_pilot_field.mk Loading commit data...
CppunitTest_sc_check_data_pilot_table.mk Loading commit data...
CppunitTest_sc_check_xcell_ranges_query.mk Loading commit data...
CppunitTest_sc_cond_format_merge.mk Loading commit data...
CppunitTest_sc_consolidationdescriptorobj.mk Loading commit data...
CppunitTest_sc_copypaste.mk Loading commit data...
CppunitTest_sc_core.mk Loading commit data...
CppunitTest_sc_database_functions_test.mk Loading commit data...
CppunitTest_sc_databaserangeobj.mk Loading commit data...
CppunitTest_sc_databaserangesobj.mk Loading commit data...
CppunitTest_sc_datapilotfieldgroupitemobj.mk Loading commit data...
CppunitTest_sc_datapilotfieldgroupobj.mk Loading commit data...
CppunitTest_sc_datapilotfieldgroupsobj.mk Loading commit data...
CppunitTest_sc_datapilotfieldobj.mk Loading commit data...
CppunitTest_sc_datapilotfieldsobj.mk Loading commit data...
CppunitTest_sc_datapilotitemobj.mk Loading commit data...
CppunitTest_sc_datapilotitemsobj.mk Loading commit data...
CppunitTest_sc_datapilottableobj.mk Loading commit data...
CppunitTest_sc_datapilottablesobj.mk Loading commit data...
CppunitTest_sc_dataprovider.mk Loading commit data...
CppunitTest_sc_datatransformation.mk Loading commit data...
CppunitTest_sc_datetime_functions_test.mk Loading commit data...
CppunitTest_sc_ddelinkobj.mk Loading commit data...
CppunitTest_sc_ddelinksobj.mk Loading commit data...
CppunitTest_sc_documentconfigurationobj.mk Loading commit data...
CppunitTest_sc_drawpageobj.mk Loading commit data...
CppunitTest_sc_drawpagesobj.mk Loading commit data...
CppunitTest_sc_editfieldobj_cell.mk Loading commit data...
CppunitTest_sc_editfieldobj_header.mk Loading commit data...
CppunitTest_sc_filterdescriptorbase.mk Loading commit data...
CppunitTest_sc_filters_test.mk Loading commit data...
CppunitTest_sc_financial_functions_test.mk Loading commit data...
CppunitTest_sc_functiondescriptionobj.mk Loading commit data...
CppunitTest_sc_functionlistobj.mk Loading commit data...
CppunitTest_sc_functions_test_old.mk Loading commit data...
CppunitTest_sc_headerfieldsobj.mk Loading commit data...
CppunitTest_sc_headerfootercontentobj.mk Loading commit data...
CppunitTest_sc_html_export_test.mk Loading commit data...
CppunitTest_sc_importdescriptorbaseobj.mk Loading commit data...
CppunitTest_sc_indexenumeration_cellannotationsenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_cellarealinksenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_databaserangesenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_datapilotfieldsenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_datapilotitemsenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_datapilottablesenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_ddelinksenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_functiondescriptionenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_labelrangesenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_namedrangesenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_scenariosenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_sheetcellrangesenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_sheetlinksenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_spreadsheetsenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_spreadsheetviewpanesenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_subtotalfieldsenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_tableautoformatenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_tablechartsenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_tablecolumnsenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_tableconditionalentryenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_tablerowsenumeration.mk Loading commit data...
CppunitTest_sc_indexenumeration_textfieldenumeration.mk Loading commit data...
CppunitTest_sc_information_functions_test.mk Loading commit data...
CppunitTest_sc_labelrangeobj.mk Loading commit data...
CppunitTest_sc_labelrangesobj.mk Loading commit data...
CppunitTest_sc_logical_functions_test.mk Loading commit data...
CppunitTest_sc_macros_test.mk Loading commit data...
CppunitTest_sc_mark_test.mk Loading commit data...
CppunitTest_sc_mathematical_functions_test.mk Loading commit data...
CppunitTest_sc_modelobj.mk Loading commit data...
CppunitTest_sc_namedrangeobj.mk Loading commit data...
CppunitTest_sc_namedrangesobj.mk Loading commit data...
CppunitTest_sc_new_cond_format_api.mk Loading commit data...
CppunitTest_sc_opencl_test.mk Loading commit data...
CppunitTest_sc_outlineobj.mk Loading commit data...
CppunitTest_sc_parallelism.mk Loading commit data...
CppunitTest_sc_pdf_export.mk Loading commit data...
CppunitTest_sc_perfobj.mk Loading commit data...
CppunitTest_sc_pivottable_filters_test.mk Loading commit data...
CppunitTest_sc_range_test.mk Loading commit data...
CppunitTest_sc_rangelst_test.mk Loading commit data...
CppunitTest_sc_recentfunctionsobj.mk Loading commit data...
CppunitTest_sc_recordchanges.mk Loading commit data...
CppunitTest_sc_scenariosobj.mk Loading commit data...
CppunitTest_sc_screenshots.mk Loading commit data...
CppunitTest_sc_shapeobj.mk Loading commit data...
CppunitTest_sc_sheetlinkobj.mk Loading commit data...
CppunitTest_sc_sheetlinksobj.mk Loading commit data...
CppunitTest_sc_sortdescriptorbaseobj.mk Loading commit data...
CppunitTest_sc_spreadsheet_functions_test.mk Loading commit data...
CppunitTest_sc_spreadsheetsettings.mk Loading commit data...
CppunitTest_sc_spreadsheetsettingsobj.mk Loading commit data...
CppunitTest_sc_statistical_functions_test.mk Loading commit data...
CppunitTest_sc_stylefamiliesobj.mk Loading commit data...
CppunitTest_sc_stylefamilyobj.mk Loading commit data...
CppunitTest_sc_subsequent_export_test.mk Loading commit data...
CppunitTest_sc_subsequent_filters_test.mk Loading commit data...
CppunitTest_sc_subtotaldescriptorbase.mk Loading commit data...
CppunitTest_sc_subtotalfieldobj.mk Loading commit data...
CppunitTest_sc_tablecolumnobj.mk Loading commit data...
CppunitTest_sc_tablecolumnsobj.mk Loading commit data...
CppunitTest_sc_tableconditionalentryobj.mk Loading commit data...
CppunitTest_sc_tableconditionalformat.mk Loading commit data...
CppunitTest_sc_tablerowobj.mk Loading commit data...
CppunitTest_sc_tablerowsobj.mk Loading commit data...
CppunitTest_sc_tablesheetobj.mk Loading commit data...
CppunitTest_sc_tablesheetsobj.mk Loading commit data...
CppunitTest_sc_tablevalidationobj.mk Loading commit data...
CppunitTest_sc_tabviewobj.mk Loading commit data...
CppunitTest_sc_text_functions_test.mk Loading commit data...
CppunitTest_sc_tiledrendering.mk Loading commit data...
CppunitTest_sc_ucalc.mk Loading commit data...
CppunitTest_sc_uniquecellformatsenumeration.mk Loading commit data...
CppunitTest_sc_uniquecellformatsobj.mk Loading commit data...
CppunitTest_sc_viewpaneobj.mk Loading commit data...
IwyuFilter_sc.yaml Loading commit data...
JunitTest_sc_complex.mk Loading commit data...
JunitTest_sc_unoapi_1.mk Loading commit data...
JunitTest_sc_unoapi_2.mk Loading commit data...
JunitTest_sc_unoapi_3.mk Loading commit data...
JunitTest_sc_unoapi_4.mk Loading commit data...
JunitTest_sc_unoapi_6.mk Loading commit data...
JunitTest_sc_unoapi_7.mk Loading commit data...
Library_sc.mk Loading commit data...
Library_scd.mk Loading commit data...
Library_scfilt.mk Loading commit data...
Library_scqahelper.mk Loading commit data...
Library_scui.mk Loading commit data...
Library_vbaobj.mk Loading commit data...
Makefile Loading commit data...
Module_sc.mk Loading commit data...
Package_opencl.mk Loading commit data...
Package_res_xml.mk Loading commit data...
PythonTest_sc_python.mk Loading commit data...
README Loading commit data...
TODO.performance Loading commit data...
UIConfig_scalc.mk Loading commit data...
UITest_autofilter.mk Loading commit data...
UITest_calc_tests.mk Loading commit data...
UITest_calc_tests2.mk Loading commit data...
UITest_calc_tests3.mk Loading commit data...
UITest_calc_tests4.mk Loading commit data...
UITest_calc_tests6.mk Loading commit data...
UITest_calc_tests7.mk Loading commit data...
UITest_calc_tests8.mk Loading commit data...
UITest_chart.mk Loading commit data...
UITest_conditional_format.mk Loading commit data...
UITest_goalSeek.mk Loading commit data...
UITest_hideShowSheet.mk Loading commit data...
UITest_hide_cols.mk Loading commit data...
UITest_inputLine.mk Loading commit data...
UITest_key_f4.mk Loading commit data...
UITest_options.mk Loading commit data...
UITest_pageFormat.mk Loading commit data...
UITest_protect.mk Loading commit data...
UITest_range_name.mk Loading commit data...
UITest_search_replace.mk Loading commit data...
UITest_signatureLine.mk Loading commit data...
UITest_solver.mk Loading commit data...
UITest_sort.mk Loading commit data...
UITest_statistics.mk Loading commit data...
UITest_textCase.mk Loading commit data...
UITest_validity.mk Loading commit data...
common_unoapi_tests.mk Loading commit data...