• Stephan Bergmann's avatar
    Avoid -fsanitize=null · ddcc2ae7
    Stephan Bergmann yazdı
    ...during CppunitTest_sd_filters_test (see below), where
    SfxStyleSheetBase::m_pPool has apparently been null'ed in
    SdStyleSheet::disposing (sd/source/core/stlsheet.cxx).  Presumably introduced
    with dfefe448 "SOSAW080: Added first bunch of
    basic changes to helpers"; adding a "TTTT" marker on alg_'s request.
    
    Needed to change SfxStyleSheetBase::GetPool to return pointer instead of ref.
    
    > include/svl/style.hxx:142:47: runtime error: reference binding to null pointer of type 'SfxStyleSheetBasePool'
    >  #0 in SfxStyleSheetBase::GetPool() at include/svl/style.hxx:142:40 (instdir/program/libsvxcorelo.so +0x2d7a3ed)
    >  #1 in sdr::properties::AttributeProperties::ImpRemoveStyleSheet() at svx/source/sdr/properties/attributeproperties.cxx:136:44 (instdir/program/libsvxcorelo.so +0x2d72f40)
    >  #2 in sdr::properties::AttributeProperties::Notify(SfxBroadcaster&, SfxHint const&) at svx/source/sdr/properties/attributeproperties.cxx:474:25 (instdir/program/libsvxcorelo.so +0x2d793ec)
    >  #3 in sdr::properties::TextProperties::Notify(SfxBroadcaster&, SfxHint const&) at svx/source/sdr/properties/textproperties.cxx:542:34 (instdir/program/libsvxcorelo.so +0x2d631f2)
    >  #4 in SfxBroadcaster::Broadcast(SfxHint const&) at svl/source/notify/SfxBroadcaster.cxx:49:24 (instdir/program/libsvllo.so +0xc2d628)
    >  #5 in (anonymous namespace)::StyleSheetDisposerFunctor::Dispose(rtl::Reference<SfxStyleSheetBase>) at svl/source/items/style.cxx:804:16 (instdir/program/libsvllo.so +0x99e4ef)
    >  #6 in svl::IndexedStyleSheets::Clear(svl::StyleSheetDisposer&) at svl/source/items/IndexedStyleSheets.cxx:202:18 (instdir/program/libsvllo.so +0x8bb852)
    >  #7 in SfxStyleSheetBasePool::Clear() at svl/source/items/style.cxx:815:34 (instdir/program/libsvllo.so +0x9965ea)
    >  #8 in SdStyleSheetPool::dispose() at sd/source/core/stlpool.cxx:1386:9 (instdir/program/libsdlo.so +0x25353a7)
    >  #9 in SdrModel::~SdrModel() at svx/source/svdraw/svdmodel.cxx:275:25 (instdir/program/libsvxcorelo.so +0x323f1ad)
    >  #10 in FmFormModel::~FmFormModel() at svx/source/form/fmmodel.cxx:94:1 (instdir/program/libsvxcorelo.so +0x465f020)
    >  #11 in SdDrawDocument::~SdDrawDocument() at sd/source/core/drawdoc.cxx:394:1 (instdir/program/libsdlo.so +0x2324254)
    >  #12 in SdDrawDocument::~SdDrawDocument() at sd/source/core/drawdoc.cxx:346:1 (instdir/program/libsdlo.so +0x2324445)
    >  #13 in SdDrawDocument::~SdDrawDocument() at sd/source/core/drawdoc.cxx:346:1 (instdir/program/libsdlo.so +0x23244ce)
    >  #14 in sd::DrawDocShell::~DrawDocShell() at sd/source/ui/docshell/docshell.cxx:200:9 (instdir/program/libsdlo.so +0x2c4bdb9)
    >  #15 in sd::DrawDocShell::~DrawDocShell() at sd/source/ui/docshell/docshell.cxx:179:1 (instdir/program/libsdlo.so +0x2c4c4a5)
    >  #16 in sd::DrawDocShell::~DrawDocShell() at sd/source/ui/docshell/docshell.cxx:179:1 (instdir/program/libsdlo.so +0x2c4c56e)
    >  #17 in SvRefBase::ReleaseRef() at include/tools/ref.hxx:165:29 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x1ff01)
    >  #18 in tools::SvRef<sd::DrawDocShell>::~SvRef() at include/tools/ref.hxx:56:36 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x1a9fc)
    >  #19 in SdFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at sd/qa/unit/filters-test.cxx:78:1 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x17f53)
    >  #20 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:130:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x5589c)
    >  #21 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:155:5 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x56519)
    >  #22 in SdFiltersTest::testCVEs() at sd/qa/unit/filters-test.cxx:83:5 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x1839d)
    
    Change-Id: Ibf61c18738c7a204ebf2bbc85b28930481b22612
    Reviewed-on: https://gerrit.libreoffice.org/52554Tested-by: 's avatarJenkins <ci@libreoffice.org>
    Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
    ddcc2ae7
Adı
Son kayıt (commit)
Son güncelleme
..
IndexedStyleSheets.hxx Loading commit data...
PasswordHelper.hxx Loading commit data...
SfxBroadcaster.hxx Loading commit data...
adrparse.hxx Loading commit data...
aeitem.hxx Loading commit data...
asiancfg.hxx Loading commit data...
broadcast.hxx Loading commit data...
cenumitm.hxx Loading commit data...
cintitem.hxx Loading commit data...
cjkoptions.hxx Loading commit data...
converter.hxx Loading commit data...
cryptosign.hxx Loading commit data...
ctloptions.hxx Loading commit data...
currencytable.hxx Loading commit data...
custritm.hxx Loading commit data...
documentlockfile.hxx Loading commit data...
eitem.hxx Loading commit data...
filenotation.hxx Loading commit data...
flagitem.hxx Loading commit data...
fstathelper.hxx Loading commit data...
globalnameitem.hxx Loading commit data...
grabbagitem.hxx Loading commit data...
gridprinter.hxx Loading commit data...
hint.hxx Loading commit data...
ilstitem.hxx Loading commit data...
imageitm.hxx Loading commit data...
inethist.hxx Loading commit data...
inettype.hxx Loading commit data...
instrm.hxx Loading commit data...
int64item.hxx Loading commit data...
intitem.hxx Loading commit data...
isethint.hxx Loading commit data...
itemiter.hxx Loading commit data...
itempool.hxx Loading commit data...
itemprop.hxx Loading commit data...
itemset.hxx Loading commit data...
languageoptions.hxx Loading commit data...
lckbitem.hxx Loading commit data...
listener.hxx Loading commit data...
lngmisc.hxx Loading commit data...
lockfilecommon.hxx Loading commit data...
lstner.hxx Loading commit data...
macitem.hxx Loading commit data...
memberid.h Loading commit data...
metitem.hxx Loading commit data...
nfkeytab.hxx Loading commit data...
nfsymbol.hxx Loading commit data...
numuno.hxx Loading commit data...
ondemand.hxx Loading commit data...
outstrm.hxx Loading commit data...
ownlist.hxx Loading commit data...
pickerhistoryaccess.hxx Loading commit data...
poolcach.hxx Loading commit data...
poolitem.hxx Loading commit data...
ptitem.hxx Loading commit data...
rectitem.hxx Loading commit data...
rngitem.hxx Loading commit data...
sharecontrolfile.hxx Loading commit data...
sharedstring.hxx Loading commit data...
sharedstringpool.hxx Loading commit data...
sigstruct.hxx Loading commit data...
slstitm.hxx Loading commit data...
solar.hrc Loading commit data...
srchdefs.hxx Loading commit data...
srchitem.hxx Loading commit data...
stritem.hxx Loading commit data...
style.hxx Loading commit data...
stylepool.hxx Loading commit data...
stylesheetuser.hxx Loading commit data...
svdde.hxx Loading commit data...
svl.hrc Loading commit data...
svldllapi.h Loading commit data...
svlresid.hxx Loading commit data...
typedwhich.hxx Loading commit data...
undo.hxx Loading commit data...
urihelper.hxx Loading commit data...
urlbmk.hxx Loading commit data...
urlfilter.hxx Loading commit data...
visitem.hxx Loading commit data...
whiter.hxx Loading commit data...
zforlist.hxx Loading commit data...
zformat.hxx Loading commit data...