• Lionel Elie Mamane's avatar
    tdf#104986 move named parameters substitution into generic layer · a29d97e6
    Lionel Elie Mamane yazdı
    Previously, drivers were responsible for making the substitution themselves.
    In practice they all (Firebird, ODBC and JDBC) used the LibreOffice SQL
    parser to parse the SQL statement and do the substitution.
    This had a few negative consequences:
     * The substitition was applied to _all_ SQL commands, including
       queries having the "execute SQL directly" bit set. Which means
       that the SQL was _not_ sent to the DBMS exactly as typed by
       the user. Even if there was no substitution to be made, since
       the SQL command was always round-tripped through the parser,
       thus "normalising" it (which is what led to tdf#104986).
     * "execute SQL directly" queries "magically" behaved slightly
       differently depending on whether the LibreOffice SQL parser
       succeeded in parsing them or not.
    Change-Id: Ieedc643f33467435a139e2565a01e6f398af041f
    Reviewed-on: https://gerrit.libreoffice.org/47283Tested-by: 's avatarJenkins <ci@libreoffice.org>
    Reviewed-by: 's avatarLionel Elie Mamane <lionel@mamane.lu>