• Tor Lillqvist's avatar
    tdf#116511: Drop questionable check for more keyboard input · 16f784b1
    Tor Lillqvist yazdı
    For some reason, on macOS, when this is being invoked through the
    shortcut, Application::AnyInput( VclInputFlags::KEYBOARD ) returns
    true, so the code thinks that there is more keyboard input and won't
    call UpdateTokenArray(), which sets m_pTokenArray.
    
    I think that optmisation is questionable, especially as the exact
    semantics of our event loop API, like Application::AnyInput(), is
    under-defined and probably can and will change in various minor ways
    when people work on improving it on the Mac (and perhaps other
    platforms, too).
    
    (The event loop etc certainly needs improvement on the Mac. Consider
    the "WindowServer grows to tens of gigabytes when running make check"
    issue which is closely related. Unfortunately nobody has come up with
    a simple fix for that yet, exactly because we use our event loop
    related APIs in so imaginative ways all over the code, and fixing one
    thing usually breaks another.)
    
    Change-Id: I865d46e5ee69609ad58bc915ff949e0f3602d8f5
    Reviewed-on: https://gerrit.libreoffice.org/54448Tested-by: 's avatarJenkins <ci@libreoffice.org>
    Reviewed-by: 's avatarTor Lillqvist <tml@collabora.com>
    16f784b1
Adı
Son kayıt (commit)
Son güncelleme
..
inc Loading commit data...
qa/unit Loading commit data...
source Loading commit data...
uiconfig/ui Loading commit data...
util Loading commit data...
AllLangMoTarget_for.mk Loading commit data...
CppunitTest_formula_dialogs_test.mk Loading commit data...
Library_for.mk Loading commit data...
Library_forui.mk Loading commit data...
Makefile Loading commit data...
Module_formula.mk Loading commit data...
README Loading commit data...
UIConfig_formula.mk Loading commit data...