• Eike Rathke's avatar
    Resolves: tdf#115950 proper double click return and bail out, tdf#117063 · c9d1655d
    Eike Rathke yazdı
        commit b649ce12
        CommitDate: Sun Apr 29 08:46:46 2018 +0200
    
            tdf#117063 Modify tree list double click behavior in the navigator
    
    changed the return value in SvTreeListBox::DoubleClickHdl() from
    
      return !aDoubleClickHdl.IsSet() || aDoubleClickHdl.Call(this);
    
    to an unconditional true. Earlier there was
    
        commit 1b9af084
        CommitDate: Tue Mar 13 16:28:40 2018 +0100
    
            tdf#116334: Actually when there is no handler, we have to return 'true'.
    
        -    aDoubleClickHdl.Call( this );
        -    return false;
        +    return !aDoubleClickHdl.IsSet() || aDoubleClickHdl.Call(this);
    
    and before that
    
        commit 7651e575
        CommitDate: Thu Mar 1 15:41:13 2018 +0100
    
            tdf#115950: Indicate that the dialog was already destroyed.
    
        -    return true;
        +    return false;
    
    Neither a constant false or true are correct return values here,
    but only the value the double click handler, if any, returned to
    indicate whether processing should continue (true) or not (false).
    
    If handlers don't return a proper value so the intended behaviour
    for tdf#117063 or anything else does not work then fix the
    handlers instead.
    
    If the handler returned false then don't even attempt to access
    anything in SvImpLBox::MouseButtonDown() because an OK handler may
    have destroyed everything and all is rotten.
    
    Change-Id: Ia90c21288bedd7e5078dbe4b3dd6d9f5199a2a98
    Reviewed-on: https://gerrit.libreoffice.org/57225
    Tested-by: Jenkins
    Reviewed-by: 's avatarJan Holesovsky <kendy@collabora.com>
    Reviewed-by: 's avatarEike Rathke <erack@redhat.com>
    c9d1655d
Adı
Son kayıt (commit)
Son güncelleme
..
inc Loading commit data...
langsupport Loading commit data...
qa Loading commit data...
source Loading commit data...
uiconfig/ui Loading commit data...
util Loading commit data...
AllLangMoTarget_svt.mk Loading commit data...
CppunitTest_svtools_dialogs_test.mk Loading commit data...
CppunitTest_svtools_graphic.mk Loading commit data...
CppunitTest_svtools_html.mk Loading commit data...
Executable_langsupport.mk Loading commit data...
JunitTest_svtools_unoapi.mk Loading commit data...
Library_svt.mk Loading commit data...
Makefile Loading commit data...
Module_svtools.mk Loading commit data...
README Loading commit data...
UIConfig_svt.mk Loading commit data...