Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 24 Ara, 2018 1 kayıt (commit)
  3. 17 Ara, 2018 1 kayıt (commit)
  5. 16 Ara, 2018 1 kayıt (commit)
    • Mike Kaganski's avatar
      tdf#121987 follow-up: never fail MSU install; warn instead. · 0b6884b9
      Mike Kaganski yazdı 
      This replaces commit 53058090. Now
not only failure to start WU service, but also other errors during
MSU installation won't break installation. E.g., running WU service
as Guest does not prevent the service from starting; but installing
updates fail, which makes previous solution incomplete.

Instead, show a warning in those rare cases when an error happens,
and continue. It will allow users to see the reason if they see
"api-ms-win-*.dll missing" message later after installation. Of
course, some small percentage of these warnings will be false, e.g.
those on Windows 10. But those false messages must be really small
minority, because only when (1) the installation fails (2) on a
system with the component already present, such a message would be
false. And it will not prevent the installation.

This will not block unattended installations, since in those cases,
MsiProcessMessage() will do nothing.

Change-Id: I3a9e681e9d6701d092bd5c18bb4b68b4f77170f3
Reviewed-on: https://gerrit.libreoffice.org/64874
Tested-by: Jenkins
Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      0b6884b9
  7. 09 Kas, 2018 1 kayıt (commit)
  9. 20 Eyl, 2018 1 kayıt (commit)
    • Mike Kaganski's avatar
      tdf#115405, tdf#119910: don't check if UCRT is already installed · 18828273
      Mike Kaganski yazdı 
      There appears to be common situation that a system has *some* UCRT libraries
in System32, that were installed improperly (presumably by some applications
using simple copy).In these cases, our installer would detect the presence of
ucrtbase.dll, and not try to install UCRT on the system.

Unfortunately, it seems that oftentimes such improper UCRT installations miss
some parts of UCRT, which leads to LibreOffice failing to start with messages
like "The program can't start because api-ms-win-crt-string-l1-1-0.dll is
missing from your computer. Try reinstalling the program to fix this problem."
(the missing component varies).

This patch removes the check for UCRT presence. Installer will try to install
UCRT on applicable systems unconditionally. Since the proper outcomes in case
of already present UCRT are either WU_S_ALREADY_INSTALLED or WU_E_NOT_APPLICABLE
and both are treated as success in inst_msu action (see InstallMSU in
setup_native/source/win32/customactions/inst_msu/inst_msu.cxx), this should
only make this part more robust, and not bring new problems (yes, I know that
actually there will be new problems, as usual).

Change-Id: I22a3d357014d31a8e492ff8a15bcb477eeb79735
Reviewed-on: https://gerrit.libreoffice.org/60789
Tested-by: Jenkins
Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      18828273
  11. 29 Agu, 2018 1 kayıt (commit)
  13. 05 Agu, 2018 1 kayıt (commit)
    • Adolfo Jayme Barrientos's avatar
      Use proper Windows terminology here · b79d8de3
      Adolfo Jayme Barrientos yazdı 
      Microsoft has never referred to desktop shortcuts as “start links”.
This change aligns our installer with almost every other installer
out there.

Change-Id: Ib5779e6cd44e719e52d1afeb6a44c7dc8f3624dc
      b79d8de3
  15. 30 Tem, 2018 1 kayıt (commit)
  17. 25 Nis, 2018 1 kayıt (commit)
    • Mike Kaganski's avatar
      Install UCRT from MSUs, not using nested VC Redist install · b8424437
      Mike Kaganski yazdı 
      Using nested install is bad because (1) MS advises against it (though it
most possibly doesn't relate to our specific case, when we install the
vc redist exe package in UI part, so actually only a single MSI session
is active at any time); (2) because it adds some extra interactions
(user sees something "unrelated" being installed, which raises concerns;
additional admin authentication required); and (3) because it runs in
InstallUISequence, thus only installing the UCRT when doing interactive
installation (unattended installs, including GPO, need to install UCRT
separately).

This patch aims to incorporate the original UCRT MSU (Windows Update)
packages (https://support.microsoft.com/en-us/help/2999226) available as
a zip archive from
https://www.microsoft.com/en-us/download/details.aspx?id=48234
- the same as used in VC redists for VS 2015 and 2017. This obsoletes
the separate installation of the redist; since we also have the redist
as merge module in our MSI, that is enough (and removes redundancy).
The MSUs are installed using wusa.exe in a custom action (deferred,
non-impersonating).

As a small bonus, embedding MSUs instead of redist EXE allows us to
shrink the size of installer a little (~10 MB).

As deferred custom actions cannot access current installer database,
we workaround this by using initial immediate impersonating action to
extract the binaries into a temporary location. To ensure that the file
gets removed upon completion (both successful and failed), we use an
additional cleanup action.

Commit 61b1d631 is effectively reverted.

Change-Id: I1529356fdcc67ff24b232c01ddf8bb3a31bb00bd
Reviewed-on: https://gerrit.libreoffice.org/52923Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      b8424437
  19. 18 Nis, 2018 1 kayıt (commit)
  21. 17 Nis, 2018 1 kayıt (commit)
  23. 16 Nis, 2018 1 kayıt (commit)
  25. 13 Nis, 2018 1 kayıt (commit)
  27. 12 Nis, 2018 2 kayıt (commit)
  29. 09 Nis, 2018 1 kayıt (commit)
  31. 23 Ock, 2018 1 kayıt (commit)
  33. 22 Ock, 2018 1 kayıt (commit)
  35. 18 Ara, 2017 1 kayıt (commit)
    • Mike Kaganski's avatar
      tdf#108580: integrate vc_redist.exe into MSI · 61b1d631
      Mike Kaganski yazdı 
      ... in InstallUISequense.

Use --with-vcredist-dir to point to a directory with vc_redist.x64.exe
and/or vc_redist.x86.exe. Use --without-vcredist-dir (or
--with-vcredist-dir=no) if you don't want to ship it as part of
installer and want to silence the configure warning.

VCRedist 2015 version 14.0.24215.1 is available at
https://www.microsoft.com/en-us/download/details.aspx?id=53840

Since VisualStudio 2015, VC redist merge module that we used before
started to work differently: it installs the UCRT only on WinXP,
but not on later OSes (Vista to 8.1) which may lack the UCRT (Win10
has it out of the box). The merge module only installs VCRuntime on
those systems, which still leaves us with "api-ms-*.dll is missing"
problem.

(https://blogs.msdn.microsoft.com/vcblog/2015/03/03/introducing-the-universal-crt/
gives more information on VCRedist refactoring background.)

Since commit 71d9a613, we use a
workaround described at the page mentioned above as "App-local
deployment of the Universal CRT". We just copy all UCRT DLLs to
LibreOffice/program. This has a drawback though, that our UCRT
is not updated by Windows Update, so users would rely on LibreOffice
updates in case of some vulnerabilities in UCRT (and they could
even not realize they have that problem).

MS recommends to install UCRT using EXEs they provide from their
site. The EXEs install both VCRuntimes and UCRTs, along with
required patches, for all Windows versions (Windows XP through
Windows 10, where they only install VCRuntimes); the installed
libraries are managed by system's update mechanism. But those EXEs
cannot be used in MSI custom actions inside InstallExecuteSequence,
because they use MSI themselves.

So this patch integrates the vc_redist.xXX.exe into MSI binary
table, and uses custom action to run the EXE after ExecuteAction
in InstallUISequence. This will show the user a VCRedist install
window after the main LibreOffice installation finishes; no user
interaction is required (except for one additional UAC request),
and errors are ignored.

Since this installation takes care of both VCRuntime and UCRT,
we can ultimately drop both the app-local workaround, and
vcredist merge module (so VCRuntime would also be updated by
system). The former is done here: this reverts commit
71d9a613.

This approach has its drawback: if one wants to use unattended
installation (without UI; one example is deployment using
ActiveDirectory GPO), then InstallUISequence is not run, and so
VCRedist isn't installed. In this case, one should install
VCRedist separately. Supposedly this should not be huge problem,
because this is the case for many existing applications that need
separate VCRedist deployment in these scenarios, and unattended
installation is advanced stuff that requires prepared user. A
notice would be required in release notes and FAQ, though.

Change-Id: Ia6a16be60af8a08f41ea7c3dbd457d8f89006006
Reviewed-on: https://gerrit.libreoffice.org/46356Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
Tested-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      61b1d631
  37. 15 Ara, 2017 1 kayıt (commit)
  39. 13 Eyl, 2017 1 kayıt (commit)
  41. 25 Agu, 2017 1 kayıt (commit)
  43. 30 Ock, 2017 1 kayıt (commit)
  45. 17 Agu, 2016 1 kayıt (commit)
  47. 05 Ock, 2016 1 kayıt (commit)
  49. 16 Eki, 2015 1 kayıt (commit)
  51. 02 Eyl, 2015 1 kayıt (commit)
  53. 15 Haz, 2015 1 kayıt (commit)
    • Caolán McNamara's avatar
      alternative solution to avoid adding a gnome-vfs dependency if disabled · 1a038dc8
      Caolán McNamara yazdı 
      i.e. "don't add gnomevfs requires to epm created rpms if GNOMEVFS is disabled"

seeing as setup_native/source/packinfo/packinfo_office.txt references
find-requires-gnome.sh and doesn't have conditional support revert the split
and put the the conditional into find-requires-gnome.sh

Change-Id: I34bd37c4fd252f2175ff055024293dea946b4881
      1a038dc8
  55. 10 Haz, 2015 1 kayıt (commit)
  57. 10 Nis, 2015 2 kayıt (commit)
  59. 10 Mar, 2015 2 kayıt (commit)
  61. 09 Ara, 2014 3 kayıt (commit)
  63. 20 Kas, 2014 1 kayıt (commit)
  65. 12 Kas, 2014 1 kayıt (commit)
  67. 23 Eki, 2014 1 kayıt (commit)
  69. 25 Haz, 2014 1 kayıt (commit)