Change-Id: I15f0a48c1e0c4c03f99a74d4d9b58e064d108c72
Reviewed-on: https://gerrit.libreoffice.org/44304Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie5306041e5cde5617e460ae4d98861e8d26e389d
Reviewed-on: https://gerrit.libreoffice.org/44297Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Project: dictionaries  56684558fb8bdb05cf8bc3e4c183e78de630dd6d

tdf#95024 update Hungarian spelling dictionary

Change-Id: I9cd563ff6c1d9e5547216efeadb65cf018c56026
Reviewed-on: https://gerrit.libreoffice.org/44290Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>

Change-Id: Ic770d1fb8e3735123786a73a7b57f71ad8005d5d
Reviewed-on: https://gerrit.libreoffice.org/44301Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I52db987ac3f11e318e2adf1ee797054f49c31f98
Reviewed-on: https://gerrit.libreoffice.org/44293Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

https://msdn.microsoft.com/en-us/library/ms679351 describes that
"it is unsafe to take an arbitrary system error code returned from an API
and use FORMAT_MESSAGE_FROM_SYSTEM without FORMAT_MESSAGE_IGNORE_INSERTS"
Previously in case when an error string would contain inserts, function
returned error, so the error message wasn't shown (at least it didn't
crash, thanks to nullptr as the function's last argument).

As the function may fail, we now pre-nullify the buffer pointer to avoid
dereferencing uninitialized pointer later (though at least for some
Windows versions, the function nullifies the pointer in case of
FORMAT_MESSAGE_ALLOCATE_BUFFER, but there's no explicit guarantee of this).

Also release of allocated buffer is changed to recommended use of
HeapFree.

The code that doesn't make use of OUString is left directly calling
FormatMessage, to avoid introducing new dependencies. Where it makes
sense, we now use WindowsErrorString from <comphelper/windowserrorstring.hxx>

Change-Id: I834c08eb6d92987e7d3d01e2c36ec55e42aea848
Reviewed-on: https://gerrit.libreoffice.org/44206Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I249c3dc5158a4aaa161d360378e4c657ffcc8af4
Reviewed-on: https://gerrit.libreoffice.org/44296Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

As discussed in IRC.
This matches the values in TEMPLATE.SOURCECODE.HEADER

Change-Id: I7e7bf5df0b011a54c8dddde5366e73e14068ef7d
Reviewed-on: https://gerrit.libreoffice.org/44249Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I8d9466bd4594dec819704141b03c280f52d824ef
Reviewed-on: https://gerrit.libreoffice.org/44267Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

- Start empty spreadsheet, open it with two users (let's call them A &
B).
- Type "=" with user A.
- Start moving around to different cells with user B.

=> Cell name of user B's selected cell is entered in user A's formula.

This is due to the fact that ScModel::GetInputHandler() returns always
the input handler which is handling the edited formula and not the
input handler of the current view.

That really messes up collaborative editing, so better to disable it,
until we implement an alternative solution.

Change-Id: I6e779cba3f377d12b7a4a19a6ee53c924fc9ba20
Reviewed-on: https://gerrit.libreoffice.org/43035Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: Ic80ca59abc3e104c7adf0c1eff1d16addf48bc8b
Reviewed-on: https://gerrit.libreoffice.org/44261Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9fc76693da88d74b6fe7bbb920b8e731b82be298
Reviewed-on: https://gerrit.libreoffice.org/44260Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ib6ae6b0c1ae1659955124bb5c710f2989a0feb3a
Reviewed-on: https://gerrit.libreoffice.org/44250Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Place the CppUnit:assertion_traits for ::table::CellAddress and
::table::CellRangeAddress into a file, so that they can be used/shared
from several locations. Avoid copy/paste action.

Change-Id: Ie2358ea1ac6925eef05644bea03a2ae526cd7fc6
Reviewed-on: https://gerrit.libreoffice.org/44291Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

as suggested by Stephan in comment of https://gerrit.libreoffice.org/#/c/44233/

Change-Id: Ia0a8c36441339628fd61ba862df73db11bbed302
Reviewed-on: https://gerrit.libreoffice.org/44276Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Having no tabs defined is the default value, so nothing generally
needs to be written. But if the paragraph style defines tabstops,
but the current paragraph doesn't have any, then those style
tabstops need to be cleared.

Change-Id: I7a818c658403cc683b0c5b7452b6c88ea00f771d
Reviewed-on: https://gerrit.libreoffice.org/44244Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>

Change-Id: If28e283666f4e1f87758c401b2d4fb5986eb6d8c
Reviewed-on: https://gerrit.libreoffice.org/44281Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Limit the input keys to the IPPart entry field. The limit is by
default set to free-form with the configuration key. When the
limitation is activated it is only possible to input chars '/',
';', ' ' (space) and delete.

Change-Id: Id3eb7e0198fb60e07894d6ff22a32351cca9d589
Reviewed-on: https://gerrit.libreoffice.org/44280Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I4742066c34802017790c1c21ec04a7760d4fe1f7
Reviewed-on: https://gerrit.libreoffice.org/44279Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I30ccdfb9d0584d8ee9b12666b1f96eb9ba8676ee
Reviewed-on: https://gerrit.libreoffice.org/44278Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I9bb60f1e7c58bbb63e8933578b83b77a178f325b
Reviewed-on: https://gerrit.libreoffice.org/44277Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>

so use same (slighty crazed) logic as DrawViewShell::Command

to get the right place when rtl is enabled

Change-Id: Icb4a39310ab98bd186cbafd516ca5f323da8cce1
Reviewed-on: https://gerrit.libreoffice.org/44274Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8c20b277ce943f915941b2af9353f98c66f9065c
Reviewed-on: https://gerrit.libreoffice.org/44271Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I43c9df757d78420bd119a06e7f7224e40690b753
Reviewed-on: https://gerrit.libreoffice.org/44255Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
Tested-by: Takeshi Abe <tabe@fixedpoint.jp>

...in com_MSC_class.mk now, similar to ecbaf980
for com_GCC_class.mk.  Three libraries built from external sources (for Windows
only) needed adjustment.

Change-Id: Id8976a30b80efff6119afb18ccaf6811fe27d2f8
Reviewed-on: https://gerrit.libreoffice.org/44270Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Id997aac2fd90f53652c81884c51833c92494e32f

... instead of generating them at the outer edge, specifically do
not create maximally dimensioned but still truncated matrix
formulas. Carried over-edge cases even overwrote each other
anyway.

Change-Id: Icb307f17ad153c6a5c69f869026abc1cf1d5c9f5

The problem is that even with the vertical-pos default fix,
we don't render ShapesWithWrapping.odt the same as Word does:

https://beta.opendocumentformat.org/rendercompare/upload/223/86/191/1

The shape still has a spurious bottom margin, which should not exist.

This has a surprising cause: the default-style family="paragraph"
has the attribute fo:margin-bottom="0.1388in" on paragraph-properties,
which gets imported as the pool's default item of RES_UL_SPACE;
there is nothing that prevents the shape from using this pool default
item if it doesn't have a margin set on itself.

Prevent that by overriding the pool default in
SwDoc::mpDfltFrameFormat, which already carries a XFillStyleItem
for similar reasons.

The mpDfltFrameFormat is used by a lot more than just shapes,
but none of that stuff should inherit paragraph defaults.

As an aside the fo:margin-* properties are also allowed on
style:graphic-properties, but it turns out that the implementation
of the default-style family="graphic", in
SvxUnoDrawPool/SwSvxUnoDrawPool, does not have the corresponding
properties, hence cannot import these.

Not sure if it would be better to have multiple SvxULSpace items
with different IDs, so the paragraphs and shapes and etc. can have
separate defaults.

Change-Id: Ie6a196db567beb7a48b4176f383c88490dcfb8e7

existing code doesn't expect that so stuff crashes

partial revert of...

commit db6b703d
Date:   Thu Aug 24 18:32:38 2017 +0200

    Allow non-modal Dialogs during FileImport/Load

Change-Id: I152feb849186cf035664a700d3f94ee049cdf6d3
Reviewed-on: https://gerrit.libreoffice.org/44227Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iccd150e8d704e065b8a3e060a1c9a2b6310e3641
Reviewed-on: https://gerrit.libreoffice.org/44265Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I2af7adc55c5b219086aad3157ccac1ce88a8ba97
Reviewed-on: https://gerrit.libreoffice.org/44266Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

At least on macOS, CppunitTest_sc_cellrangeobj failed for me with the try-
catch(...)-abort block in Scheduler::ProcessTaskScheduling
(vcl/source/app/scheduler.cxx) due to a com.sun.star.uno.DeploymentException
"component context fails to supply service
com.sun.star.linguistic2.LinguServiceManager of type
com.sun.star.linguistic2.XLinguServiceManager2".

Change-Id: I5b3c0f6cbd2f56bc86c62e048c87ad6ef5f83876

This reverts commit c5857a03.

Change-Id: I59326867bdf71dcf20a86e03499884452675c557
Reviewed-on: https://gerrit.libreoffice.org/44284Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I463fc54aa4139fbc43b6124765bf18ad8c0e6ddc
Reviewed-on: https://gerrit.libreoffice.org/44247Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>

After bd3c5c4c "[API CHANGE] tdf#65393 Import
signature line images from ooxml", UBSan CppunitTest_chart2_export had started
to fail with

> writerfilter/source/ooxml/OOXMLFastContextHandler.cxx:1898:25: runtime error: downcast of address 0x61200070a440 which does not point to an object of type 'writerfilter::ooxml::OOXMLFastContextHandlerShape'
> 0x61200070a440: note: object is of type 'writerfilter::ooxml::OOXMLFastContextHandlerWrapper'
>  0e 10 00 20  50 86 4a 00 a2 7f 00 00  01 00 00 00 be be be be  00 00 00 00 00 00 00 00  00 00 00 00
>               ^~~~~~~~~~~~~~~~~~~~~~~
>               vptr for 'writerfilter::ooxml::OOXMLFastContextHandlerWrapper'

Change-Id: I028ef619766466e8cd9bb0ca09174b926fc6d23c

Change-Id: I5984a8b7ef2d978c118d4e65e686027b1e510bd9
Reviewed-on: https://gerrit.libreoffice.org/44251Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

("No ... not specified" rather looked like an accidental double negation to me)

Change-Id: I8f1488b7e1561f8b2167a27120b60614b72a55fd

Change-Id: Ia126933260ea017f7cfdc8ac2ddc43b16aa37b91
Reviewed-on: https://gerrit.libreoffice.org/44248Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I563f7324129828d13c4549d330d58d6ab972472c
Reviewed-on: https://gerrit.libreoffice.org/44268Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de>
Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de>

Change-Id: I77212f1c6ca3d54ced1b73604e9d8a3022d72700