Make the order be 'public static' or 'private static'
Just makes the code nicer to read.

Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

In the tiled rendering case it does not need to check
if the window size is (0,0). But it still has to trigger
LOKit LOK_CALLBACK_INVALIDATE_TILES

Change-Id: I4c458edfd6e44599b8c8148e0f8543fb0563e627

Mac / Win cairo is not built / used, this cairo code can be removed to
reduce code bloat.

4th Revised version with Android fixes

Change-Id: I6e56850f535ca13b77839b7d67e227c5f39d388e
Reviewed-on: https://gerrit.libreoffice.org/16218Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af

Change-Id: I7ac5607f911d3ffc469fe01fcf708899f3e23e57

...similar to 6cca91f7 "CppunitTest_sw_uiwriter:
enable on Windows," whatever the original problem was in
601ba26c "Fix the Windows and OS X build
temporarily."

Change-Id: Ia1befff90d773637e01e6d88e398ae21a1d47108

SwDBManager::LoadAndRegisterDataSource() calls
SwXDocumentSettings::setPropertyValue() to set its EmbeddedDatabaseName
UNO property, when creating the embedded data source definition. OTOH,
during load, SwXDocumentSettings calls
SwDBManager::LoadAndRegisterEmbeddedDataSource() to register the data
source. The result is that when creating the embedded definition using
the MM wizard, we registered two data sources.

Fix the problem by first setting the UNO property, and only then storing
the data source definition.

Change-Id: I3efc141d9ab94828007a48a8bf5949b4f3b6510a

Change-Id: Ib4fb12e187eb4bad7da04425328d1f5cdf851654

Change-Id: I3dce3d131ce78713333d6e4bc2f3e839af5e04ec

Change-Id: I244a9eb6bce6b1c649653ec38ebb9a39f8b4c145
Reviewed-on: https://gerrit.libreoffice.org/16212Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

and replacing them with a call to XToolkitExperimental::
processEventsToIdle

Change-Id: I9fd6cb8af43d902587186310aebe78b5a5ee6932
Reviewed-on: https://gerrit.libreoffice.org/16201Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: If54b3017296f5bcea01b3b0d24d9ac821f6a24e9

... in Writer.

This (partially) reverts commit ebabf6d1.
I did not see the point to open Fields dialog by default, but other uses
are fully valid.

Change-Id: Ia06803fbb956266fb40c53f51099f9a32ddd6548
Reviewed-on: https://gerrit.libreoffice.org/16221Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

mac build really does not like finding extra stuff in the PATH
or in /usr/local/bin
as this is prone to happen with macport/fink/etc..
or somethings just due to some other 'ported to mac' pre-canned
binaries..
for instance one has found a python3 in /usr/local/bin
which confused configure to believe it was ok to use
'system python', which break on mac.

This patch sanitize PATH during ./autogen.sh, when running
in a LODE environment.
it leave only LODE_HOME/opt/bin:/usr/bin:/bin:/usr/sbin:/sbin  and optionally
the path where git is located if that is not /usr/bin
(it is quite common depending on how one installed git, to haev it in /usr/local/git/bin
for instance)

This is strictly a 'nanny' patch.. but it should not impact anyone
that is not ( on Mac and using LODE ).

Change-Id: I865047cfeb102ecb22777a1f7fb7cbdd374448aa
Reviewed-on: https://gerrit.libreoffice.org/16222Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>

Change-Id: I99a935ac7c1aee881bca77f95bd5d1a45d8901ea

on examination this PreparePaint virtual is only called from
SvTreeListBox::PaintEntry1

and PaintEntry1 is only called from SvImpLBox::Paint in a

    for(sal_uInt16 n=0; n< nCount && pEntry; n++)
    {
        /*long nMaxRight=*/
        pView->PaintEntry1

loop so pEntry always exists given that test. Re-jig things
so these families of method take a reference instead of a pointer
so verifying it cannot be NULL and a whole pile of else paths
fall away

Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d

Change-Id: I72aecb66d0de4ba2bc3a44f664aab8170ffb3d0f

(It feels better to use explicitly bool-typed css::uno::makeAny<bool>(x) rather
than implicitly typed css::uno::makeAny(x) or css::uno::Any(x), in case x is not
already of type bool.)

Change-Id: I282b3764bb207aeae9f13cc981e68e8ef2b8ab93

fixes regression from commit 4467c67d,
where the new optimized code path failed to properly register
ScFormulaCell with ScExternalRefManager.
Introduces a new public method in ScExternalRefManager: insertRefCellAsTmpl
that registers a formula cell to listen to the same external references
as template cell
Introduces new property to ScFormulaCell: mbIsExtRef
that indicates that some external references are referenced by this cell

Also introduces new method ScExternalRefManager::hasCellExternalReference
(for use in unit test, will be posted immediately)

Change-Id: Iee07d7b51949fd31953b5fa662a213052eb85181
Reviewed-on: https://gerrit.libreoffice.org/16066Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

depends on gerrit#16066

Change-Id: I3dde8acfbf0170d0c2cd3ef0b626f3b286922b65
Reviewed-on: https://gerrit.libreoffice.org/16210Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>

The new compiler is not detected automatically yet.
You have to use --with-visual-studio=2015 to enable it.

Change-Id: I0ef8cda7b2d99389b39fd7f8c2e142453ced99ed
Reviewed-on: https://gerrit.libreoffice.org/15644Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>

Already fixed by Miklos Vajna.

Change-Id: I848f2296c5f5a4d250308ed3a851c46524181340

This provider now throws exceptions with properly internationalized
messages to be shown to the user.

Change-Id: I0464bffe14cab24d50180cb5e2e62ce746bcba74
Reviewed-on: https://gerrit.libreoffice.org/16197Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>

With this patch, document providers are able to listen to changes in
their preferences and update their internal state accordingly. Now
ownCloud provider can see its server updated without restarting the
application.

Change-Id: I833c7ec9fc97be58bdc8ac2cbf4384a33c2b400e
Reviewed-on: https://gerrit.libreoffice.org/16196Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>

Change-Id: Ic48275fe2e7d83fd5e77171f4f5740a527dec7e2
Reviewed-on: https://gerrit.libreoffice.org/16195Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>

Change-Id: I4ad4dd12854ca9f332055a50131959f60f7da504
Reviewed-on: https://gerrit.libreoffice.org/16194Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>

Creates an activity to manage the settings of any document provider
that needs them, and populated it with the settings required by the
ownCloud implementation.

The settings screen is not yet plugged to the document browser UI but
can be launched with this command:

  adb shell am start -a android.intent.action.MAIN \
  -n org.libreoffice/.storage.DocumentProviderSettingsActivity

Change-Id: I83cff641fa61078f2bddbb98262af989c06985a9
Reviewed-on: https://gerrit.libreoffice.org/16193Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>

Documents are downloaded to the private cache directory of the app,
and opened from there. That directory is cleared and created again
every time the application starts up.

Change-Id: I5c05c8ae750b6ced3b419c67d84063e8ee3d84aa
Reviewed-on: https://gerrit.libreoffice.org/16192Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>

This implementation can connect to a local server and browser its
contents, but cannot download and open the documents yet.

TODO:

* Download and open documents.
* UI to configure server, user and password.
* Implement filtering to show only the documents of the desired type.
* Improve error handling.

Change-Id: I54a2e2e1d3e8ec8d824d75639e176ca452551f3e
Reviewed-on: https://gerrit.libreoffice.org/16191Reviewed-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>
Tested-by: Jacobo Aragunde Pérez <jaragunde@igalia.com>

Change-Id: I5b2a24fee50a25a41ba26787f7e30409348d7808

digging into the crash on export of kde216114-1.odt
reveals various horrors

Change-Id: I0d24fe303d561a00a08098b306d10fd8273af928

I hope that the underlying problem is fixed now by commit
670100fc (Remove FastLoader
optimization, 2015-06-10).

Change-Id: I1cb577ec1f50a45b40683031e79c0999338a2926

(i.e., parentheses do need to be quoted in BERs, but do not forget to escape
brakets in configure.ac m4)

Change-Id: Ifabb68ede318e5c95a54c420cd06e238fefbd82f

Change-Id: I2d1aa79a67bf130c3844b3bccb34a1761e8e4dfc

Change-Id: I030321e8cb905be78b68f9e404926e22723632ef

This clobbers the functionality from commit:

    06d73142

    make idle timers actually activate only when idle

Since now all rendering and re-sizing is done in idle handlers it
does effectively the opposite of what was intended. A better solution
would allow special-casing the processing of just rendering,
re-sizing and window management to spin for eg. progress bar
rendering.

Also add helpful debugging labels to the idle & timeouts.

Also cleanup the Idle vs. Scheduler handling.

Also ensure that starting an Idle triggers a mainloop wakeup.

Also add a unit test.

Change-Id: Ifb0756714378fdb790be599b93c7a3ac1f9209e6

- ./logerrit testfeature will trigger a testbuild of the
  current feature branch as it is on gerrit
- ./logerrit testfeature $BRANCH will do the same for $BRANCH
- cloning to a tempdir and rm -rf'ing around isnt ideal, so
  consider this as a template for your own scripting

Change-Id: I50a3c80748af82d855522f245ddbff227c8adab2

Change-Id: I8ed4b4d221040ddf5f51d7e01134c855fc85a641

Stop pointlessly inlining these virtual functions.

Change-Id: I11d123bc704ec6cf54925a13d139fce70cc59566

This reverts commit 8761ab9b; thinko, as the
RTTI needs to be visible with GCC too in the test code.