Change-Id: I425eb8595793560e35918c3b17b0c56cfd8ecaf6
Reviewed-on: https://gerrit.libreoffice.org/56867
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: Ia16a8b828e11ce36e9bb77ecf9e8a1179bd9b90c
Reviewed-on: https://gerrit.libreoffice.org/56841
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I3ac392f903644281c6a1ccb9183fbe1c72b78311
Reviewed-on: https://gerrit.libreoffice.org/56847
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

So set that at OutputDevice, there is no cell attribute for
kerning, all kerning on is handled by EditEngine output.

Change-Id: I23ac2b2cf59f3a4651cc9b614df03860a9cb9146
Reviewed-on: https://gerrit.libreoffice.org/56866Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

Change-Id: If3270ad1d20002dc39a5b4326b0cb42753112e93
Reviewed-on: https://gerrit.libreoffice.org/56868Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: Ia529a6a9cf0ce75c612b8fc0fa1bc7dc8f1c2b5a
Reviewed-on: https://gerrit.libreoffice.org/56853
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

... (introduced with 6fffd098 "tdf#109190 sd:
only MakeVisible on mouseclick-up") during CppunitTest_sd_misc_tests,
<https://ci.libreoffice.org//job/lo_ubsan/960/console>:

> /sd/source/ui/inc/DrawViewShell.hxx:117:50: runtime error: load of value 190, which is not a valid value for type 'bool'
>     #0 0x2b20592e1a9c in sd::DrawViewShell::IsMouseButtonDown() /sd/source/ui/inc/DrawViewShell.hxx:117:50
>     #1 0x2b20594e7c0c in sd::DrawViewShell::MakeVisible(tools::Rectangle const&, vcl::Window&) /sd/source/ui/view/drviewsh.cxx:61:11
>     #2 0x2b2059074b41 in sd::DrawView::MakeVisible(tools::Rectangle const&, vcl::Window&) /sd/source/ui/view/drawview.cxx:501:9
>     #3 0x2b207669a227 in SdrObjEditView::ImpMakeTextCursorAreaVisible() /svx/source/svdraw/svdedxv.cxx:1959:17
>     #4 0x2b20766e4ea4 in SdrObjEditView::SetAttributes(SfxItemSet const&, bool) /svx/source/svdraw/svdedxv.cxx:2171:13
>     #5 0x2b2076396e58 in SdrCreateView::SetAttributes(SfxItemSet const&, bool) /svx/source/svdraw/svdcrtv.cxx:868:16
>     #6 0x2b203f8d7b36 in SdrView::SetAttributes(SfxItemSet const&, bool) /include/svx/svdview.hxx:192:81
>     #7 0x2b203f8ab5a1 in SdMiscTest::testTdf99396TextEdit() /sd/qa/unit/misc-tests.cxx:215:9
>     #8 0x2b203f934ad8 in void std::_Mem_fn_base<void (SdMiscTest::*)(), true>::operator()<, void>(SdMiscTest*) const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:600:11
>     #9 0x2b203f9347e3 in void std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1073:11
>     #10 0x2b203f9341f1 in void std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)>::operator()<, void>() /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1131:11
>     #11 0x2b203f932bc9 in std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1871:2
>     #12 0x2b203f935550 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:2271:14
>     #13 0x2b203f931265 in CppUnit::TestCaller<SdMiscTest>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7
>     #14 0x2b1ff4edce7d in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
>     #15 0x2b20120c14d6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:48:14
>     #16 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
>     #17 0x2b20048ad7a6 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12
>     #18 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
>     #19 0x2b2000939e13 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16
>     #20 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
>     #21 0x2b1ff4e172df in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12
>     #22 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
>     #23 0x2b1ff4e91b70 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18
>     #24 0x2b1ff4f66ccb in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:10
>     #25 0x2b1ff4ed9efd in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:5
>     #26 0x2b1ff4ee00b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
>     #27 0x2b1ff4edf01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
>     #28 0x2b1ff4ee00b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
>     #29 0x2b1ff4edf01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
>     #30 0x2b1ff4fa6686 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:5
>     #31 0x2b1ff4f64e19 in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:3
>     #32 0x2b1ff4fa7b27 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:3
>     #33 0x515d6d in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:315:13
>     #34 0x51071f in sal_main() /sal/cppunittester/cppunittester.cxx:465:14
>     #35 0x50e832 in main /sal/cppunittester/cppunittester.cxx:372:1
>     #36 0x2b1ff6bdc444 in __libc_start_main (/lib64/libc.so.6+0x22444)
>     #37 0x433494 in _start (/workdir/LinkTarget/Executable/cppunittester+0x433494)

Change-Id: Idff283298ee2fa11467ff4b8604da642e5a09a8f
Reviewed-on: https://gerrit.libreoffice.org/56854Reviewed-by: Justin Luth <justin_luth@sil.org>
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I83a094b88c3ac31dc200a152e83ad7b8329418ad
Reviewed-on: https://gerrit.libreoffice.org/56848
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Fix a silly typo when determining if the page has a bottom margin

Change-Id: I96857951725d00978c43d850d0e1bc64ab61d965
Reviewed-on: https://gerrit.libreoffice.org/56602
Tested-by: Jenkins
Reviewed-by: Luke Deller <luke@deller.id.au>

Change-Id: I0df51b8dfd75dd966639d0893c379f2038c949ff

Change-Id: I1afae266a5308fa0dbf2488777ddb963e99199c7

instead of hack with hiding the window and showing it again (otherwise
modality change has no effect and worse yet, weird things happen)
it would be much easier to use QDialog

Change-Id: Ie7029ca66380495c4aad246d02f4b96cb55eb01e

Change-Id: If0e8d7307dd37436751e524d7ed24e89d5b72db3

Change-Id: Ib86ec0d297e23c02ad50ce1044859e029eae2ba9

Change-Id: Ie429074fdbe8fb4e28b1af47486bc70c5f8070e8

also factor some shared code out into separate func

Change-Id: I49d25eeb4eb647b72dae78c42301091d198eeff4

and not a regular file picker with wrong title

Change-Id: I849e7bb3d0cad197880fadd865f4d39f13245e97

the argument passed is an URL, so using setDirectory wouldn't do
the trick, setDirectoryUrl would

Change-Id: I312f6e2a06b46777dc126f95f63ec0dbcb1f5799

It is possible to cancel a mouse-down without a mouse-up
(for example with an ESC button).
So, cancel an obsolete "MouseSelecting" on mouse-down.

Change-Id: I37d641612cf2cd8099af8f04b12fdb364c4f9e24
Reviewed-on: https://gerrit.libreoffice.org/56857
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

This is really similar to c1676204
(tdf#117225 sfx2: fix leftover temp file when saving doc with embedded
objects, 2018-05-14), just this is save as, not save.

Change-Id: If78d91262bfbe97846287deb0794e4101ef7b4af
Reviewed-on: https://gerrit.libreoffice.org/56842Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins

It is 1024*1024 since b3579d71.

Change-Id: I7f523f21229de8f4fa378aa85f124863a67b21c8
Reviewed-on: https://gerrit.libreoffice.org/56843
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

As the leading std::nth_element() already partitions the vector,
all we have to do is to pick the minimum in its latter part.

Change-Id: I7767edc538819251c8fe9d26441ae57b06b2f865
Reviewed-on: https://gerrit.libreoffice.org/55575
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

Change-Id: Id6aad74198da68aa6475bcd3b17c993a51ccabe9
Reviewed-on: https://gerrit.libreoffice.org/56846
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...which removes a -Wdeprecated-copy (because the copy ctor is already not user-
declared) with GCC trunk towards GCC 9 (and makes SetColInfo unused).

Curiously, the user-provided copy assignment op didn't copy the eLang member,
but assume that was by accident rather than on purpose.

Change-Id: I3116500b748f0625acf1368d0106ade94f0dfa26
Reviewed-on: https://gerrit.libreoffice.org/56845
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

since we're replacing it completely anyhow.

which means we can remove DisconnectFromModel

Change-Id: I2f31d93eb95a641f3364d715111e70817c7e5087
Reviewed-on: https://gerrit.libreoffice.org/56849
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

...by default configuration.

Change-Id: If6075ae66537f613434dd38766324436f2426517
Reviewed-on: https://gerrit.libreoffice.org/56840
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: I4c7cc0f462fdd3ee2d2b44bc73f0313e6cd4176a
Reviewed-on: https://gerrit.libreoffice.org/56423
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ieacea4f6f53a0e55876a8b84d0dfeea8e308035d
Reviewed-on: https://gerrit.libreoffice.org/56712
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I8f2692a7f917b53c28783599b589fd0a39e3b880
Reviewed-on: https://gerrit.libreoffice.org/56835
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I0fed54d345a43fe0bc21ebbe424e6fdc7eac9523
Reviewed-on: https://gerrit.libreoffice.org/56823Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I9aaaeb2b5cb05d350059554555ecb0c195c51a74
Reviewed-on: https://gerrit.libreoffice.org/56830
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ia359ee8e9e4876f6bbf86702c476c9f9602295a0
Reviewed-on: https://gerrit.libreoffice.org/56832
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

and simplify, just use copy constructors and operator=, instead of
special-case CopyFrom methods

Change-Id: I3e14fa08e820cf7ae2c5424ae22ae95516933773
Reviewed-on: https://gerrit.libreoffice.org/56831
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I87f60bc3b6dc11246202801f39cbc7cf464e1890
Reviewed-on: https://gerrit.libreoffice.org/56829
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I0552a113a3eaf1265e65d32b2b04cc768571d9ff
Reviewed-on: https://gerrit.libreoffice.org/56827
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I678bfbc54a1c35540bb7f2b76f4f7e5c7c62b23c
Reviewed-on: https://gerrit.libreoffice.org/56826
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: Ibf9251880e658605e83179c9de7ac2104d2c1c14
Reviewed-on: https://gerrit.libreoffice.org/56825
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I83572646fb2ebe8afe8cff581e574375798e74f7
Reviewed-on: https://gerrit.libreoffice.org/56818Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

since they don't depend on SvTreeList at all

Change-Id: If48c83976a95943e5cfa92490d68f74281cf4b5f
Reviewed-on: https://gerrit.libreoffice.org/56819
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I049187432437a4bf2539fae54d44ad1266c54149
Reviewed-on: https://gerrit.libreoffice.org/56787
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>