1. 24 May, 2018 2 kayıt (commit)
    • Tor Lillqvist's avatar
      tdf#115284: Unify LibreOffice and system full-screen concepts on macOS · 4b42fd7e
      Tor Lillqvist yazdı
      Also tdf#76476, and probably more.
      
      Make it so that when a window is in full-screen mode from
      LibreOffice's point of view, it is also full-screen from the system's
      point of view, and vice versa.
      
      All three ways to enter and leave full-screen mode can now be used
      with the same end result: The Ctrl-Cmd-F shortcut, the "View > Full
      Screen" menu entry, and the green bubble on the title bar.
      
      Don't disable/deactivate/etc menus while in full-screen mode. The menu
      auto-hides so there is no harm in having it function normally.
      
      Don't display the floating toolbar with a single "Full Screen" button
      in it as the way to leave full-screen mode. Instead, the same three
      ways that can be used to enter full-screen mode work to leave it, too.
      
      Sadly I could not figure out a way to set a window properly to
      full-screen at the point where a document window is created and set to
      be the same size as that kind of document window was the previous time
      it was open in LibreOffice. Thus don't save state for full-screen
      windows as we can't properly restore them. At least not for macOS. It
      is not good to just restore them as non-full-screened but still at the
      size they had when full-screen.
      
      One irritating glitch remains, and I was unable to fix that properly:
      I now prevent closing the document window that is in full-screen mode.
      Otherwise, if it is closed, the full-screen mode remains even if no
      window is open there; the desktop is completely black. Moving the
      cursor to the top edge, the LibreOffice menu is there, though. I tried
      to fix that but with no fully satisfying result. (Some attempts even
      lead to crashes, so just disabling closing is better than crashing at
      least.)
      
      Change-Id: Id909077ef9de9f19d48c8b9ad10d748a65b2417f
      Reviewed-on: https://gerrit.libreoffice.org/54760Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarTor Lillqvist <tml@collabora.com>
      4b42fd7e
    • Caolán McNamara's avatar
      rework custom widget welding to enable inheritence · eeaf6dee
      Caolán McNamara yazdı
      Change-Id: I0d391b3fe9d2d610ae41e2a03cd2e195a866e103
      Reviewed-on: https://gerrit.libreoffice.org/54681Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      Tested-by: 's avatarCaolán McNamara <caolanm@redhat.com>
      eeaf6dee
  2. 23 May, 2018 1 kayıt (commit)
  3. 22 May, 2018 9 kayıt (commit)
    • Andrea Gelmini's avatar
      Fix typos · ba9b525e
      Andrea Gelmini yazdı
      Change-Id: I5ad14286712e27e8d15174c9ed420bf93367d041
      Reviewed-on: https://gerrit.libreoffice.org/54579Reviewed-by: 's avatarJulien Nabet <serval2412@yahoo.fr>
      Tested-by: 's avatarJenkins <ci@libreoffice.org>
      ba9b525e
    • Tor Lillqvist's avatar
      Bin pointless variable · c7736a68
      Tor Lillqvist yazdı
      Change-Id: I6b402b124966ee6a1694839a54e79fd176270d0f
      c7736a68
    • Tor Lillqvist's avatar
      Open template read-only · e4398162
      Tor Lillqvist yazdı
      Otherwise when creating a new docuent based on a template, the
      template document file is opened read-write eventually (after first
      being opened read-only five times, and closed again...). Sure,
      LibreOffice probably doesn't actually write anything to it, but still,
      just opening read-write when you are going to only read is silly.
      
      Stack trace from the read-write opening:
      
       #0  0x00007f063dea0047 in openFilePath(char const*, void**, unsigned int, unsigned int) (cpFilePath=0x7ffeacc7d610 "/ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", pHandle=0x342af78, uFlags=3, mode=438)
          at /ssd1/lo/fedora/sal/osl/unx/file.cxx:1039
       #1  0x00007f063dea027b in openFile(_rtl_uString*, void**, unsigned int, unsigned int) (ustrFileURL=0x33ff7e0, pHandle=0x342af78, uFlags=3, mode=4294967295) at /ssd1/lo/fedora/sal/osl/unx/file.cxx:1071
       #2  0x00007f063dea01a8 in osl_openFile(rtl_uString*, oslFileHandle*, sal_uInt32) (ustrFileURL=0x33ff7e0, pHandle=0x342af78, uFlags=3)
          at /ssd1/lo/fedora/sal/osl/unx/file.cxx:1050
       #3  0x00007f060aec5f1a in osl::File::open(unsigned int) (this=0x342af78, uFlags=3) at /ssd1/lo/fedora/include/osl/file.hxx:975
       #4  0x00007f060aec5a8f in fileaccess::ReconnectingFile::open(unsigned int) (this=0x342af78, uFlags=3)
          at /ssd1/lo/fedora/ucb/source/ucp/file/filrec.cxx:50
       #5  0x00007f060aee0324 in fileaccess::XStream_impl::XStream_impl(rtl::OUString const&, bool) (this=0x342af10, aUncPath="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", bLock=true) at /ssd1/lo/fedora/ucb/source/ucp/file/filstr.cxx:58
       #6  0x00007f060aee8bac in fileaccess::TaskManager::open_rw(int, rtl::OUString const&, bool) (this=0x2c5ded0, CommandId=231, aUnqPath="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", bLock=true)
          at /ssd1/lo/fedora/ucb/source/ucp/file/filtask.cxx:766
       #7  0x00007f060ae9ba9b in fileaccess::BaseContent::open(int, com::sun::star::ucb::OpenCommandArgument2 const&) (this=0x3428810, nMyCommandIdentifier=231, aCommandArgument=...) at /ssd1/lo/fedora/ucb/source/ucp/file/bc.cxx:937
       #8  0x00007f060ae99dfa in fileaccess::BaseContent::execute(com::sun::star::ucb::Command const&, int, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) (this=0x3428810, aCommand=..., CommandId=231, Environment=uno::Reference to (ucbhelper::CommandEnvironment *) 0x341d088) at /ssd1/lo/fedora/ucb/source/ucp/file/bc.cxx:331
       #9  0x00007f060ae9d001 in non-virtual thunk to fileaccess::BaseContent::execute(com::sun::star::ucb::Command const&, int, com::sun::star::uno::Reference<com::sun::star::ucb::XCommandEnvironment> const&) () at /ssd1/lo/fedora/instdir/program/../program/libucpfile1.so
       #10 0x00007f06337395da in ucbhelper::Content_Impl::executeCommand(com::sun::star::ucb::Command const&) (this=0x3427f70, rCommand=...)
          at /ssd1/lo/fedora/ucbhelper/source/client/content.cxx:1258
       #11 0x00007f063373be55 in ucbhelper::Content::openWriteableStream() (this=0x7ffeacc7f030)
          at /ssd1/lo/fedora/ucbhelper/source/client/content.cxx:751
       #12 0x00007f06333f56c0 in utl::MediaDescriptor::impl_openStreamWithURL(rtl::OUString const&, bool) (this=0x7ffeacc801d0, sURL="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", bLockFile=true)
          at /ssd1/lo/fedora/unotools/source/misc/mediadescriptor.cxx:666
       #13 0x00007f06333f3e01 in utl::MediaDescriptor::impl_addInputStream(bool) (this=0x7ffeacc801d0, bLockFile=true)
          at /ssd1/lo/fedora/unotools/source/misc/mediadescriptor.cxx:521
       #14 0x00007f06333f4051 in utl::MediaDescriptor::addInputStreamOwnLock() (this=0x7ffeacc801d0)
          at /ssd1/lo/fedora/unotools/source/misc/mediadescriptor.cxx:490
       #15 0x00007f05b132f0bf in filter::config::TypeDetection::impl_openStream(utl::MediaDescriptor&) (this=0x33caa10, rDescriptor=...)
          at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:1127
       #16 0x00007f05b132e9ac in filter::config::TypeDetection::impl_askDetectService(rtl::OUString const&, utl::MediaDescriptor&) (this=0x33caa10, sDetectService="com.sun.star.comp.filters.StorageFilterDetect", rDescriptor=...) at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:981
       #17 0x00007f05b132b7a4 in filter::config::TypeDetection::impl_detectTypeFlatAndDeep(utl::MediaDescriptor&, std::__debug::vector<filter::config::FlatDetectionInfo, std::allocator<filter::config::FlatDetectionInfo> > const&, bool, std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> >&, rtl::OUString&) (this=0x33caa10, rDescriptor=..., lFlatTypes=std::__debug::vector of length 168, capacity 256 = {...}, bAllowDeep=true, rUsedDetectors=std::__debug::vector of length 1, capacity 1 = {...}, rLastChance="")
          at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:934
       #18 0x00007f05b1329b7c in filter::config::TypeDetection::queryTypeByDescriptor(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, unsigned char) (this=0x33caa10, lDescriptor=uno::Sequence of length 6 = {...}, bAllowDeep=1 '\001')
          at /ssd1/lo/fedora/filter/source/config/cache/typedetection.cxx:429
       #19 0x00007f05b132d321 in non-virtual thunk to filter::config::TypeDetection::queryTypeByDescriptor(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&, unsigned char) () at /usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/bits/stl_pair.h:331
       #20 0x00007f060df5acdd in framework::LoadEnv::impl_detectTypeAndFilter() (this=0x7ffeacc80c48)
          at /ssd1/lo/fedora/framework/source/loadenv/loadenv.cxx:739
       #21 0x00007f060df58796 in framework::LoadEnv::startLoading() (this=0x7ffeacc80c48) at /ssd1/lo/fedora/framework/source/loadenv/loadenv.cxx:357
       #22 0x00007f060df57280 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Reference<com::sun::star::frame::XComponentLoader> const&, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (xLoader=uno::Reference to (framework::Desktop *) 0x282bf98, xContext=uno::Reference to (cppu::ComponentContext *) 0x145b790, sURL="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", sTarget="_default", nFlags=0, lArgs=uno::Sequence of length 4 = {...}) at /ssd1/lo/fedora/framework/source/loadenv/loadenv.cxx:160
       #23 0x00007f060dfaef40 in framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (this=0x282bf20, sURL="file:///ssd1/lo/fedora/instdir/share/template/common/officorr/Modern_business_letter_sans_serif.ott", sTargetFrameName="_default", nSearchFlags=0, lArguments=uno::Sequence of length 4 = {...})
          at /ssd1/lo/fedora/framework/source/services/desktop.cxx:617
       #24 0x00007f060dfaeffb in non-virtual thunk to framework::Desktop::loadComponentFromURL(rtl::OUString const&, rtl::OUString const&, int, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) () at /ssd1/lo/fedora/include/rtl/stringutils.hxx:170
       #25 0x00007f06381ee762 in SfxTemplateManagerDlg::OpenTemplateHdl(ThumbnailViewItem*) (this=0x310e160, pItem=0x33925d0)
          at /ssd1/lo/fedora/sfx2/source/doc/templatedlg.cxx:690
      
      Change-Id: Iaa5cc2bd4c80bc239b8f1bf7ed8aa62d89151d62
      e4398162
    • Samuel Mehrbrodt's avatar
      tdf#83877 Use Signer comments as signature description · 090e243c
      Samuel Mehrbrodt yazdı
      Change-Id: Ia9f18addeee9cf86989c873419113ddbd07c219f
      Reviewed-on: https://gerrit.libreoffice.org/54551Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarSamuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
      090e243c
    • Samuel Mehrbrodt's avatar
      tdf#83877 Add valid/invalid images to signatures · 6499ea2f
      Samuel Mehrbrodt yazdı
      Change-Id: I958c1bad2f32383ebaaeb7d42c761f0d1dfefc35
      Reviewed-on: https://gerrit.libreoffice.org/54513Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarSamuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
      6499ea2f
    • Samuel Mehrbrodt's avatar
      Don't pass ODF version, just retrieve it directly · 13596e70
      Samuel Mehrbrodt yazdı
      Change-Id: I19ff42c348515b17dac17abe750ee03ca53efcbf
      Reviewed-on: https://gerrit.libreoffice.org/54483Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarSamuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
      13596e70
    • Samuel Mehrbrodt's avatar
      Rename parameter bScriptingContent -> bSignScriptingContent · 99337b02
      Samuel Mehrbrodt yazdı
      Change-Id: I227e59417719625a9752e727060f5e4f5094092d
      Reviewed-on: https://gerrit.libreoffice.org/54479Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarSamuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
      99337b02
    • Samuel Mehrbrodt's avatar
      Simplify SignContents_Impl by moving readonly check to caller methods · 039117eb
      Samuel Mehrbrodt yazdı
      Change-Id: I95d9b12d7e1fc715363396e10bc4adc869978c44
      Reviewed-on: https://gerrit.libreoffice.org/54478Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarSamuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
      039117eb
    • Samuel Mehrbrodt's avatar
      Reduce indentation by returning early on error condition · c4409edb
      Samuel Mehrbrodt yazdı
      Change-Id: Iebf6eca68f0dcba87ab517952009ee6dfb4b588c
      Reviewed-on: https://gerrit.libreoffice.org/54475Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarSamuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
      c4409edb
  4. 21 May, 2018 3 kayıt (commit)
  5. 20 May, 2018 2 kayıt (commit)
  6. 18 May, 2018 3 kayıt (commit)
  7. 16 May, 2018 1 kayıt (commit)
  8. 15 May, 2018 2 kayıt (commit)
    • Samuel Mehrbrodt's avatar
      Sign Signature Line · 86e8cfdd
      Samuel Mehrbrodt yazdı
      This adds a new context menu entry "Sign Signature Line" to signature lines.
      You can directly sign the document from there.
      
      Still missing is the updating of the graphic to reflect the valid/invalid
      signature state.
      
      Change-Id: Ib8bc8c57f9d5370a10e379f86f9e41e57c715e3f
      Reviewed-on: https://gerrit.libreoffice.org/53778Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarSamuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
      86e8cfdd
    • Miklos Vajna's avatar
      tdf#117225 sfx2: fix leftover temp file when saving doc with embedded objects · c1676204
      Miklos Vajna yazdı
      Regression from 27938e1b (sfx2 store:
      create temp files next to local files (storage case), 2018-01-17), the
      optimization to store temp files during save next to the destination
      document (so that it can be renamed and not copied after writing the
      data successfully) causes problems when we have embedded objects.
      
      Avoid the problem by disabling this new optimization when the document
      has embedded objects.
      
      How to fix the actual root cause is not clear to me, I see that:
      
      - the SfxMedium::GetOutputStorage() call in
        SfxObjectShell::SaveTo_Impl() create a temp file
      - the SfxMedium::Commit() call in SfxObjectShell::SaveTo_Impl() tries to
        remove the file, which fails on Windows as there is an open file
        handle to that file
      - SfxObjectShell::SwitchChildrenPersistance() would close the storage,
        owning that open file handle, but it's too late
      
      So just go back to the previous behavior for now.
      
      Change-Id: I37259100d1ddf963c1f2d3b7bd9f460bc995815c
      Reviewed-on: https://gerrit.libreoffice.org/54340Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarMiklos Vajna <vmiklos@collabora.co.uk>
      c1676204
  9. 14 May, 2018 4 kayıt (commit)
  10. 10 May, 2018 2 kayıt (commit)
  11. 08 May, 2018 1 kayıt (commit)
  12. 07 May, 2018 5 kayıt (commit)
  13. 05 May, 2018 1 kayıt (commit)
  14. 04 May, 2018 4 kayıt (commit)