Change-Id: Ib4a1516cd57f165a072afad3505e3442714b2ff9
Reviewed-on: https://gerrit.libreoffice.org/72235
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>

/home/julien/lo/libreoffice/cppcanvas/qa/extras/emfplus/emfplus.cxx: In member function ‘void testFdo77229::TestBody()’:
/home/julien/lo/libreoffice/cppcanvas/qa/extras/emfplus/emfplus.cxx:79:46: error: ‘class BitmapColor’ has no member named ‘GetColor’; did you mean ‘getBColor’?
     Color aColor(pAccess->GetPixel(142, 140).GetColor());
                                              ^~~~~~~~
                                              getBColor

Change-Id: I7db2e678ddfadcbd55b3cb87613eeecb79d12ad5
Reviewed-on: https://gerrit.libreoffice.org/72253Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Tested-by: Jenkins

Change-Id: I68d3fac978531e780c16e4a41a619d7a6c00cabb
Reviewed-on: https://gerrit.libreoffice.org/72248
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I130839cbd400aad3f9f0691652df19e680346481
Reviewed-on: https://gerrit.libreoffice.org/72252Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I93cefdcf044854bb20a9524351548bb9721d393e
Reviewed-on: https://gerrit.libreoffice.org/72242
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I81d227fa99058ea0d13576d36897f186164b6ad6
Reviewed-on: https://gerrit.libreoffice.org/72251Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ie7861296de4d70dc03889212a359537d45a0c7bd
Reviewed-on: https://gerrit.libreoffice.org/72250
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

after
    commit a361231b
    Date:   Fri May 10 10:13:12 2019 +0200
    fix wrong SET/QUERY flags passed to uno::Reference

Change-Id: I1c01f185883b63294f190a147d5ca09a4f7c33e7

Passing a right edge co-ordinate to a width param, ever since
   commit 4849fb6d
   Date:   Mon May 10 14:47:20 2004 +0000
   INTEGRATION: CWS nwf (1.25.36); FILE MERGED

Probably only works because the button is on the right edge, and
consequently the width will be clamped to the widget area.

Change-Id: I28a88cd298bc5beb20162f457c7cc125e1d0303a
Reviewed-on: https://gerrit.libreoffice.org/72231
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

As described in QWidget doc [1], calling 'QWidget::winId()',
implicitly enforces a native window, i.e. one that has a
native window associated with it.
For this reason, avoid calling 'QWidget::winId()' for the Wayland
case. Quoting QWidget doc:
> Introduced in Qt 4.4, alien widgets are widgets unknown to the windowing
> system. They do not have a native window handle associated with them.
> This feature significantly speeds up widget painting, resizing, and
> removes flicker.

This in particular avoids tdf#122293/QTBUG-75766, which led to
'mousePressEvent's not being emitted unless a mouse button was pressed,
causing non-existent reaction to hovering over objects.

As a consequence to widgets being non-native by default on Wayland,
'Qt5Frame::windowHandle' needs to be adapted to make sure that the
widgets handled in there are native ones, otherwise no window handle
is associated with them.

Probably more needs to be done here to make video playback via GStreamer
work under Wayland, s.a. commit c0d4f3ad ("implement wayland handle
passing for gstreamer") for how it was done for gtk3.

With and without this change, slideshows with videos are currently not
handled properly with kde5 on Wayland (s. tdf#125219).

[1] https://doc.qt.io/qt-5/qwidget.html#native-widgets-vs-alien-widgets

Change-Id: Id46678e0ea594220a1765c3e59d39c41cb8bfe25
Reviewed-on: https://gerrit.libreoffice.org/72164
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

Change-Id: I7bdc959921ecb0cbf19037a78b63eaeb8fc52814
Reviewed-on: https://gerrit.libreoffice.org/72206
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

Change-Id: If9587bcf6b45dc7398d029171fdd018116dfa9b4
Reviewed-on: https://gerrit.libreoffice.org/72238Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

lo_runLoop() *is* used in the "Unipoll" case (i.e. current Online and
mobile apps).

Change-Id: I01ef3d8bc8140531f697952ef142150fc905a8d4

* Update helpcontent2 from branch 'master'
  - More detailed help of Calc's Sheet > Link to external data
    
    Make it more clear there has to be at least 1 named range in
    Excel of Calc documents
    
    Change-Id: I782c4d2c10ee52320bfdf147652883f5e7b4751a
    Reviewed-on: https://gerrit.libreoffice.org/72076
    Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
    

Change-Id: Iae494674972ced3d4808f57440757ae4ae6988f1
Reviewed-on: https://gerrit.libreoffice.org/70632
Tested-by: Jenkins
Reviewed-by: himajin100000 <himajin100000@gmail.com>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Andras Timar <andras.timar@collabora.com>

Change-Id: Ib43e7349bce04e42b247af3c87e0128350e6c1c1

and remove corresponding suppressions.

Change-Id: I0dd88082ee0af4c5ee82590e894305fa53574c6b
Reviewed-on: https://gerrit.libreoffice.org/72133
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Change-Id: Iedaa319b7a51bb5fdee7e57907cca61d2c70af2c
Reviewed-on: https://gerrit.libreoffice.org/72233Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

* Update translations from branch 'master'
  - update translations
    
    and force-fix errors using pocheck
    
    Change-Id: I2afa34705cebda561eb974fedf7a921666089f2b
    

BitmapColor itself is kept to distingish the Color usage as part
of a color palette, which continues to store the offset in the
blue value. The original special mbIndex handling is long gone
since commit 1fefdd6f ("Alpha channel in BitmapColor - change
bIndex to alpha"), so there is no data difference.

This also results in the following changes:

* now has a basic_ostream<charT, traits>& operator<<
  (that was my actual starting point... for an other bug fix)
* there is a minimal difference for GetLiminance
  BGR(29,151,76) => BGR(28,151,77)
* no more return values for Merge and Invert
  (previously returning *this)
* replaces all GetBlueOrIndex with GetIndex

This leaves one "problematic" part: the GetColorError handling.
At first glance it should probably be virtual. The Color variant
is less strict then the BitmapColor one - for whatever reason.
BitmapColor is always used to search for the best match in a
Palette. Currently I'm simply leaving both variants. Would be
nice to have an explict for functions here.

Change-Id: I251ba3024a1d60f2a9d9fde9cd0a60f08e8322a7
Reviewed-on: https://gerrit.libreoffice.org/72181
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

This showed up as a segfault for me.

Sometimes we have sortable items, for which we store duplicates (because
those items are not poolable), in which case comparing by operator==
means that we sometimes end up deleting the wrong one.

Change-Id: Ic7dff0357d3c5a7a74bf0b4e87fa02f2f5857f30
Reviewed-on: https://gerrit.libreoffice.org/72222
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I2013f36e5ccb2dda39ae2d1aa2e47eab8e072532
Reviewed-on: https://gerrit.libreoffice.org/72221
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

... which is quite unhelpful; any cast would have to make assumptions
about the size of types anyway...

Change-Id: I5f35d82eb35d1af36b5a572166cf863babf23d41
Reviewed-on: https://gerrit.libreoffice.org/72223
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: I3c9a3b73c099b70bdbd6b16688e83ee01231a27e
Reviewed-on: https://gerrit.libreoffice.org/72204
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Takes the time from 20s to 5s on my PC.

Change-Id: Iea7a94ee9fbe068b69a770fd9201e73646be59b9
Reviewed-on: https://gerrit.libreoffice.org/72140
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

caused by case-sensitive path handling of relationship files.

OOXML documents contain case-insensitive file paths, for example,
uppercase "Sheet.xml" can have a lowercase "sheet.xml.rels" in the ZIP
archive, as in the case of the XLSX documents generated by IBM Cognos.

Change-Id: I4210e3b96fb512d61e1687ec8d41a3c77292ec0c
Reviewed-on: https://gerrit.libreoffice.org/72100
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>

Change-Id: I0cc79534112ae8897a9887942238ff1236c4a3eb
Reviewed-on: https://gerrit.libreoffice.org/72217
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Iec71ca870db5f6aaf317e23db369dfc1fa04bcc1
Reviewed-on: https://gerrit.libreoffice.org/72205
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Add a SfxRedactionHelper::autoRedactPage method which searches for the given term
through the gdimetafile which has the whole content of an xPage (a Draw page),
and draws redaction rectangles at proper positions with proper sizes.

The search is case sensitive, and finds only the first occurences on a line.
Will switch to a proper search provider via a follow-up patch.

Change-Id: If3db62e50994670143785b6727fdcf1ccd4c6f8e
Reviewed-on: https://gerrit.libreoffice.org/68597
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

Qt generates three change events when changing the KDE theme:
FontChange, StyleChange and PaletteChange. LO has two:
SettingChanged and FontChanged. And like Qt LO will inform all
widgets / windows independently. To prevent several redraws,
this patch just collects all Qt's change events and notifies LO
once a bit later via a Timer.

Change-Id: I9b45f543f13a84e39247a642a0e33c9ec008a46a
Reviewed-on: https://gerrit.libreoffice.org/72196
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>

and thus the selected doc can't be used as the source of external
data for this sheet. In other words, help the user figure out
why is OK button disabled

Change-Id: Ie1b999c9c3640397e9f6f6ee321d3a5a5d63fa3b
Reviewed-on: https://gerrit.libreoffice.org/72075
Tested-by: Jenkins
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

A user pressing "next tip" will expect to cycle sequentially
through the list of tips, and not get a random one each time.

Change-Id: I331d35d623b6449a9daef407a498b4ba08eaff6f
Reviewed-on: https://gerrit.libreoffice.org/72099
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

This URL results in an error message and 0 results because "Changed" in
the UI translates to "delta_ts", not "changed" apparently.

Change-Id: I2bfdd682bb7fca229039970c209e7e409532059c
Reviewed-on: https://gerrit.libreoffice.org/72219Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

a frame that contained valid but unmodified document opened from
template or explicitly opened by the user (File > New) was treated
the same as blank document i.e. it was reused and the content was
overwritten by newly opened document (even if it already had
non-empty content provided by the template).

So let's not do that and let's open a new document in a new frame
instead

Change-Id: I10252d114e8cc5fcad3c98194ef07fd59873d6da
Reviewed-on: https://gerrit.libreoffice.org/71919
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I4ebebbbbad31b29c1e63a30685493042462bb52f
Reviewed-on: https://gerrit.libreoffice.org/71832
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

It has a number of static members, use m_ prefix only for non-static
members.

Change-Id: I312b1eaadd1a7d312d4679028446cf69362e4740
Reviewed-on: https://gerrit.libreoffice.org/72215Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

...to latest versions from <http://git.savannah.gnu.org/gitweb/?p=config.git;
a=blob_plain;f=config.guess;hb=HEAD> and <http://git.savannah.gnu.org/gitweb/?
p=config.git;a=blob_plain;f=config.sub;hb=HEAD>

but retain...

commit 25a09c87
Date:   Wed Jun 7 12:23:17 2017 +0200

    iOS, add support for arm64

    Added general support for arm64
    Removed experimental/prototype from normal build

Change-Id: Ic36a9fb9d20344ff0ddc6b293ed3bd48cf140a31
Reviewed-on: https://gerrit.libreoffice.org/72200
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Use comphelper::sequenceToContainer instead of ContainerHelper::SequenceToVector

Change-Id: I4834255a1349ac7a29127a84a54fcfa98d678d00
Reviewed-on: https://gerrit.libreoffice.org/72186
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

These tests has been implemented as a UITest in sw/qa/uitest/writer_tests5/xwindow.py

Change-Id: I0c1ae6d086a5a7d6e15b89bb3e810b49434da01e
Reviewed-on: https://gerrit.libreoffice.org/71950
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Icd8566c2fce1a0ff3fb9471afd71858ec2f91bc5
Reviewed-on: https://gerrit.libreoffice.org/71982
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>