Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 02 Nis, 2018 1 kayıt (commit)
  3. 01 Nis, 2018 1 kayıt (commit)
  5. 14 Mar, 2018 1 kayıt (commit)
  7. 02 Şub, 2018 1 kayıt (commit)
  9. 15 Ock, 2018 1 kayıt (commit)
  11. 12 Ock, 2018 1 kayıt (commit)
  13. 04 Ock, 2018 1 kayıt (commit)
  15. 27 Ara, 2017 1 kayıt (commit)
  17. 19 Ara, 2017 1 kayıt (commit)
  19. 11 Ara, 2017 1 kayıt (commit)
  21. 05 Ara, 2017 1 kayıt (commit)
  23. 27 Kas, 2017 1 kayıt (commit)
  25. 22 Kas, 2017 1 kayıt (commit)
  27. 20 Kas, 2017 1 kayıt (commit)
  29. 18 Kas, 2017 1 kayıt (commit)
  31. 23 Eki, 2017 2 kayıt (commit)
  33. 17 Eki, 2017 1 kayıt (commit)
  35. 16 Eki, 2017 1 kayıt (commit)
  37. 05 Eki, 2017 1 kayıt (commit)
  39. 04 Eki, 2017 1 kayıt (commit)
  41. 27 Eyl, 2017 1 kayıt (commit)
  43. 22 Eyl, 2017 1 kayıt (commit)
  45. 19 Eyl, 2017 1 kayıt (commit)
  47. 14 Eyl, 2017 1 kayıt (commit)
  49. 13 Eyl, 2017 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Enable -Wunreachable-code · 7f3ca309
      Stephan Bergmann yazdı 
      ...motivated by <https://gerrit.libreoffice.org/#/c/41565/2> adding dead code
at the end of a switch statement, after the last case's "break".

-Wunreachable-code appears to work well on Clang, while it appears to have no
effect on GCC.

Most of the affected places are apparently temporary/TODO/FIXME cases of
disabling code via "if (false)", which can be written with an extra set of
parentheses as "if ((false))" to silence -Wunreachable-code on Clang (which thus
needed loplugin:unnecessaryparen to be adapted accordingly).  In some cases,
the controlling expression was more complex than just "false" and needed to be
rewritten by taking it out of the if statement to silence Clang.

One noteworthy case where the nature of the disabled code wasn't immediately
apparent:

  Sep 12 16:59:58 <sberg> quikee, is that "if (false)" in
   ScExponentialSmoothingDialog::ApplyOutput
   (sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx) some work-in-
   progress or dead code?
  Sep 12 17:02:03 <quikee> sberg: WIP, but you can remove it
  Sep 12 17:04:47 <sberg> quikee, I'll wrap the false in an extra set of
   parentheses for now, to silence -Wunreachable-code (I wouldn't want to
   remove it, as I have no idea whether I should then also remove the "Initial
   value" comment preceding it)
  Sep 12 17:07:29 <quikee> sberg: both are different ways to calculate the
   "intital value"... so no

Another case where the nature of the dead code, following while (true) loops
without breaks, is unclear is sd/source/ui/remotecontrol/BluetoothServer.cxx,
where I added TODO markers to the workarounds that silence the warnings for now.

basic/source/sbx/sbxvalue.cxx had a variable of type double, of automatic
storage duration, and without an initalizer at the top of a switch statement.
Clang warning about it is arguably a false positive.

Apart from that, this didn't find any cases of genuinely dead code in the
existing code base.

Change-Id: Ib00b822c8efec94278c048783d5997b8ba86a94c
Reviewed-on: https://gerrit.libreoffice.org/42217Tested-by: 's avatarStephan Bergmann <sbergman@redhat.com>
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      7f3ca309
  51. 06 Eyl, 2017 1 kayıt (commit)
  53. 25 Agu, 2017 2 kayıt (commit)
  55. 11 Agu, 2017 2 kayıt (commit)
  57. 02 Agu, 2017 1 kayıt (commit)
  59. 14 Tem, 2017 1 kayıt (commit)
  61. 13 Tem, 2017 1 kayıt (commit)
  63. 11 Tem, 2017 1 kayıt (commit)
  65. 10 Tem, 2017 1 kayıt (commit)
  67. 05 Tem, 2017 1 kayıt (commit)
  69. 03 Tem, 2017 1 kayıt (commit)
    • Jochen Nitschke's avatar
      C++11 remove std::unary_function bases from functors · c4ddf6cd
      Jochen Nitschke yazdı 
      std::unary_function is deprecated since C++11 and removed in C++17

90% done with regexp magic.
removed obsolete <functional> includes.

The std::unary_function base class was used in 3 places:
* chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole
   is used in a std::not1 function helper who uses the members
   return_type and argument_type.
   - replace deprecated std::not1 with a lambda
* chart2/source/tools/ModifyListenerHelper.cxx:
   lcl_weakReferenceToSame used the argument_type member in the
   operator() parameter.
   - inline the parameter type.
* xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement
   used result_type and argument_type in operator().
   - inline the types

Also fix compile error with gcc about finding std::for_each.

Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f
Reviewed-on: https://gerrit.libreoffice.org/39358Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
Tested-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      c4ddf6cd
  71. 02 Tem, 2017 2 kayıt (commit)