Bring White option to the first place,
to save toner on print as users tend to
click on the first option.

Change-Id: Id63c4402f8dc07a83eef69c3dfde3dd086c899b8
Reviewed-on: https://gerrit.libreoffice.org/70831
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>

Otherwise it's quite annoying to miss e.g. a typo in the shader code
if the code falls back to another way of handling the operation.

Change-Id: I585be85f739929f0f422dc031a36dc83077f6820
Reviewed-on: https://gerrit.libreoffice.org/70771
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Apparently link.exe is a wrapper for either a dynamic linker for .exe
and .dll files, or for an archiver for .lib files, and the latter
doesn't know -debug and complains about it.

eeeec33a made it to be passed to all linking.

Change-Id: Ie4b16536f705987de432fc8e2819467fc5bfb719
Reviewed-on: https://gerrit.libreoffice.org/70817
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Also include/ucbhelper had some false positives not yet on the blacklist

Change-Id: I4500271ea35efd7e140c76255df95ff7bbdf9f27
Reviewed-on: https://gerrit.libreoffice.org/70745
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

...as used as an identifier in sw/inc/swundo.hxx (broke Windows --disable-pch
builds)

Change-Id: I4de0232bcf17c4149cc31ec235f1275648a6d73e
Reviewed-on: https://gerrit.libreoffice.org/70820
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I64662a4020ea402477af33d61d8db0ee062ebe46
Reviewed-on: https://gerrit.libreoffice.org/70819
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

nLen may be larger than the master SwTextFrame, but its follow can't
have negative offset.

(regression from 0acde751)

Change-Id: I6177c748480cdf61e8f15a7032ba52d3ae2ea52c
Reviewed-on: https://gerrit.libreoffice.org/70816
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

By implementing btlr support in
SwTextFrame::SwitchVerticalToHorizontal(SwRect), so not only
invalidation but paint rectangle is also correct, which means actual
text painting happens.

Change-Id: I4215799ff63c93b300e4e8f97c6824f75d7c5401
Reviewed-on: https://gerrit.libreoffice.org/70797
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>

Greyscale conversion with OpenGL results in RGB values sometimes
having color components one off compared to the normal VCL values,
so be a bit lenient.

Change-Id: I58c279fb90e540cd2ac76d4217c774ff09229051
Reviewed-on: https://gerrit.libreoffice.org/70778
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Related to tdf#105277, check that scaling a bitmap with different
scale methods and different bitmap sizes produces (roughly)
the expected results.

Change-Id: Iea9be675b7cc4b0fbbc634501d32ded82bccbb17
Reviewed-on: https://gerrit.libreoffice.org/70775
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

With a texture atlas the "texture" is just a subtexture of a larger texture,
so texture coordinates are not the full range between 0 and 1, but just
a part of it. Since areaScaleFragmentShader converts between pixel
and texture coordinates, the conversion needs to take this into account.

Change-Id: I9d29ffea52551d19ba681971a2b4f140a35b491c
Reviewed-on: https://gerrit.libreoffice.org/70774
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

The bitmaps have different CRC, because OpenGL uses different algorithm
and data format.

Change-Id: Ic4d2e6215cfc6b971b470367002936f4a81e9fbe
Reviewed-on: https://gerrit.libreoffice.org/70777
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

So that textures do not start with random uninitialized contents.

Change-Id: Ie240f5f71ed77d5c6c22a120e96540a2d0d7c2ed
Reviewed-on: https://gerrit.libreoffice.org/70773
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Windows uses GL_BGRA, but e.g. on Linux OpenGL stores as GL_RGBA.

Change-Id: I00820f7b7a16a54b10c682ba332627ec04648508
Reviewed-on: https://gerrit.libreoffice.org/70772
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

BitmapTest::testScale2() on Linux fails for me without this,
as the two-pass setup higher truncates the size to integers, and
truncating here again sets the final size as 64 instead of the expected 65

Change-Id: I54748e29f0e0ca63539e42009759a93d6a5d6be2
Reviewed-on: https://gerrit.libreoffice.org/70779
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

The two blocks are identical.

Change-Id: I58464160009d1276bd1ca92482cd677c00471251
Reviewed-on: https://gerrit.libreoffice.org/70776
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Without this, building a unittest does not rebuild those if needed.

Change-Id: If15aa2e1d7869d274c8c5f885278e85e0a341c47
Reviewed-on: https://gerrit.libreoffice.org/70770
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Change-Id: I8e08efb549ebd52c37183a1185d6de73f2b00601
Reviewed-on: https://gerrit.libreoffice.org/64630Reviewed-by: himajin100000 <himajin100000@gmail.com>
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Tested-by: Michael Stahl <Michael.Stahl@cib.de>

Change-Id: If280e1e944c877462cb84b579e19d4fd2ad1900b
Reviewed-on: https://gerrit.libreoffice.org/70813
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I57e11d45aad48713b7c6802e2b6976fd916fc6ba
Reviewed-on: https://gerrit.libreoffice.org/70717
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

If a 'ooxml-foo' shape has a path internal coordinate system by
using w and h attribute, the position of the handle was out of
place. Because in 'ooxml-foo' shapes the handle position is not
directly connected to the adjustment value but via formulas, the
handle position is already scaled when calculating the position.

Change-Id: I84ef8c5ea3bbe94a1bfd9d8ba17b97248086234f
Reviewed-on: https://gerrit.libreoffice.org/70783
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>

This adds an test for a VirtualDevice with an alpha channel,
which checks that getting a BitmapEx from the alpha VirtualDevice
is has a alpha channel properly set.

Test that using GetPixel and DrawPixel properly handle an alpha
based Color, which they didn't, so this also includes the fix for
thouse 2 methods.

Change-Id: I419b8e0f66ab5f8266c6129e501ed75ef517fd44
Reviewed-on: https://gerrit.libreoffice.org/70805
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I78bafe3d4714f62430ad7634e499f5472879df03
Reviewed-on: https://gerrit.libreoffice.org/70811Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

... due to change of default argument; the XHTML export is calling it
from SwXTextPortion::getString().  This is complicated a bit by a
bunch of changes to GetExpandText() callers.

(regression from bf488abb)

Change-Id: I0b1e10e17c8f3824d6fa1f21fc74cc59b310474f
Reviewed-on: https://gerrit.libreoffice.org/70791
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

since...

commit 4c4d9a48
Date:   Sun Apr 14 16:41:42 2019 +0200

    loplugin:sequentialassign in vcl

Change-Id: I55e47ab919757486e5eeaefea857df9578924cd2
Reviewed-on: https://gerrit.libreoffice.org/70807
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

srand() added, image file name part of the hrc definition now

Change-Id: Ib697f64406ab6b11468eb837c71d57398a0533b5
Reviewed-on: https://gerrit.libreoffice.org/70767
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>

Excel expects the group field items to be in ascending order starting
from "<01/02/2010", then "Jan", "Feb", ..., then end with ">01/02/2020".

Change-Id: I29e9b55f43091ed007f59e10dec64f46a37c7d5f
Reviewed-on: https://gerrit.libreoffice.org/70800
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

This adds a test for drawing a BitmapEx which has an alpha channel
onto a VirtualDevice. Most important is that alpha blending is
done as we expect it (but it is prone to rounding error).

Change-Id: I41a16ca9da98d7a067ada9aafad8c9fc7c6484d5
Reviewed-on: https://gerrit.libreoffice.org/70804
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I0c1b8447acd6681d8731c35412b90a00741274fa
Reviewed-on: https://gerrit.libreoffice.org/70803
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

This (finally) adds backend tests as CPPUNIT tests too. In the
future they'll also be added into LibreOffice directly as a way
to test if the backend is OK, which will be useful especially
for the OpenGL backend, which draw quality depends on the driver.

Currently all the tests are ignored because of the bugs in the
backend, which need to be addressed first and tests then can
be enabled one by one.

The main reason for the test is to identify issues when drawing
is done at a wrong position, which is a very common problem. Also
other types of tests will be added in time, which will have a big
role in the refactoring of VCL that will happen in the future.

Change-Id: I92237d47d49fa0db01b73b8bc39f7a621b65961e
Reviewed-on: https://gerrit.libreoffice.org/70769
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

Change-Id: I4cc228db3edcacfb2f0b60c03a7eac0930a288f8
Reviewed-on: https://gerrit.libreoffice.org/70782
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: If382f0419c8ea0a3b99c85942c05ee1e5a627e76
Reviewed-on: https://gerrit.libreoffice.org/70795Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Id8b6f11b4429c8029cacfc26592767625efb9674
Reviewed-on: https://gerrit.libreoffice.org/70798
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I6eb682acd0616162837809a9f89dfb2c66efb505
Reviewed-on: https://gerrit.libreoffice.org/70787
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I4b6f5ea60cebf465cd3c47909f10aae9281d63c0
Reviewed-on: https://gerrit.libreoffice.org/70789
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I2d94a7cf6fbaea952f9d802307202648587189f3
Reviewed-on: https://gerrit.libreoffice.org/70784
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I339c5a0777477c16ee85ace91e3611af40c06e31
Reviewed-on: https://gerrit.libreoffice.org/70781
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: I9e31f78a3d2d811088162f9dbac7fc92abf12c19
Reviewed-on: https://gerrit.libreoffice.org/70780
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>

Change-Id: Ie57c34eff1d917fada4e10e4b88b27adf8a34d1a
Reviewed-on: https://gerrit.libreoffice.org/70788
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

document"

Change-Id: I976318fe299306b65190b4f5ae0ed2565830c6f7
Reviewed-on: https://gerrit.libreoffice.org/70475
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>