Did half the file.  Need comments before I finish the rest.

Change-Id: Idbd98277e908dc568008925611ab1fd1fb778ab1
Signed-off-by: Michael Stahl <mstahl@redhat.com>

Change-Id: I2455476a876012051ca1651721915243503fbb22
Reviewed-on: https://gerrit.libreoffice.org/19308Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

The problem is that the precompiled headers' dependency files are not
run through concat-deps, hence they directly refer to headers of
external libraries' headers, which are not targets in the build system;
therefore re-building an external library does not cause the dependent
PCH to re-build and (at least with MSVC) the object files don't depend
on headers included via PCH anyway, so we get the recent link failure
in comphelper with MSVC, which wasn't rebuilt for icu's ABI change.

To fix that just use concat-deps, which re-writes header dependencies to
UnpackedTarball target dependencies.

Change-Id: Ic7555822925aaa1ff09b29bb73801fb83923bfab

Replacing the placeholder ones.

Change-Id: I4289cb9c57181d98bf9f92b194661c965d213d1c

Change-Id: Ibc66c414813240b61491744166bfc6e0d898a54e
Reviewed-on: https://gerrit.libreoffice.org/19521Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

Change-Id: Ica252d3477e3a630777a59d64bfea7afb29351cd

Also, closeDoc() is called by tearDown(), so no need to call it manually
at the end of tests.

Change-Id: Ib8f61a09fa3fc0885d7ea90ce96210bff4cc9f98

Change-Id: If50b4b5baea36e161675afd368fc54bdec01d9a5

Change-Id: I8bc7316d9304d9e764ee846fe3af34599bf6fc35

...same as daa6fe41

Change-Id: I0ee61a2f40c234fcb496a70ad5ec913148119597

...same as 8fb3808f

Change-Id: If21d6bbf5f88b8ca5ed5387d98b2dd9c74f0e32c

Change-Id: Icbe775e59d66efbb994a73c00024f9f7750f9ef0

Change-Id: I3a618bd02994437a1dbe048e43653056006e8d4b

Also, sort the cases in the switch in numeric order for clarity.

Change-Id: Ic32da29a78b3aeedf22ee5f646a0975e4cbcb9cc

Change-Id: I1ddfd8f7ee779a87825345bf29feb14150713cbc

...as null values are handled just fine by compare()

Change-Id: Ifd17b96187ad3d13be99b107d3c3fa47e51b586e

Change-Id: I50b4dfa456d3518f5ef7faf5f634642973441a3e

Change-Id: I34998229e7f5cac4c62c859861783be3c161f9bf

Change-Id: I9d0fad3904e74b44b0b126974ace4025f7a4fc5b

Change-Id: I385f64b7d5015c9a34f34a436b0ee2ce6b3a83d3

Change-Id: I6175b4b28af3257f5734685b8fa323f0b9078512

When the property type is e.g. a UNO sequence or struct type, !equals would
trivially be always true (as the UNO bridge creates fresh instances of such
value types on the fly), masking failures where the tested code didn't change
the property value at all.

And one such masked failure was
sw.CharacterStyle::com::sun::star::style::CharacterProperties in
JunitTest_sw_unoapi_1 not changing any of the CharLeft/Right/Bottom/TopBorder
properties, as SvxBorderLine::GuessLinesWidths
(editeng/source/items/borderline.cxx) appears to only work properly if nStyle is
DOUBLE, so work around that for now by explicitly setting that BorderLineStyle
in the ValueChanger for BorderLine2.

Change-Id: If9536822c5db04cbd01e6d760b5b63da04c4cf5b

...lcl_SetTableSeparators (sw/source/core/unocore/unotbl.cxx) when trying to
change the TableColumnSeparators property of
sw.SwXTextTable::com::sun::star::text::TextTable in JunitTest_sw_unoapi_4

Change-Id: I314e3f08eae0b1df6d5c60340e33f34477daf76e

Change-Id: Ib585408c26e14b83e896861c2793ff3229dba7d1

Change-Id: I84cb3bb1e3fa42a7b96286f317aa0fb4e8ada8f3

Change-Id: I50b9df6a428bd2ddb57819a9da6f07df346e7e61

Change-Id: Ie2b338bdd75f26953c758b64711e60b6f5ce9c83

...if all we want to verify is that resValue == newValue (and it is the test
code's responsibility to come up with a newValue != oldValue, but which might
sometimes not be possible)?

Change-Id: Ibfce322b50bb0074ca76c33ad0c83541a8d4dc41

...claiming that "right shifting v by more than 15 bits always yields zero,"
apparently diagnosing an instanatiation of the template for T = unsigned short.

Change-Id: I7c210ff17e4aef8f0e703cc30518f3420e67e7c1

Change-Id: I60874ab8d3cc9adaea8757d6888e341accce2083
Reviewed-on: https://gerrit.libreoffice.org/19494Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ib217c24614d09817e4d7f8c545bd75345250a874
Reviewed-on: https://gerrit.libreoffice.org/19493Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: I05c314b6eb460cfcbaa7d13cae21360ce6824624
Reviewed-on: https://gerrit.libreoffice.org/19492Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ia973799453d9ede60be3699ff8973e31605f06ef

Change-Id: I8437c69ee35f766b2c35198f8b99ac2779251e05

Change-Id: Iad3c970b263b8ee847cf6a7d2e05c5336cad9b26

Change-Id: Iac98463066f4a21d70e82dfc5c85f061d5ae6603

Change-Id: Ic2865ff81a79b0d96b950b310723262959d080b5

Change-Id: Ib3a1ccda738091466d5e2866823f64b254ed5bab

Change-Id: I62fe627eab0163715fc90d17a9b8992bc17682b9

Change-Id: I059248659f51746cfc1d06faeaadaf3d645c03d3