Kayıtlar (commit) · d45bf5e20e5abc2dcf5ea3d3be06aa61d92c762e · LibreOffice / core

29 Ock, 2016 1 kayıt (commit)

cid#1326280, 1326295, 1326303 · 3c28a0e3

jan iversen Ock 25, 2016 yazdı

null pointer dereference, made test

Change-Id: I2bd820a2eb04499ab3b518d5b5e5ccccf3ffe531
Reviewed-on: https://gerrit.libreoffice.org/21771Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>

3c28a0e3

12 Ara, 2014 1 kayıt (commit)

java: remove dead code in qadevOOo · 117a82cd

Noel Grandin Ara 11, 2014 yazdı

found by running UCDetector over the code many times, like peeling
an onion

Change-Id: I54d5147eb1b5c921ad236331bc4c1f765b13ca83
Reviewed-on: https://gerrit.libreoffice.org/13445Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

117a82cd

11 Ara, 2014 2 kayıt (commit)

java: remove some unnecessary interfaces · 373affe5

Noel Grandin Ara 11, 2014 yazdı

Change-Id: Ie2da7cbbd1733881ff2da6fa095c37c21cf19fe8
Reviewed-on: https://gerrit.libreoffice.org/13435Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

373affe5

java: reduce visibility of fields and methods · 7557f23b

Noel Grandin Ara 10, 2014 yazdı

found by PMD

Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

7557f23b

05 Ara, 2014 1 kayıt (commit)
- java: remove some comment noise · 77162432
  Noel Grandin Ara 05, 2014 yazdı
```
Change-Id: I51118fecf9de27407b4c5a66cd6577574939e001
```
  77162432
25 Kas, 2014 1 kayıt (commit)

java: final fields that can be static · 58eab576

Noel Grandin Kas 18, 2014 yazdı

found by PMD

Change-Id: I2b48f35d252d6e914c2a18a2c175b075a9d3ac0f
Reviewed-on: https://gerrit.libreoffice.org/13099Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

58eab576

18 Kas, 2014 1 kayıt (commit)
- java: make fields final where possible · 0063cf28
  Noel Grandin Kas 18, 2014 yazdı
```
found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
```
  0063cf28
12 Kas, 2014 1 kayıt (commit)

java: convert fields to local variables where possible · bb437029

Noel Grandin Kas 12, 2014 yazdı

found by PMD

Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

bb437029

25 Eki, 2014 1 kayıt (commit)

java: prevent overflow by using 'long int' arithmetic in multiplication · e61c4b5f

Robert Antoni Buj i Gelonch Eki 16, 2014 yazdı

Change-Id: I8dda8f4621f265208c713c9edcfe725f1c9c5998
Reviewed-on: https://gerrit.libreoffice.org/12001Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

e61c4b5f

17 Eki, 2014 1 kayıt (commit)
- java: no need to call String.valueOf to append to a String · 12b01b92
  Noel Grandin Eki 16, 2014 yazdı
```
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
```
  12b01b92
16 Eki, 2014 1 kayıt (commit)
- java: when rethrowing, store the original exception · 5cba8d44
  Noel Grandin Eki 16, 2014 yazdı
```
Change-Id: Idfca83a2a646acab90886c0ef9c30dd7d2fc8b53
```
  5cba8d44
14 Eki, 2014 1 kayıt (commit)

runner: finally block to ensure that a resource is closed (Prior to Java SE 7) · a2c48145

Robert Antoni Buj i Gelonch Eki 13, 2014 yazdı

http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html

Change-Id: I5ecefd3e5bf84fea2a8735a44236ed4c86b440c4
Reviewed-on: https://gerrit.libreoffice.org/11950Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

a2c48145

13 Eki, 2014 2 kayıt (commit)

java: Collections.addAll for adding an array of elements to a Collection · d0be30e8

Robert Antoni Buj i Gelonch Eki 13, 2014 yazdı

Change-Id: I4689aa73e1e261c6461e04b9e814ffefa5817c09
Reviewed-on: https://gerrit.libreoffice.org/11953Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

d0be30e8

runner: Object comparison · 5233d9b8

Robert Antoni Buj i Gelonch Eki 11, 2014 yazdı

Change-Id: I41b245f20652187dc36b4639272d0ddbc602afda
Reviewed-on: https://gerrit.libreoffice.org/11921Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

5233d9b8

10 Eki, 2014 1 kayıt (commit)

runner: The if statement is redundant · 110ae4e4

Robert Antoni Buj i Gelonch Eki 09, 2014 yazdı

Change-Id: Ida40034bdfe6a44a936db1243ad6c71616caada3
Reviewed-on: https://gerrit.libreoffice.org/11895Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

110ae4e4

07 Eki, 2014 3 kayıt (commit)
- java: use isEmpty() instead of "size() == 0" · 68fa1410
  Noel Grandin Agu 21, 2014 yazdı
```
Change-Id: I23e1038246999b0744d8e9ae83b66fa1f7dafa99
```
  68fa1410
- java: use equalsIgnoreCase() instead of toLowerCase().equals() · 81968336
  Noel Grandin Agu 21, 2014 yazdı
```
Change-Id: I8f4afc7e15a9d85d99ea80edbbbd2b507b254ddc
```
  81968336
- java: simplify conditions involving logical negation · dc53e302
  Noel Grandin Agu 20, 2014 yazdı
```
Change-Id: Ib45e58273e650ef9a31dbdb5f71e995a5976f50e
```
  dc53e302
10 Eyl, 2014 2 kayıt (commit)

qadevOOo: Number Parsing · dcd5aa95

rbuj Eyl 09, 2014 yazdı

Change-Id: I284a1b2bcb61695b74ec51bb46cbb683abf83449
Reviewed-on: https://gerrit.libreoffice.org/11369Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

dcd5aa95

qadevOOo: use a character literal · e8ac22f3

rbuj Eyl 09, 2014 yazdı

Change-Id: I6d3e592de64c63e66bb788b112e188ef217e7bf7
Reviewed-on: https://gerrit.libreoffice.org/11367Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

e8ac22f3

20 Agu, 2014 5 kayıt (commit)
- java: remove unnecessary constructor declarations · c0415d5f
  Noel Grandin Agu 15, 2014 yazdı
```
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor

Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
```
  c0415d5f
- java: remove modifiers implied by the context · 8c9fdc4a
  Noel Grandin Agu 13, 2014 yazdı
```
found by PMD

Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
```
  8c9fdc4a
- java: avoid if..else when returning boolean values · a753a458
  Noel Grandin Agu 13, 2014 yazdı
```
Change-Id: Iab52762a9abfe8735223372b09638ce9d8d44318
```
  a753a458
- java: avoid unnecessary comparisons in boolean expressions · 60f152ca
  Noel Grandin Agu 13, 2014 yazdı
```
i.e. stuff like "x == true"

Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
```
  60f152ca
- java: Avoid naming non-fields with the prefix m_ · 2922a967
  Noel Grandin Agu 13, 2014 yazdı
```
found by PMD

Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1
```
  2922a967
19 Agu, 2014 3 kayıt (commit)
- java: use Boolean.valueOf instead of instantiating Boolean objects · be1bb7b1
  Noel Grandin Agu 12, 2014 yazdı
```
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
```
  be1bb7b1
- java: classes in java.lang package do not need to be fully qualified · 56ef5533
  Noel Grandin Agu 19, 2014 yazdı
```
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
```
  56ef5533
- java: remove unused methods · 3a8d3519
  Noel Grandin Agu 12, 2014 yazdı
```
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
```
  3a8d3519
14 Agu, 2014 2 kayıt (commit)
- java: remove unused imports · 0d916bb2
  Noel Grandin Agu 12, 2014 yazdı
```
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
```
  0d916bb2
- java: remove commented out code · ac5954d7
  Noel Grandin Agu 11, 2014 yazdı
```
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
```
  ac5954d7
13 Agu, 2014 5 kayıt (commit)
- remove dead java constants · 5ce80c97
  Noel Grandin Agu 11, 2014 yazdı
```
found by UCDetector

Change-Id: I1f8f5ba4f3ab1a1ef134dd0988f913dab7501351
```
  5ce80c97
- java: remove dead methods · 34bcf9b4
  Noel Grandin Agu 13, 2014 yazdı
```
found by UCDetector

Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
```
  34bcf9b4
- java: remove unused fields · 8583da1e
  Noel Grandin Agu 12, 2014 yazdı
```
found by UCDetector

Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
```
  8583da1e
- java: reduce scope, make some methods private · 68cd011c
  Noel Grandin Agu 08, 2014 yazdı
```
found by UCDetector

Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
```
  68cd011c
- java: reduce scope, make fields private · da677dfd
  Noel Grandin Agu 08, 2014 yazdı
```
found by UCDetector

Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
```
  da677dfd
12 Agu, 2014 4 kayıt (commit)
- java: reduce scope, make constants private · e701b3f7
  Noel Grandin Agu 08, 2014 yazdı
```
found by UCDetector

Change-Id: Ide9975e361ed17ac8cdcbe67ba74c563a9392d57
```
  e701b3f7
- java: return value of trim() ignored · 98519259
  Noel Grandin Agu 07, 2014 yazdı
```
Change-Id: If4cd3eb3e6db0c095796b0ff018162e855afa38c
```
  98519259
- java: remove useless javadoc tags · 1c496506
  Noel Grandin Agu 07, 2014 yazdı
```
that are not conveying any useful information

Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
```
  1c496506
- java: add @Override annotation to overriding methods · 0477e6c3
  Noel Grandin Agu 06, 2014 yazdı
```
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
```
  0477e6c3
11 Agu, 2014 1 kayıt (commit)
- java: remove unused parameters · d5a31b22
  Noel Grandin Agu 06, 2014 yazdı
```
Change-Id: Ifc44c51ddbd21fabaad686bc3d38e2dab54d97aa
```
  d5a31b22