- 13 May, 2019 26 kayıt (commit)
-
-
Jan-Marek Glogowski yazdı
BitmapColor itself is kept to distingish the Color usage as part of a color palette, which continues to store the offset in the blue value. The original special mbIndex handling is long gone since commit 1fefdd6f ("Alpha channel in BitmapColor - change bIndex to alpha"), so there is no data difference. This also results in the following changes: * now has a basic_ostream<charT, traits>& operator<< (that was my actual starting point... for an other bug fix) * there is a minimal difference for GetLiminance BGR(29,151,76) => BGR(28,151,77) * no more return values for Merge and Invert (previously returning *this) * replaces all GetBlueOrIndex with GetIndex This leaves one "problematic" part: the GetColorError handling. At first glance it should probably be virtual. The Color variant is less strict then the BitmapColor one - for whatever reason. BitmapColor is always used to search for the best match in a Palette. Currently I'm simply leaving both variants. Would be nice to have an explict for functions here. Change-Id: I251ba3024a1d60f2a9d9fde9cd0a60f08e8322a7 Reviewed-on: https://gerrit.libreoffice.org/72181 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
-
Noel Grandin yazdı
This showed up as a segfault for me. Sometimes we have sortable items, for which we store duplicates (because those items are not poolable), in which case comparing by operator== means that we sometimes end up deleting the wrong one. Change-Id: Ic7dff0357d3c5a7a74bf0b4e87fa02f2f5857f30 Reviewed-on: https://gerrit.libreoffice.org/72222 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
heiko tietze yazdı
Change-Id: I2013f36e5ccb2dda39ae2d1aa2e47eab8e072532 Reviewed-on: https://gerrit.libreoffice.org/72221 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
-
Michael Stahl yazdı
... which is quite unhelpful; any cast would have to make assumptions about the size of types anyway... Change-Id: I5f35d82eb35d1af36b5a572166cf863babf23d41 Reviewed-on: https://gerrit.libreoffice.org/72223 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
-
Caolán McNamara yazdı
Change-Id: I3c9a3b73c099b70bdbd6b16688e83ee01231a27e Reviewed-on: https://gerrit.libreoffice.org/72204 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Noel Grandin yazdı
Takes the time from 20s to 5s on my PC. Change-Id: Iea7a94ee9fbe068b69a770fd9201e73646be59b9 Reviewed-on: https://gerrit.libreoffice.org/72140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Balazs Varga yazdı
caused by case-sensitive path handling of relationship files. OOXML documents contain case-insensitive file paths, for example, uppercase "Sheet.xml" can have a lowercase "sheet.xml.rels" in the ZIP archive, as in the case of the XLSX documents generated by IBM Cognos. Change-Id: I4210e3b96fb512d61e1687ec8d41a3c77292ec0c Reviewed-on: https://gerrit.libreoffice.org/72100 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
-
Caolán McNamara yazdı
Change-Id: I0cc79534112ae8897a9887942238ff1236c4a3eb Reviewed-on: https://gerrit.libreoffice.org/72217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Iec71ca870db5f6aaf317e23db369dfc1fa04bcc1 Reviewed-on: https://gerrit.libreoffice.org/72205 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Muhammet Kara yazdı
Add a SfxRedactionHelper::autoRedactPage method which searches for the given term through the gdimetafile which has the whole content of an xPage (a Draw page), and draws redaction rectangles at proper positions with proper sizes. The search is case sensitive, and finds only the first occurences on a line. Will switch to a proper search provider via a follow-up patch. Change-Id: If3db62e50994670143785b6727fdcf1ccd4c6f8e Reviewed-on: https://gerrit.libreoffice.org/68597 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
-
Jan-Marek Glogowski yazdı
Qt generates three change events when changing the KDE theme: FontChange, StyleChange and PaletteChange. LO has two: SettingChanged and FontChanged. And like Qt LO will inform all widgets / windows independently. To prevent several redraws, this patch just collects all Qt's change events and notifies LO once a bit later via a Timer. Change-Id: I9b45f543f13a84e39247a642a0e33c9ec008a46a Reviewed-on: https://gerrit.libreoffice.org/72196 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
-
Katarina Behrens yazdı
and thus the selected doc can't be used as the source of external data for this sheet. In other words, help the user figure out why is OK button disabled Change-Id: Ie1b999c9c3640397e9f6f6ee321d3a5a5d63fa3b Reviewed-on: https://gerrit.libreoffice.org/72075 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
-
Justin Luth yazdı
A user pressing "next tip" will expect to cycle sequentially through the list of tips, and not get a random one each time. Change-Id: I331d35d623b6449a9daef407a498b4ba08eaff6f Reviewed-on: https://gerrit.libreoffice.org/72099 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
-
Michael Stahl yazdı
This URL results in an error message and 0 results because "Changed" in the UI translates to "delta_ts", not "changed" apparently. Change-Id: I2bfdd682bb7fca229039970c209e7e409532059c Reviewed-on: https://gerrit.libreoffice.org/72219Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
-
Katarina Behrens yazdı
a frame that contained valid but unmodified document opened from template or explicitly opened by the user (File > New) was treated the same as blank document i.e. it was reused and the content was overwritten by newly opened document (even if it already had non-empty content provided by the template). So let's not do that and let's open a new document in a new frame instead Change-Id: I10252d114e8cc5fcad3c98194ef07fd59873d6da Reviewed-on: https://gerrit.libreoffice.org/71919 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
-
Gabor Kelemen yazdı
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4ebebbbbad31b29c1e63a30685493042462bb52f Reviewed-on: https://gerrit.libreoffice.org/71832 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
-
Miklos Vajna yazdı
It has a number of static members, use m_ prefix only for non-static members. Change-Id: I312b1eaadd1a7d312d4679028446cf69362e4740 Reviewed-on: https://gerrit.libreoffice.org/72215Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
-
Caolán McNamara yazdı
...to latest versions from <http://git.savannah.gnu.org/gitweb/?p=config.git; a=blob_plain;f=config.guess;hb=HEAD> and <http://git.savannah.gnu.org/gitweb/? p=config.git;a=blob_plain;f=config.sub;hb=HEAD> but retain... commit 25a09c87 Date: Wed Jun 7 12:23:17 2017 +0200 iOS, add support for arm64 Added general support for arm64 Removed experimental/prototype from normal build Change-Id: Ic36a9fb9d20344ff0ddc6b293ed3bd48cf140a31 Reviewed-on: https://gerrit.libreoffice.org/72200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Arkadiy Illarionov yazdı
Use comphelper::sequenceToContainer instead of ContainerHelper::SequenceToVector Change-Id: I4834255a1349ac7a29127a84a54fcfa98d678d00 Reviewed-on: https://gerrit.libreoffice.org/72186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Samuel Mehrbrodt yazdı
These tests has been implemented as a UITest in sw/qa/uitest/writer_tests5/xwindow.py Change-Id: I0c1ae6d086a5a7d6e15b89bb3e810b49434da01e Reviewed-on: https://gerrit.libreoffice.org/71950 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
-
Samuel Mehrbrodt yazdı
Change-Id: Icd8566c2fce1a0ff3fb9471afd71858ec2f91bc5 Reviewed-on: https://gerrit.libreoffice.org/71982 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
-
Noel Grandin yazdı
Change-Id: I64b5c3c5a19408febe7753db6ea403b91f7f5c83 Reviewed-on: https://gerrit.libreoffice.org/72188 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
Change-Id: Ia6c4d56e8019fd92ac69499b9902f8bd8ca27fec Reviewed-on: https://gerrit.libreoffice.org/72187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Noel Grandin yazdı
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Jan-Marek Glogowski yazdı
Change-Id: I63008858558312b5fb7378249c56fbc3729c9a19 Reviewed-on: https://gerrit.libreoffice.org/72180 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
-
Jim Raykowski yazdı
Change-Id: I5a94f7bcf90e5831fc63d3f8ad83278e425417eb Reviewed-on: https://gerrit.libreoffice.org/72159 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
-
- 12 May, 2019 14 kayıt (commit)
-
-
andreas kainz yazdı
Change-Id: Iab4d40da76478d6341b4ea057996b9328e73d8c2 Reviewed-on: https://gerrit.libreoffice.org/72190Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
-
Luboš Luňák yazdı
Change-Id: I4894023e42cbfa32916ee3ddfb2cfb5426cfc69f Reviewed-on: https://gerrit.libreoffice.org/72195 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
-
Luboš Luňák yazdı
Change-Id: I9c7f7d2f266950fac683bf5148dec741d7652585 Reviewed-on: https://gerrit.libreoffice.org/72194 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
-
Luboš Luňák yazdı
Change-Id: I3417f80621584553041eeb504d35cb4241a19b61 Reviewed-on: https://gerrit.libreoffice.org/72203 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
-
Todor Balabanov yazdı
Change-Id: I0c3e50ef25bda0bc4ae59665a07848fe75507121 Reviewed-on: https://gerrit.libreoffice.org/72185Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
-
Caolán McNamara yazdı
maybe since... commit 1caea03f Date: Mon May 6 15:40:41 2019 +0200 tdf#122892 tdf#124366 sw: fix loop in SwTextFrame::CalcFollow() though it happens in the idle callback and isn't easily reproducible Change-Id: Iadcd735661ab42908061e80d72c8b32a0c075726 Reviewed-on: https://gerrit.libreoffice.org/72198 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Ib9a7d484cb93c0dbf6a13b540895e0e5d5c00d49 Reviewed-on: https://gerrit.libreoffice.org/72202Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: Ie8455f6082a762e730354e56bac6d76c26de6979 Reviewed-on: https://gerrit.libreoffice.org/72201 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: I656a11f5f9c55913cede710cf48543384132129d Reviewed-on: https://gerrit.libreoffice.org/72199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Caolán McNamara yazdı
Change-Id: If06902f0308511fb40b031899c912c36da0b610e Reviewed-on: https://gerrit.libreoffice.org/72167 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
-
Arkadiy Illarionov yazdı
Similar to clang-tidy readability-container-size-empty Change-Id: If6a567708d3c59355d54933fad23c85195846624 Reviewed-on: https://gerrit.libreoffice.org/71763 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
-
Michael Stahl yazdı
It's in GSTREAMER_1_0_LIBS on Fedora 30. Change-Id: I0a9e5a53ee1bbd4ac4109ccbdbbd94b909b62118 Reviewed-on: https://gerrit.libreoffice.org/72174 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
-
Michael Stahl yazdı
Presumably 1e268223 assumed that it's not called any more but evidently it is. Change-Id: I5b7bad52d0a0c40494b33c3a604c8af1ace2b090 Reviewed-on: https://gerrit.libreoffice.org/72173 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
-
Michael Stahl yazdı
... hence it will print a pointless warning about some problem that doesn't affect JDK 8 anyway. Change-Id: Ic7669950dbb16815c85e4b8eb9d07d75c68d1b82 Reviewed-on: https://gerrit.libreoffice.org/72172 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
-