Change-Id: I1092115a0ceb3a5e6680a4b724b129f98a892c42
Reviewed-on: https://gerrit.libreoffice.org/48128Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Project: help  d860405baeffb4cb6b1a32274d2c2b609ef8deea

Correct Catalan spelling

Typo introduced in 01879555450189381cc02517433807056b193af8

Change-Id: I9978ec8b238493a501981e192aa92547f2c1fe5d

Project: help  02e87fe2b0027c725075154f9172e9fb99ef9589

Add more localized strings for new Help

Change-Id: I8c0cdcf8cf1ce64a407c98f4619a46b08c259b7d
Reviewed-on: https://gerrit.libreoffice.org/48186Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

With contributions from Kendy

Call new help
* If LibreOffice online, call help online
* If no local help, call help online
else call offline html help
if offline help return false, call old-help

* left tempfile to be deleted when LO exits (ESC)

* hasHelp function now check if the right locale exist

Change-Id: I14893e8ba4998773706b9cf8164636475d1f2356

Fix HIDs with a ':' inside

Change-Id: I17b7c96b6b0003e8d933131b7b251f3191389a0f

Call new help directly, fix locale issue

Avoid passing by a html file that is necessary only in
the online case.

Fix path location of help/ folder

Implement fall back in languages
locale -> lang -> en-US.
If none of the theree above, call online help with locale.
fix scope

Change-Id: If92673594c92e0d5a6064bc0e0bb4b66a52730ec
Reviewed-on: https://gerrit.libreoffice.org/47748Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

If you use OS X and an international locale (e.g. Locale setting:
Dutch (Netherlands) and select Decimal separator key: Same as
locale setting (,) in Preferences/Language Settings/Languages using
the decimal separator key on the numeric keypad still results in a
'.' instead of the expected ','. Tested and confirmed using latest
LO build on 10.11.6 and 10.12.6 using both the wired and wireless
Apple keyboard.
The cause for this is that the decimal separator key sends a
KEY_POINT (like the regular . key on the alphanumeric part) and
the code expects a KEY_DECIMAL for the decimal separator key.
Fixed by changing the combination of KEY_POINT and mask
NSNumericPadKeyMask to KEY_DECIMAL.

Change-Id: Iaf1ecf538c3e1a49ad512851cf16dd4dd991cb06
Reviewed-on: https://gerrit.libreoffice.org/45362Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

Project: help  ea4a7345bc1cbcbff3fb4355d0e4f4954f8afa7d

Fix detection of bad help call

remove single quotes

Change-Id: Ia7951508cbf0a49ae029588e1d254de5f3942f12
Reviewed-on: https://gerrit.libreoffice.org/48165Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>

Change-Id: I10409fe9e6eb7b932496346224952a7c4012cb38
Reviewed-on: https://gerrit.libreoffice.org/46192Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>

Such dumper code for other ww8 features is in the separate mso-dumper
repo.  If it is found really useful later, it can be still restored and
fixed up to actually build, though.

Change-Id: Id542fef9c0111c8bc88b943e268c9a02f3503d72
Reviewed-on: https://gerrit.libreoffice.org/48161Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I98279a1f4020be95c57390fd163ebe740f8cca9d
Reviewed-on: https://gerrit.libreoffice.org/48171Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Icadf5cb88024b8889d49dc9c5210d0de8deaed3b
Reviewed-on: https://gerrit.libreoffice.org/48172Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: Ib9430d2c1cc05c7b73273270f8f96e716fc4dc3f
Reviewed-on: https://gerrit.libreoffice.org/48129Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

IsTableNode() is true when m_pTableCursor is not nullptr.
So, GetCursor() is only called when it is nullptr.
In turn, GetCursor() only does something if m_pTableCursor is not nullptr.

This is so from the beginning (commit 84a3db80 from 2000 already has it).

Change-Id: I258129fc1bab0e3e5591702af1158c1ec2579d8d
Reviewed-on: https://gerrit.libreoffice.org/48144Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Ever since commit cc144e55 fix for
i#76959 the pTopTable parameter of HTMLTable was always null.

Simplify HTMLTable by removing dead code.

Change-Id: Ie13313f54d6ee656e56a209bc29bcc77132de269

regression from

commit c40dfabd
Date:   Fri Jan 12 11:57:22 2018 +0000

Change-Id: Ia97ba286a2da0584a2e806ad7396a3633f9d913e
Reviewed-on: https://gerrit.libreoffice.org/48160Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ifd602f47dd57cdecff3c175d892993072fb82891
Reviewed-on: https://gerrit.libreoffice.org/48154Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Idb5184e141c5a15d4d77268f8d45ee549c6e9a7f
Reviewed-on: https://gerrit.libreoffice.org/47714Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Ie2792b7dffaffe939778a1546653424ac03ea30e
Reviewed-on: https://gerrit.libreoffice.org/48105Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

regression from...

commit 7d8e9444
Date:   Thu Jan 11 08:47:15 2018 +0200

    convert a<b?a:b to std::min(a,b)

cause old promotion was to the largest type, so with a large 64bit nDiff and
any 32bit nRequestedBytes the nRequestedBytes was promoted to 64bit, found to
be smaller than nDiff, then would fit in 32bit. newer code cast both to 32bit,
resulting in a negative nDiff which was smaller than nRequestedBytes, but going
on to cause havoc.

Change-Id: I9eb5c61302b3dccf5333c4dfbf9ac92ce49585b5
Reviewed-on: https://gerrit.libreoffice.org/48155Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

(where it is not actually needed), and instead include it where needed

Change-Id: I107f8d4002d3001393b89834dd30a30b0c53a792
Reviewed-on: https://gerrit.libreoffice.org/48152Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

It was a bit confusing that the doc model had a title set, it was
written to the EPUB file but the UI did not show it.

Change-Id: Ife408e0dabd3fe48e8acc1f09be0c86f78ed4b80
Reviewed-on: https://gerrit.libreoffice.org/48150Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Previously:

- the user had to copy the linked image to the same dir as the doc
- set a relative link on the image (in ODF, it resulted in "../foo.png")
- copy the image to the media dir ("test" by default for "test.odt")
- export to EPUB to have the image popup

Now, additionally:

- relative link may point to the default media dir (in ODF, it results
  in "../test/foo.png")
- no need to copy the image
- export to EPUB creates the popup

So one less step is necessary. The downside is that this way the
relative URL contain the base name of the document, so renaming the
document breaks these relative links.

Change-Id: I93894a28393d36a33dcec7bfe7c4a54fd83768da

So that an image and its caption in a text frame always go to separate
lines.

Change-Id: I439e370ad3bc8628f80a8db45499f8bffd84ef2b
Reviewed-on: https://gerrit.libreoffice.org/48148Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I06aa51f0f46f3708540ebb218387cb028b9e65d3

It's valid to have a relative link that points nowhere in ODF, but the
same is not true for EPUB.

Change-Id: I7884032e277a0c53d0c513cea70dd2ee29ccd85c

...after 252ce90e "sw lokit: add page syles to
header & footer"

Change-Id: Ia0b3f8194d889fc1022da08bac06c85cbb22dd3b

...after 022588bf "Include
android/compatibility.hxx from ubiquitous sal/config.h"

Change-Id: I58c620fd25add4758ec981c9812811916fa09db5

...that got broken with c394363c
"loplugin:constparams in basctl", causing -fsanitize=function to complain:

> sfx2/source/appl/app.cxx:452:28: runtime error: call to function basicide_handle_basic_error through pointer to incorrect function type 'long (*)(void *)'
> basctl/source/basicide/basobj3.cxx:48: note: basicide_handle_basic_error defined here
>     #0 0x7ff6340234aa in SfxApplication::GlobalBasicErrorHdl_Impl(SfxApplication*, StarBASIC*) sfx2/source/appl/app.cxx:452:28
>     #1 0x7ff63401cbef in SfxApplication::LinkStubGlobalBasicErrorHdl_Impl(void*, StarBASIC*) sfx2/source/appl/app.cxx:434:1
>     #2 0x7ff639142148 in Link<StarBASIC*, bool>::Call(StarBASIC*) const include/tools/link.hxx:84:45
>     #3 0x7ff63911f350 in StarBASIC::RTError(ErrCode, rtl::OUString const&, int, int, int) basic/source/classes/sb.cxx:1681:37
>     #4 0x7ff63965aafe in SbiInstance::Abort() basic/source/runtime/runtime.cxx:518:16
>     #5 0x7ff639664363 in SbiRuntime::Step() basic/source/runtime/runtime.cxx:865:28
>     #6 0x7ff6392ec321 in SbModule::Run(SbMethod*) basic/source/classes/sbxmod.cxx:1141:25
[...]

Change-Id: I66bd1ca720cebca4fb5fd52d86920de3fc7a604e
Reviewed-on: https://gerrit.libreoffice.org/48142Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...so consistently use the latter instead of the former

Change-Id: I144d5e7c472632f93b2258461510346bc85892d9
Reviewed-on: https://gerrit.libreoffice.org/48135Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

> Jan 18 15:18:25 <sberg> tml__, do you remember anything about
>  e3a07b8a ? looks odd to add configure
>  KEY=VALUE args to the environment
> Jan 18 15:18:27 <IZBot> core - Include environment variables already in
>  autogen.sh's environment -
>  http://cgit.freedesktop.org/libreoffice/core/commit/?id=e3a07b8a6cc03b6d5063e4da5a474d8c91a84b0a
> Jan 18 15:22:54 <tml__> sberg: not really any recollection, sorry
> Jan 18 15:23:09 <tml__> sberg: are you sure this isn't what makes it possible
>  to have CC=clang etc in autogen.input?
> Jan 18 15:24:07 <tml__> or maybe this is related to propagating stuff when
>  make re-runs autogen.sh?
> Jan 18 15:24:28 <sberg> tml__, configure already takes care itself of its
>  KEY=VALUE command line arguments
> Jan 18 15:24:36 <tml__> sad that I didn't write a better commit message
> Jan 18 15:24:55 <tml__> feel free to revert it, and see if anybody notices;)
> Jan 18 15:25:04 * cloph_away used it for CC/CXX and devtools repo
> Jan 18 15:26:11 <tml__> cloph_away: yes, but I think sberg says that should
>  work anyway, even without that commit

The only reading from ENV after that code in autogen.sh (both today and at the
time of e3a07b8a) is the

  if (defined $ENV{NOCONFIGURE}) {
      print "Skipping configure process.";

check, which would now no longer work if you pass NOCONFIGURE= as an argument
to autogen.sh (in autogen.input or on the command line) instead of as an
environment variable.

Change-Id: If50639978190d219b063ff39f81e29d2054c0443
Reviewed-on: https://gerrit.libreoffice.org/48133Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

...which allows to align --enable/--disable switches on the part being en-/dis-
abled, as in

> --disable-assert-always-abort
>  --enable-avahi
>  --enable-breakpad
>  --enable-build-unowinreg
> --disable-ccache

for better readability

Change-Id: I490402c74ea1ee535deee6ef79274b588b614820
Reviewed-on: https://gerrit.libreoffice.org/48130Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: I8c4cc4ab212409bce54b64d59d07d77a924ed11c

Change-Id: Ic8b02f5c6582a992b64f31435332ee37d826ad48

Change-Id: I788ec594589d9708e12db83a7371b5a8d9fed38c

Change-Id: Ic66d817746de423549c87f58068e47f9942d04fd

Change-Id: Ibeae1754a18152c3a17379c95e3caa536a8822db

Change-Id: I0ebec3193b4369039f90be4223ebdf6d048b8478

Change-Id: I20525bd69c91ff35c9e569525a0d4556bc184982

Change-Id: I86622a13583137605bf2b6468113da2eb5e4ee0b

Change-Id: I2c3c7be4bc3b43f03c45724e7a002e862b50f24b

Change-Id: I3d25a50ed7ebf78214c0d358243f7e286503b8f8