- 23 Ock, 2018 37 kayıt (commit)
-
-
Stephan Bergmann yazdı
Earlier GCC already require a similar workaround to silence -Werror=return-type ("control reaches end of non-void function") a few lines further down, so it's rather consequential that GCC now also warns about the potential fall-through here (i.e., for these warnings, GCC apparently assumes that an enum can take on all of the values from its range of values, not just those denoted by an enumerator). Change-Id: I1537a7f6975f900861225ee7a521366a5e57046a -
Stephan Bergmann yazdı
Change-Id: Ica04ee68f18ec6c1e0cd59a0f35ab35ce3c05745 Reviewed-on: https://gerrit.libreoffice.org/48374Tested-by:
Jenkins <ci@libreoffice.org> Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Milian Wolff yazdı
LO already supports http, https, webdav and webdavs through the WebDAVContentProvider. Ftp is supported via FTPContentProvider and then finally we have the GIOContentProvider that can potentially support SMB, if the dependencies for that are met. We now configure the KDE file dialog to allow these remote protocols. Note that this filtering depends on https://phabricator.kde.org/D10024 and https://phabricator.kde.org/D10025 to have any effect. Then we rewrite the URLs we receive from KIO to a format that is supported by LO. Most notably, we prepend `vnd.sun.star.` to the webdav URL schemes, such that they get picked up by the WebDAVContentProvider. Then finally, we clear the username from the smb:// URLs we get from KIO, as that prevents GIO from opening them. In all cases, the user will get prompted a second time for the credentials required to access the remote resource. This is unfortunate, but better than nothing. In the future, we may solve this issue through either a separate KIO UCP or by getting support for the FDO Secret Service specification in KWallet. Change-Id: I91df28434b115639c2698968e2a672b3320bf8e2 Reviewed-on: https://gerrit.libreoffice.org/48350Tested-by:
Thorsten Behrens <Thorsten.Behrens@CIB.de>
-
Rene Engelhard yazdı
Change-Id: Idcd2931415558b41f94eb12a01f350f1ab53d134 Reviewed-on: https://gerrit.libreoffice.org/48319Tested-by:
-
Milian Wolff yazdı
This is a hybrid plugin which mostly wraps the GTK3 vclplug. Only the file and folder picker are replaced by KDE dialogs. This gives us a well-maintained GTK LO base with basic KDE integration with minimum effort. To prevent issues with nested event loops, the KDE dialogs are launched from a separate process, the new lo_kde5filepicker helper executable. A trivial stdin/stdout IPC mechanism transfers the data between LO and the Qt/KDE helper. The usage of an external process also allows us to copy'n'paste between LO and the KDE file dialog without freezing the UI, as would happen when one would do this in-process. This is in general also the architecture applied by the kmozillahelper, which is used to integrate KDE file dialogs into Firefox. While the KDE dialog is shown, the GTK3 main window is disabled and close requests are ignored. The KDE dialog in turn also sets the LO window as transient parent. Together, this makes the illusion perfect and the KDE dialog behaves like a modal dialog. This works properly also with multiple LO main windows, and only individual windows will get blocked as one would expect. Functionality wise, most of the features of the KDE4 dialog are supported. You can pick files and folders, and save files under a new name. Some custom checkbox widgets are supported, but lists, buttons and preview widgets are not yet implemented. Also, loading remote files via KIO is not possible yet. Change-Id: I1a97cf7c272307a19ace4222d5f12253bc722829 Reviewed-on: https://gerrit.libreoffice.org/47718Tested-by:
-
Milian Wolff yazdı
This is mostly a copy of the KDE4 backend ported to Qt5/KF5. One difference is that this code will initialize the QApplication on-demand, when it's not yet available. This will allow us to use this desktop backend also within a vclplug that does not use Qt itself, such as the upcoming Gtk3/KDE5 hybrid. Change-Id: I5cf96ac5729608c82a58eead6723a38f014ba875 Reviewed-on: https://gerrit.libreoffice.org/47716Tested-by:
-
Katarina Behrens yazdı
Change-Id: Ifbcfdbb74bffaf88296351ec72536e16a4073b60 Reviewed-on: https://gerrit.libreoffice.org/48102Tested-by:
-
Milian Wolff yazdı
Pass --enable-kde5 to autogen.sh to enable this feature. Then add kde5 to the list of externals to link against KF5. I will introduce other code that depends on KF5 though which will leverage this feature. Change-Id: I17e434a53ac769000b0f805b1f41cdc5c2c84ee2 Reviewed-on: https://gerrit.libreoffice.org/47715Tested-by:
-
Laurent BP yazdı
Project: help 94375babd75d8b611311bab682f9017e0485d19b tdf#113979 Skip empty cells option Add help for this new option. Correction help link for "Quoted text" option Change-Id: I8ce8ac8108408c9feb55a0b5dffbb44dea988c05 Reviewed-on: https://gerrit.libreoffice.org/46996Reviewed-by:
Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by:
-
Ilmari Lauhakangas yazdı
Project: help 995f740adfff22aff1105a7e1b2801dfdab43434 Use list.js for Index listing and search List.js - http://listjs.com/ - allows us to paginate the results so the height does not get out of hand. Fuzzy search would be cool: http://listjs.com/docs/fuzzysearch/ ...but it gives too big of a perf hit with our 5700 items. Might try to bribe the creator to look into perf. Thanks a lot to David Tardon for the makefile solution and to Christian Lohmaier for playing a rubber duck. Change-Id: I359eed541470ccaa309b0b6ff5d809a796d9befd Reviewed-on: https://gerrit.libreoffice.org/48335Reviewed-by:
-
Eike Rathke yazdı
Similar to ScRangeList::Join() done before. Change-Id: Ie513b4c72bc211c196e13761b63446174321a389 Reviewed-on: https://gerrit.libreoffice.org/48361Reviewed-by:
Eike Rathke <erack@redhat.com> Tested-by:
-
Eike Rathke yazdı
Joining an existing list of identical ranges could end up in a very deep (but not infinite) recursion which could lead to stack exhaustion. Recursion is unnecessary if we re-enter the loop with the picked range. Continuing the loop as it was done after recursion isn't necessary either, to the contrary, as long as there is one join try the entire list again. Commit f6eefd96 pointed this out as the UBSan build runs with ulimit -s 8192 Change-Id: Ibbc542fc8ae6d1509744aa731771eb6e32a38841 Reviewed-on: https://gerrit.libreoffice.org/48360Reviewed-by:
-
Tor Lillqvist yazdı
Surely we should not be using it for our own things in our Quartz code, that is misleading. Also bin a silly typedef. Change-Id: Ie932e8784128246ca449608aad3dc96a575ec9d5
-
Noel Grandin yazdı
Change-Id: I8d7766d473499b4d154debc1aafaf03359078aa3 Reviewed-on: https://gerrit.libreoffice.org/48372Tested-by:
-
Noel Grandin yazdı
Change-Id: Iacda2920f632a6f21d852d843e97086a23479bbd Reviewed-on: https://gerrit.libreoffice.org/48370Tested-by:
-
Tor Lillqvist yazdı
Change-Id: I05021e1d86412c3a0703e71f43fe2238bb094762
-
Jon Nermut yazdı
Change-Id: I210d68f013e56efd90da004891b872434ce65f68 Reviewed-on: https://gerrit.libreoffice.org/48368Reviewed-by:
jan iversen <jani@libreoffice.org> Tested-by:
-
Noel Grandin yazdı
look for possibly bogus implicit conversions to bool when passing (normally pointer) args to bool params. this plugin comes in the wake of a couple of bugs caused by refactoring, where some of the call sites were not currently updated. Of the changes, the following are real bugs: desktop/../dp_persmap.cxx StartInputFieldDlg in sw/../fldmgr.cxx which occurred as a result of commit 39d719a8 Date: Tue May 3 11:39:37 2016 +0200 tdf#99529 sw: don't pop up input field dialog before inserting field CSerializationURLEncoded::encode_and_append in forms/../serialization_urlencoded.cxx XclExpCFImpl::XclExpCFImpl in sc/../xecontent.cxx I have no idea how to properly fix this, just made a guess. SwDocTest::test64kPageDescs in sw/qa/core/uwriter.cxx which looks like a simple copy/paste error. Change-Id: I795ebd5ef485a1d36863dc27fe13832989f5a441 Reviewed-on: https://gerrit.libreoffice.org/48291Reviewed-by: -
Stephan Bergmann yazdı
...that had presumably been forgotten when the surrounding code had been changed from USHORT to sal_uInt16 in cd42389a "removetooltypes01: #i112600# remove tooltypes from sc". Plus, turning the preprocessor checks into static_asserts. Change-Id: I78271f7027af701699865913813d6dea8b0c570b Reviewed-on: https://gerrit.libreoffice.org/48358Tested-by:
Stephan Bergmann <sbergman@redhat.com>
-
Matthias Seidel yazdı
(cherry picked from commit 106d959d) Change-Id: I51c86dfef0e0eff59ce2892d8ea07dd066fd9667
-
Michael Stahl yazdı
Looking at the HTML4 DTD https://www.w3.org/TR/html4/sgml/dtd.html, inside TABLE only various elements defining the structure of the table allowed, except inside cells (TD and TH elements). DIV in a table but outside cells may cause cursor positions to go off the rails, so better ignore such invalid DIV tags. Change-Id: Ia6195d80670631669c252d572242874b13642b74 Reviewed-on: https://gerrit.libreoffice.org/48359Tested-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Caolán McNamara yazdı
regression from commit 64d624b6 Date: Sat Jan 9 22:55:28 2016 +0100 Fix typos Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209Tested-by:
-
Telesto yazdı
Change-Id: I0665880c0d0348fcbb3bcf04d9172405c8e31eb7 Reviewed-on: https://gerrit.libreoffice.org/48334Tested-by:
Tor Lillqvist <tml@collabora.com>
-
Telesto yazdı
Based on https://codereview.chromium.org/2325313002/ Change-Id: I8838449d57b1d1b010491a405c87645d38199fdf Reviewed-on: https://gerrit.libreoffice.org/48330Tested-by:
-
Miklos Vajna yazdı
The roundtrip of the pdf image failed due to this. Change-Id: I88a9657e242dd2659f9bf06233e5fcbfeb43ceb5 Reviewed-on: https://gerrit.libreoffice.org/48362Reviewed-by:
Miklos Vajna <vmiklos@collabora.co.uk> Tested-by:
-
Miklos Vajna yazdı
The EPUB ToC is now on par with the PDF ToC. Change-Id: Iea714fdb68c825aa14345037e909c354bbd7cf00 Reviewed-on: https://gerrit.libreoffice.org/48346Tested-by:
-
Miklos Vajna yazdı
Extend vcl::PDFExtOutDevData so that it's possible to use it outside the PDF export; this way the EPUB export can know which chapters start on which page. This means fixed and reflowable layout has the same table of contents, instead of just Page <N> in the fixed layout case. Change-Id: I935fb23c66ec747431b91e83b0e677d4e5f704b9 Reviewed-on: https://gerrit.libreoffice.org/48332Reviewed-by:
-
Samuel Mehrbrodt yazdı
Breaks windows installer This reverts commit 7b129f55. Change-Id: I21a5a6790eac1704da4bda41fb0969dc10b19d1c Reviewed-on: https://gerrit.libreoffice.org/48369Reviewed-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by:
-
Stephan Bergmann yazdı
...since 16b44693 "Use OUString / sal_Int32 in vcl(outdev3.cxx,textlayout.cxx)" Change-Id: I9e77bf801c6d79e1993ac6ddecf740b3362aeafe Reviewed-on: https://gerrit.libreoffice.org/48364Tested-by:
-
Stephan Bergmann yazdı
...as BrowseBox::GetColumnId (into which _nColumnPos is passed) takes a sal_uInt16 argument Change-Id: I4b890bf0fcbc91f2f07b3614a2e07aabf3345f7e Reviewed-on: https://gerrit.libreoffice.org/48363Tested-by:
-
Stephan Bergmann yazdı
Change-Id: Icdda5cbc39fc2878c869ec01349135fd56a15363 Reviewed-on: https://gerrit.libreoffice.org/48349Tested-by:
-
Stephan Bergmann yazdı
The code used the odd combination of checking signed nFieldLen for != 0 and <= USHRT_MAX, and then converting to sal_Int16 (not sal_uInt16) ever since bf4154eb "initial import". But there are indeed various MaxTextLen properties in offapi of type short, not unsigned short, so for one assume that checking for <= SAL_MAX_INT16 (not SAL_MAX_UINT16) was actually intended. And, for another, also assume that checking nFieldLen for > 0 instead of != 0 was intended. Change-Id: I119ef3ce71ee397cb6cbca714bca154e29e6599d Reviewed-on: https://gerrit.libreoffice.org/48348Tested-by:
-
Stephan Bergmann yazdı
...which is of type sal_uInt16 ever since the class got introduced with 0e3ff5db "INTEGRATION: CWS oj14: #i77059# export char content helper for example line break" Change-Id: I1dcb2894861ea5b6104932d896b7166c5c0b4689 Reviewed-on: https://gerrit.libreoffice.org/48347Tested-by:
-
Stephan Bergmann yazdı
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427c "Enable loplugin:cstylecast for some more cases" and a409d32e "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317Tested-by:
-
Stephan Bergmann yazdı
...which is based on sal_uInt16 instead of USHORT since c5b72767 "removetooltypes: #i112600# remove tooltypes" Change-Id: I6b937961a69cc904226b05fe9679ac62e2f01c0a Reviewed-on: https://gerrit.libreoffice.org/48333Tested-by:
-
Noel Grandin yazdı
Change-Id: I75c1ca2d6b0e03604bb6c96d2613261a1a05b988 Reviewed-on: https://gerrit.libreoffice.org/48297Reviewed-by:
-
Noel Grandin yazdı
Change-Id: Ie85c1a8fd699f68ffcc8853be4bf8a86cfec06e7 Reviewed-on: https://gerrit.libreoffice.org/48295Tested-by:
-
- 22 Ock, 2018 3 kayıt (commit)
-
-
Samuel Mehrbrodt yazdı
This makes images/draw objects anchored to cells move as any other content when sorting cells. Works for sorting rows and columns. Also fixes a bug where notes attached to cells were not sorted when sorting columns. Change-Id: Id9a56a15f776d5adbe382a9bca167bff48b69a0c Reviewed-on: https://gerrit.libreoffice.org/46838Tested-by:
-
Caolán McNamara yazdı
Change-Id: Ifb5cfdd87d7b26d18fcb66279afa7ef06beea9e3 Reviewed-on: https://gerrit.libreoffice.org/48323Reviewed-by:
-
Stephan Bergmann yazdı
Change-Id: Ie60f2cc7c3b0bcba7ddf2e7a0f6837c821b33dcc Reviewed-on: https://gerrit.libreoffice.org/48313Tested-by:
-
