Change-Id: Ia698aec5a4ea9bb2452263f5ff975e045da66393
Reviewed-on: https://gerrit.libreoffice.org/22747Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>

Change-Id: Ie4bfb5525fe56da0cd02e8d5d42bfeef438ff664
Reviewed-on: https://gerrit.libreoffice.org/22736Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>

Change-Id: I65f1574d48f2c7f29b7dc4f642fc4713442ce743
Reviewed-on: https://gerrit.libreoffice.org/22920Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>

The default table style defined in tableStyles.xml file can be used
when a table is initially inserted into a document.  It must not be
applied by default to any of the tables not referencing a table style
explicitly from the tableStyleId element.

Change-Id: I025cdfba352c87a32f9a1e297fbc8b9fc2c8c0a4
Reviewed-on: https://gerrit.libreoffice.org/22619Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

If no fill type is defined for a table cell, then set it to XML_noFill
explicitly, in order to override the fill type defined by the default
graphic style or the graphic style named standard, added by LO and
exported into ODP.

Change-Id: I9c5aa4c2a939ee7b8c75ae686d845cd14a718254
Reviewed-on: https://gerrit.libreoffice.org/22618Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>

... not in all debug builds.

Change-Id: I6f53c6c6860ee00b740484ed31317d5e58922082

I made small changes to disable some test code conditionally by adding a few
new debug macros.

Change-Id: Ieaf6f1b29343fb896cc64163a116c629165e8db3
Reviewed-on: https://gerrit.libreoffice.org/22711Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Issue is a regression in commit 09c72287.
(EMF/WMF: fix rendering of pen styles (dash, dot, dashdot, dashdotdot).

I've looked at how the latest version of Word on the Mac works, and it
turns out that the spacings for the PenStyle enumerations in the LogPen
objects for all the create pen EMF records are as follows:

* PS_DOT           - ■ □ ■ □ ■ □ ■ □ ■ □ ■
* PS_DASHDOT       - ■ ■ ■ □ ■ □ ■ ■ ■ □ ■
* PS_DASHDOTDOT    - ■ ■ ■ □ ■ □ ■ □ ■ ■ ■

(where ■ is the actual filled in area, and □ is the space between the
filled in areas)

In other words, each dash fills in the space of three dots, and there
is the one dot worth of empty space between the dashes and dots. Each
"dot" has a width and height equal to the width specified in the pen.

So basically, we seem to be arbitrarily setting the dot, dash and
distance lengths arbitrarily, which were reasonable guesses but tended
to produce very odd lines at different zoom levels.

Change-Id: Ie8b5fa396e4fb0f480cb3594c8129a59f472c1b8
Reviewed-on: https://gerrit.libreoffice.org/22886Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>

fix no opcode mapping warnings:
warn:sc:32739:14:sc/source/filter/oox/formulabase.cxx:1431: OpCodeProviderImpl::initFuncOpCode - no opcode mapping for function ODF 'ORG.LIBREOFFICE.FORECAST.ETS.MULT' <-> OOXML '_xlfn.FORECAST.ETS.MULT'
'ORG.LIBREOFFICE.FORECAST.ETS.PI.MULT'
'ORG.LIBREOFFICE.FORECAST.ETS.STAT.MULT'

Change-Id: I55bbf79b40944d76486085f5aceb842197c51b5c
Reviewed-on: https://gerrit.libreoffice.org/22914Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: Id4231454dfb34cac6ee89d63beb18a83c63a44c1

Change-Id: Ie3a8fbd430651dafaa837fabad0d0f818449b3fb

clang-cl as-is does not provide the intrinsics provided by MSVC; you need to
explicitly include Intrin.h (provided by clang) for that.  So, as a hack,
specify CC/CXX as

  clang-cl.exe -FIIntrin.h ...

to have the intrinsics always available.  But Intrin.h includes stdlib.h, so by
the time sal/osl/w32/random.c defines _CRT_RAND_S before including stdlib.h, the
latter has already been included without _CRT_RAND_S support.  So, as a second
hack, specify CC rather as

  clang-cl.exe -D_CRT_RAND_S= -FIIntrin.h ...

But then clang-cl starts to emit -Werror,-Wunused-macros, as defining
_CRT_RAND_S in the main file has no effect here.

Change-Id: I5dfe9872dea7e8eb476d9260f17ab8d8893f48af

Change-Id: Ia1fb09b89d3ccc3c7f4a11799f0d8eac99c6c7a9

In the second part, looks odd that those two lines are a perfect copy of what is
already done near the start of the function, but I have no insight at all into
that code, so just leave it at that.

Change-Id: I6b1d973f77a3d9389880ddec500968144ba615f2

Looks odd that this isGet block is a perfect copy of what is already done before
this else-if block, but I have no insight at all into that code, so just leave
it at that.

Change-Id: Ieefd6618cb6b0dc49bc4d2c4733b02be2a8e3f7e

This looks like a real bug, causing leaks in the derived VistaFilePickerImpl
(but harmless for the derived AsyncPickerEvents).

Change-Id: Ic0de3f56574b89fb45eccb09fb27b78427f712d4

PATH_MAX was reported unused on Windows with clang-cl, but the whole block seems
rather a leftover than something that is really required.

Change-Id: I545701ef83de0c2a1d74457778b86b70e334a457

Change-Id: Ib72b6225f20e1e53e9d811ddb2d266f17f57404b

Change-Id: Ia0fe12b1159a5fa9fd36b8731bfab178b403e67e

Change-Id: I57a5c19143d59cfec42b0109846b7d62fec2b0ad

Change-Id: If9472d25f469030102b26894793ba45ab0fafaa3

Change-Id: I726679681137e54d55af13ad1d4900525fa60eba

Change-Id: Ia7b0518a05cda8881ab6feed9852e9f060813b5c

Change-Id: Ibc9001f02c89bcfdff396cd694d0de378c6d1863

Fails with the previous commit reverted.

Change-Id: I050a03fa923980e46b31eff457d0b83f6c38ceaf

The removal of the _xmlsignatures sub-storage in
DocumentSignatureHelper::OpenSignatureStream() serves 3 purposes:

1) Remove no longer needed signature streams
2) Truncate signatures relation stream
3) Truncate still needed signature streams

2) and 3) could be done using io::XTruncate as well, but if the whole
storage is removed to handle 1), then individual truncate() calls are
not necessary.

Change-Id: Id9ed9c87c94f340dc947124b28f085561798d361

So that it'll be possible to call that code without an active dialog,
from a headless unit test.

Change-Id: I1728a666ff5d84b337efd7e2b7eb68469896257a

Cloneable, odd additional equals overloads, odd hasCode implementation---all
smells like clueless cargo cult.  And I see no place where it would get used.

Change-Id: Icca89531ce9181fb47eacfb6fae704f4f45012a9

Change-Id: Ia8ddfecf2f809e9f0132ba59812446973532476c

Change-Id: Ia534b5aa579a678f8b0273e6c8c12a6ad335c67a

Change-Id: I7616641584b7ea8192cf3724d8b7d5b88af39da6

Change-Id: If3c86c7e5c4acaf4a3e48194e24c3c73e4e99499

Change-Id: I7109877e789659b87cbc16e9c5da39dcc8249e09

Change-Id: I9ed2aa9c2bf2e17705dc711560154a9596c8264a

Change-Id: If3e6aae326aa53825edca9d5dc207d185d288cce

Change-Id: Iad58e4227433b766bbdce92a53c95aed48320f88

Change-Id: I4a710384ec3a0d719f2ad1fbbe7b43b0be1fa1d9

In OutputDevice::DrawPolyPolygon when b2dpolygon are used for drawing
the source polygon is not drawn on the alpha device.

Change-Id: I54f4e5a13469d9844866cea61b074420219b836d
Reviewed-on: https://gerrit.libreoffice.org/22892Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>

It's unclear to me why the disposeOffice method was marked "synchronized" in the
first place with fbd72be1 "INTEGRATION: CWS
qadev16: #114831#."  Maybe just some cluelessness?  Lets see whether we ever run
into any problems after removing it.

Change-Id: I1f262b6b4b4f4e8911754a6b3fa3d61f5df0aeae

First, it reverts b0111f49. It
was a bad idea to export UI names via LOK because the client
would need the programmatic ones anyways for UNO commands. We
cannot expect UNO commands to accept UI style names and work,
though that's another thing that they will work in most cases
because mostly UI names are equal to programmatic ones. Clients
are now supposed to have their own UI name <-> programmatic name
mapping, if they want style names to use for translations.

Secondly, it fixes a bug that was already there mixing programmatic
names with UI ones in an effort to put default writer styles on
the top of the list.

Change-Id: I307f987fe740b3c43b0e14ec4773edcb672a11df
Reviewed-on: https://gerrit.libreoffice.org/22810Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>