1. 28 May, 2019 1 kayıt (commit)
  2. 09 May, 2019 1 kayıt (commit)
  3. 26 Nis, 2019 2 kayıt (commit)
  4. 08 Nis, 2019 1 kayıt (commit)
  5. 08 Mar, 2019 1 kayıt (commit)
    • Noel Grandin's avatar
      new loplugin constvars · 5c234592
      Noel Grandin yazdı
      detect static variables that can be made const.
      
      Thanks to mike kaganski for suggesting this.
      
      Here I introduce a new plugin feature - using markers
      in nearby comments to disable the plugin for specific
      vars.
      
      Some of this stuff was old debugging code. I removed the stuff
      that was older than 5 years.
      
      Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c
      Reviewed-on: https://gerrit.libreoffice.org/68807
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      5c234592
  6. 22 Şub, 2019 1 kayıt (commit)
  7. 10 Şub, 2019 1 kayıt (commit)
  8. 05 Şub, 2019 1 kayıt (commit)
  9. 05 Ara, 2018 3 kayıt (commit)
  10. 29 Kas, 2018 1 kayıt (commit)
  11. 19 Kas, 2018 1 kayıt (commit)
  12. 16 Kas, 2018 1 kayıt (commit)
  13. 12 Kas, 2018 1 kayıt (commit)
  14. 09 Kas, 2018 1 kayıt (commit)
  15. 07 Kas, 2018 2 kayıt (commit)
  16. 05 Kas, 2018 1 kayıt (commit)
  17. 04 Kas, 2018 1 kayıt (commit)
  18. 02 Kas, 2018 1 kayıt (commit)
  19. 28 Eki, 2018 1 kayıt (commit)
  20. 19 Eki, 2018 3 kayıt (commit)
  21. 15 Eki, 2018 2 kayıt (commit)
  22. 09 Eki, 2018 1 kayıt (commit)
  23. 18 Eyl, 2018 1 kayıt (commit)
  24. 17 Eyl, 2018 1 kayıt (commit)
    • Stephan Bergmann's avatar
      New loplugin:external · 206b5b26
      Stephan Bergmann yazdı
      ...warning about (for now only) functions and variables with external linkage
      that likely don't need it.
      
      The problems with moving entities into unnamed namespacs and breaking ADL
      (as alluded to in comments in compilerplugins/clang/external.cxx) are
      illustrated by the fact that while
      
        struct S1 { int f() { return 0; } };
        int f(S1 s) { return s.f(); }
        namespace N {
          struct S2: S1 { int f() { return 1; } };
          int f(S2 s) { return s.f(); }
        }
        int main() { return f(N::S2()); }
      
      returns 1, both moving just the struct S2 into an nunnamed namespace,
      
        struct S1 { int f() { return 0; } };
        int f(S1 s) { return s.f(); }
        namespace N {
          namespace { struct S2: S1 { int f() { return 1; } }; }
          int f(S2 s) { return s.f(); }
        }
        int main() { return f(N::S2()); }
      
      as well as moving just the function f overload into an unnamed namespace,
      
        struct S1 { int f() { return 0; } };
        int f(S1 s) { return s.f(); }
        namespace N {
          struct S2: S1 { int f() { return 1; } };
          namespace { int f(S2 s) { return s.f(); } }
        }
        int main() { return f(N::S2()); }
      
      would each change the program to return 0 instead.
      
      Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
      Reviewed-on: https://gerrit.libreoffice.org/60539
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      206b5b26
  25. 13 Eyl, 2018 1 kayıt (commit)
  26. 10 Eyl, 2018 1 kayıt (commit)
  27. 17 Agu, 2018 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Avoid further downstream overflow · 4cb69cf3
      Stephan Bergmann yazdı
      ...after 004304eb "try to avoid overflows in
      some compare functions" had changed the return type of just one function, but
      not its callers.  Found with Clang's new -fsanitize=implicit-conversion during
      CppunitTest_sd_filters_test:
      
      > Testing file:///home/sbergman/lo/core/sd/qa/unit/data/ppt/pass/hang-17.ppt:
      [...]
      > sot/source/sdstor/stgdir.cxx:101:19: runtime error: implicit conversion from type 'sal_Int32' (aka 'int') of value -57120 (32-bit, signed) to type 'short' changed the value to 8416 (16-bit, signed)
      >  #0 in StgDirEntry::Compare(StgAvlNode const*) const at sot/source/sdstor/stgdir.cxx:101:19 (instdir/program/libsotlo.so +0x217699)
      >  #1 in StgAvlNode::Find(StgAvlNode const*) at sot/source/sdstor/stgavl.cxx:43:29 (instdir/program/libsotlo.so +0x1db72b)
      >  #2 in StgDirStrm::Find(StgDirEntry&, rtl::OUString const&) at sot/source/sdstor/stgdir.cxx:907:57 (instdir/program/libsotlo.so +0x22f2dc)
      >  #3 in Storage::IsStream(rtl::OUString const&) const at sot/source/sdstor/stg.cxx:773:39 (instdir/program/libsotlo.so +0x1d2cdf)
      >  #4 in SotStorage::IsStream(rtl::OUString const&) const at sot/source/sdstor/storage.cxx:654:27 (instdir/program/libsotlo.so +0x29ebdb)
      >  #5 in PropRead::PropRead(SotStorage&, rtl::OUString const&) at sd/source/filter/ppt/propread.cxx:543:19 (instdir/program/libsdfiltlo.so +0x6b72ee)
      >  #6 in ImplSdPPTImport::Import() at sd/source/filter/ppt/pptin.cxx:262:32 (instdir/program/libsdfiltlo.so +0x5d0dc4)
      >  #7 in SdPPTImport::Import() at sd/source/filter/ppt/pptin.cxx:167:21 (instdir/program/libsdfiltlo.so +0x5cf733)
      >  #8 in ImportPPT at sd/source/filter/ppt/pptin.cxx:2761:26 (instdir/program/libsdfiltlo.so +0x618f64)
      >  #9 in SdPPTFilter::Import() at sd/source/filter/sdpptwrp.cxx:106:32 (instdir/program/libsdlo.so +0x2877ed3)
      >  #10 in sd::DrawDocShell::ConvertFrom(SfxMedium&) at sd/source/ui/docshell/docshel4.cxx:474:46 (instdir/program/libsdlo.so +0x2e1607c)
      >  #11 in SfxObjectShell::DoLoad(SfxMedium*) at sfx2/source/doc/objstor.cxx:786:23 (instdir/program/libsfxlo.so +0x2c8c762)
      >  #12 in SdFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) at sd/qa/unit/filters-test.cxx:75:31 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x19771)
      >  #13 in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:130:20 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x5724c)
      >  #14 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) at unotest/source/cpp/filters-test.cxx:155:5 (workdir/LinkTarget/CppunitTest/../Library/libunotest.so +0x57ec9)
      >  #15 in SdFiltersTest::testCVEs() at sd/qa/unit/filters-test.cxx:83:5 (workdir/LinkTarget/CppunitTest/libtest_sd_filters_test.so +0x19d6d)
      
      Change-Id: Iaffd35d33f0e1109195e3bd56538104d395af01b
      Reviewed-on: https://gerrit.libreoffice.org/59274
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      4cb69cf3
  28. 31 Tem, 2018 2 kayıt (commit)
  29. 26 Tem, 2018 1 kayıt (commit)
  30. 23 Tem, 2018 1 kayıt (commit)
  31. 12 Tem, 2018 1 kayıt (commit)
  32. 11 Tem, 2018 1 kayıt (commit)
    • Noel Grandin's avatar
      clean up UNO available() implementations · 00850e3f
      Noel Grandin yazdı
      There seems to be some confusion here. available() is actually the
      number of bytes that can be read without blocking, but most
      implementations seems to be just returning the number of bytes remaining
      in the stream. Since we're doing that, let's do it properly.
      
      (*) some of them were just casting, instead of clamping, which will
      return wrong values sometimes.
      (*) FileStreamWrapper_Impl/OInputStreamWrapper/OTempFileService were
      doing unnecessary work, instead of just asking the underlying SvStream
      for it's remaining size
      
      Change-Id: I3ef26e0363e989ed3e00be0fdb993e1cdeb7819f
      Reviewed-on: https://gerrit.libreoffice.org/57264
      Tested-by: Jenkins
      Reviewed-by: 's avatarNoel Grandin <noel.grandin@collabora.co.uk>
      00850e3f