1. 24 May, 2019 1 kayıt (commit)
  2. 15 May, 2019 1 kayıt (commit)
  3. 30 Nis, 2019 1 kayıt (commit)
  4. 26 Nis, 2019 2 kayıt (commit)
  5. 29 Mar, 2019 1 kayıt (commit)
  6. 08 Mar, 2019 1 kayıt (commit)
  7. 24 Ara, 2018 1 kayıt (commit)
  8. 22 Ara, 2018 1 kayıt (commit)
  9. 21 Ara, 2018 1 kayıt (commit)
  10. 17 Ara, 2018 2 kayıt (commit)
  11. 16 Ara, 2018 1 kayıt (commit)
    • Mike Kaganski's avatar
      tdf#121987 follow-up: never fail MSU install; warn instead. · 0b6884b9
      Mike Kaganski yazdı
      This replaces commit 53058090. Now
      not only failure to start WU service, but also other errors during
      MSU installation won't break installation. E.g., running WU service
      as Guest does not prevent the service from starting; but installing
      updates fail, which makes previous solution incomplete.
      Instead, show a warning in those rare cases when an error happens,
      and continue. It will allow users to see the reason if they see
      "api-ms-win-*.dll missing" message later after installation. Of
      course, some small percentage of these warnings will be false, e.g.
      those on Windows 10. But those false messages must be really small
      minority, because only when (1) the installation fails (2) on a
      system with the component already present, such a message would be
      false. And it will not prevent the installation.
      This will not block unattended installations, since in those cases,
      MsiProcessMessage() will do nothing.
      Change-Id: I3a9e681e9d6701d092bd5c18bb4b68b4f77170f3
      Reviewed-on: https://gerrit.libreoffice.org/64874
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
  12. 21 Kas, 2018 1 kayıt (commit)
    • Mike Kaganski's avatar
      tdf#112536 related: make soffice.bin a proper console application on Win · 506173a7
      Mike Kaganski yazdı
      Being a GUI application on Windows (with related flag in the executable header
      - see https://blogs.msdn.microsoft.com/oldnewthing/20090101-00/?p=19643/), OS
      would detect the subsystem before launching the application, and won't attach
      the parent console or redirected output handles from it to the application.
      Also, different hacks to reattach the GUI application to the console later are
      unreliable on different Windows versions, and work improperly (the output goes
      to the console after the launch command has already returned, which is wrong
      in batch files). This makes it extremily difficult to do CLI operations with
      LibreOffice on Windows, with error codes/warnings/messages/output missing or
      going to wrong consoles.
      Making an executable for CUI subsystem, on the other hand, makes Windows to
      allocate a console before starting it when the program is run by itself. This
      makes the console window to appear on screen unconditionally, even if it's
      hidden later when the program has started. This flashing is undesirable.
      But we use a wrapper executable on Windows, called soffice.exe, which is what
      actually launched by user, and which runs soffice.bin. This allows us to make
      soffice.bin the proper console application, and thus make it capable to behave
      properly in CLI scenarios, while avoid the console flashing when run from the
      soffice.exe (which would suppress the console creation using DETACHED_PROCESS
      creation flag to CreateProcessW).
      Also creating a new wrapper for console (soffice.com) allows to use command
      lines which omit explicit executable extension (no ".bin"), like this:
      "C:\Program Files\LibreOffice\program\soffice" --help
      which allows to continue using multiple available help resources unchanged,
      since .com extension is tried prior to .exe by Windows' cmd.exe.
      Change-Id: I089d0f30f860da6cfc781b4383f6598a08a4d238
      Reviewed-on: https://gerrit.libreoffice.org/63572
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
  13. 09 Kas, 2018 1 kayıt (commit)
  14. 21 Eki, 2018 1 kayıt (commit)
  15. 30 Eyl, 2018 1 kayıt (commit)
  16. 20 Eyl, 2018 1 kayıt (commit)
    • Mike Kaganski's avatar
      tdf#115405, tdf#119910: don't check if UCRT is already installed · 18828273
      Mike Kaganski yazdı
      There appears to be common situation that a system has *some* UCRT libraries
      in System32, that were installed improperly (presumably by some applications
      using simple copy).In these cases, our installer would detect the presence of
      ucrtbase.dll, and not try to install UCRT on the system.
      Unfortunately, it seems that oftentimes such improper UCRT installations miss
      some parts of UCRT, which leads to LibreOffice failing to start with messages
      like "The program can't start because api-ms-win-crt-string-l1-1-0.dll is
      missing from your computer. Try reinstalling the program to fix this problem."
      (the missing component varies).
      This patch removes the check for UCRT presence. Installer will try to install
      UCRT on applicable systems unconditionally. Since the proper outcomes in case
      of already present UCRT are either WU_S_ALREADY_INSTALLED or WU_E_NOT_APPLICABLE
      and both are treated as success in inst_msu action (see InstallMSU in
      setup_native/source/win32/customactions/inst_msu/inst_msu.cxx), this should
      only make this part more robust, and not bring new problems (yes, I know that
      actually there will be new problems, as usual).
      Change-Id: I22a3d357014d31a8e492ff8a15bcb477eeb79735
      Reviewed-on: https://gerrit.libreoffice.org/60789
      Tested-by: Jenkins
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
  17. 01 Eyl, 2018 1 kayıt (commit)
  18. 27 Agu, 2018 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Remove Extensions_MySQLConnector junk · 5988d888
      Stephan Bergmann yazdı
      ...left over from 26b40fcf "Moving mysqlc into
      connectivity as a library".  (Apparently, for one, a module's Files that don't
      exist are ignored, so 8ecf5e18 "Build fix, make
      install: mysql-connector-ooo extension is gone" removing
      gid_File_Oxt_MySQLConnector but not
      gid_Module_Optional_Extensions_MySQLConnector referencing it didn't cause
      trouble; and for another, an empty module is ignored, so there were no
      extension-mysql-connector packages generated any more---but better clean up the
      junk anyway.)
      Change-Id: If598a968dfbbe9b5f16d735e8011e192cbd4178b
      Reviewed-on: https://gerrit.libreoffice.org/59669
      Tested-by: Jenkins
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
  19. 25 Agu, 2018 1 kayıt (commit)
  20. 12 Tem, 2018 1 kayıt (commit)
  21. 05 Tem, 2018 1 kayıt (commit)
  22. 13 Haz, 2018 1 kayıt (commit)
    • Michael Weghorn's avatar
      Build kde-integration for '--enable-gtk3-kde5' as well · f971bdb0
      Michael Weghorn yazdı
      The relevant files ('libvclplug_gtk3_kde5lo.so',
      'lo_kde5filepicker') resulting from the '--enable-gtk3-kde5'
      build option are put into the kde-integration package
      (e.g. a Debian package when the '--with-package-format=deb'
      option is given).
      However, so far that package was only created at all when
      one of the options '--enable-kde4', '--enable-qt5' or
      '--enable-kde5' was given in addition.
      Since those are not needed for the gtk3_kde5 vclplug, also
      build the kde-integration when none of the others is
      built in addition.
      Change-Id: I86eb71ac7879c7226c9eaa89774b68125212a75c
      Reviewed-on: https://gerrit.libreoffice.org/55310Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarMichael Weghorn <m.weghorn@posteo.de>
  23. 31 May, 2018 1 kayıt (commit)
  24. 30 May, 2018 1 kayıt (commit)
  25. 23 May, 2018 2 kayıt (commit)
  26. 03 May, 2018 1 kayıt (commit)
  27. 02 May, 2018 1 kayıt (commit)
    • Stephan Bergmann's avatar
      tdf#116240: Include --with-help=html in installation sets · e606179d
      Stephan Bergmann yazdı
      ...by extending the hackery in helpcontent2/CustomTarget_html.mk (see comment
      there).  (Ultimately, the gbuild HelpTarget machinery should probably be adapted
      to the needs of this new help format, once the old help format is no longer
      The Perl packaging code finds source files through the "include" paths specified
      in instsetoo_native/util/openoffice.lst.in.  To avoid potential name clashes,
      put the new .filelist files into
      workdir/CustomTarget/helpcontent2/help3xsl/filelists/html-help/ sub-directories.
      read_filelist in solenv/bin/modules/installer/filelists.pm does not strip white
      space following the last item in a file list, but (with HAVE_GNUMAKE_FILE_FUNC)
      the gb_HelpTarget_get_translation_target .filelist files (which are then
      transformed with sed into the .html .filelist files read by the Perl packaging
      code) may contain such trailing white space.  So $(strip ...) their content in
      This is the core part of a change spanning core and helpcontent2.
      Change-Id: I82e0093ea2064725327330c5485f8e581573e1f2
  28. 25 Nis, 2018 1 kayıt (commit)
    • Mike Kaganski's avatar
      Install UCRT from MSUs, not using nested VC Redist install · b8424437
      Mike Kaganski yazdı
      Using nested install is bad because (1) MS advises against it (though it
      most possibly doesn't relate to our specific case, when we install the
      vc redist exe package in UI part, so actually only a single MSI session
      is active at any time); (2) because it adds some extra interactions
      (user sees something "unrelated" being installed, which raises concerns;
      additional admin authentication required); and (3) because it runs in
      InstallUISequence, thus only installing the UCRT when doing interactive
      installation (unattended installs, including GPO, need to install UCRT
      This patch aims to incorporate the original UCRT MSU (Windows Update)
      packages (https://support.microsoft.com/en-us/help/2999226) available as
      a zip archive from
      - the same as used in VC redists for VS 2015 and 2017. This obsoletes
      the separate installation of the redist; since we also have the redist
      as merge module in our MSI, that is enough (and removes redundancy).
      The MSUs are installed using wusa.exe in a custom action (deferred,
      As a small bonus, embedding MSUs instead of redist EXE allows us to
      shrink the size of installer a little (~10 MB).
      As deferred custom actions cannot access current installer database,
      we workaround this by using initial immediate impersonating action to
      extract the binaries into a temporary location. To ensure that the file
      gets removed upon completion (both successful and failed), we use an
      additional cleanup action.
      Commit 61b1d631 is effectively reverted.
      Change-Id: I1529356fdcc67ff24b232c01ddf8bb3a31bb00bd
      Reviewed-on: https://gerrit.libreoffice.org/52923Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
  29. 18 Nis, 2018 1 kayıt (commit)
  30. 16 Nis, 2018 1 kayıt (commit)
  31. 12 Nis, 2018 1 kayıt (commit)
    • Mike Kaganski's avatar
      tdf#108580 related: improve existing redist detection · 1f8a3657
      Mike Kaganski yazdı
      This uses VC Runtime upgrade code (checked using Upgrade table) to
      find installed redist, instead of checking registry keys that change
      between versions (while the runtime is still compatible, as with 2015
      and 2017).
      Also, it checks if UCRT is present. Now, if either VC Runtime or UCRT
      is absent, we try to install the redist. This would allow to install
      UCRT in scenarios when first install was attempted on a system not
      suitable for UCRT (like Win7 w/o SP1, or Win8.1 w/o April 2014 update
      rollup), where VC Runtime gets installed, but UCRT is still missing.
      We use the ucrtbase.dll version to check that; and as the expected
      version is 10.x, we take into account that Win10 lies about versions.
      Change-Id: I864dfc09cf1bdc775501729fa2a27dc98295588c
      Reviewed-on: https://gerrit.libreoffice.org/52794Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
  32. 23 Ock, 2018 1 kayıt (commit)
  33. 19 Ock, 2018 1 kayıt (commit)
    • Michael Stahl's avatar
      scp2: also try VC141_CRT_*.msm · 2a055c05
      Michael Stahl yazdı
      Apparently the MSMs have been renamed in Visual Studio 2017.3 but only
      configure was adapted, not scp2.
      Not sure if these MSMs are still relevant given the new
      gid_File_Vcredist_Exe thing.
      Change-Id: I4fe27c8298b3a2024acc62d12ce8ea67e2eca80d
  34. 05 Ock, 2018 1 kayıt (commit)
  35. 18 Ara, 2017 1 kayıt (commit)
    • Mike Kaganski's avatar
      tdf#108580: integrate vc_redist.exe into MSI · 61b1d631
      Mike Kaganski yazdı
      ... in InstallUISequense.
      Use --with-vcredist-dir to point to a directory with vc_redist.x64.exe
      and/or vc_redist.x86.exe. Use --without-vcredist-dir (or
      --with-vcredist-dir=no) if you don't want to ship it as part of
      installer and want to silence the configure warning.
      VCRedist 2015 version 14.0.24215.1 is available at
      Since VisualStudio 2015, VC redist merge module that we used before
      started to work differently: it installs the UCRT only on WinXP,
      but not on later OSes (Vista to 8.1) which may lack the UCRT (Win10
      has it out of the box). The merge module only installs VCRuntime on
      those systems, which still leaves us with "api-ms-*.dll is missing"
      gives more information on VCRedist refactoring background.)
      Since commit 71d9a613, we use a
      workaround described at the page mentioned above as "App-local
      deployment of the Universal CRT". We just copy all UCRT DLLs to
      LibreOffice/program. This has a drawback though, that our UCRT
      is not updated by Windows Update, so users would rely on LibreOffice
      updates in case of some vulnerabilities in UCRT (and they could
      even not realize they have that problem).
      MS recommends to install UCRT using EXEs they provide from their
      site. The EXEs install both VCRuntimes and UCRTs, along with
      required patches, for all Windows versions (Windows XP through
      Windows 10, where they only install VCRuntimes); the installed
      libraries are managed by system's update mechanism. But those EXEs
      cannot be used in MSI custom actions inside InstallExecuteSequence,
      because they use MSI themselves.
      So this patch integrates the vc_redist.xXX.exe into MSI binary
      table, and uses custom action to run the EXE after ExecuteAction
      in InstallUISequence. This will show the user a VCRedist install
      window after the main LibreOffice installation finishes; no user
      interaction is required (except for one additional UAC request),
      and errors are ignored.
      Since this installation takes care of both VCRuntime and UCRT,
      we can ultimately drop both the app-local workaround, and
      vcredist merge module (so VCRuntime would also be updated by
      system). The former is done here: this reverts commit
      This approach has its drawback: if one wants to use unattended
      installation (without UI; one example is deployment using
      ActiveDirectory GPO), then InstallUISequence is not run, and so
      VCRedist isn't installed. In this case, one should install
      VCRedist separately. Supposedly this should not be huge problem,
      because this is the case for many existing applications that need
      separate VCRedist deployment in these scenarios, and unattended
      installation is advanced stuff that requires prepared user. A
      notice would be required in release notes and FAQ, though.
      Change-Id: Ia6a16be60af8a08f41ea7c3dbd457d8f89006006
      Reviewed-on: https://gerrit.libreoffice.org/46356Reviewed-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
      Tested-by: 's avatarMike Kaganski <mike.kaganski@collabora.com>
  36. 15 Ara, 2017 1 kayıt (commit)
  37. 14 Ara, 2017 1 kayıt (commit)