- 13 Şub, 2019 28 kayıt (commit)
-
-
Noel Grandin yazdı
since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by:
Noel Grandin <noel.grandin@collabora.co.uk>
-
Katarina Behrens yazdı
in SetAlwaysOnTop set window flags only, don't show the widget yet (it'll be shown later, when it can be painted in full) Change-Id: I5e855f1ebba1eb9985744ece055a0f141e965940 Reviewed-on: https://gerrit.libreoffice.org/67739Reviewed-by:
Katarina Behrens <Katarina.Behrens@cib.de> Tested-by:
-
Arkadiy Illarionov yazdı
From documentimport.cxx to validat.cxx Use range-based loop or replace with STL functions Change-Id: I59fb3ed20598e497b5653245f070298181da1331 Reviewed-on: https://gerrit.libreoffice.org/67587 Tested-by: Jenkins Reviewed-by:
-
Stephan Bergmann yazdı
It was added with 60f200ca "git-hooks: Copy them from the build repo", but I don't see its purpose, and it caused trouble for me now when trying to commit <https://gerrit.libreoffice.org/67672> "Merge in Flatpak improvements". Change-Id: I922b5be87549793466f99db8b12be6081e683292 Reviewed-on: https://gerrit.libreoffice.org/67674 Tested-by: Jenkins Reviewed-by:
Stephan Bergmann <sbergman@redhat.com>
-
Stephan Bergmann yazdı
As found out in 98c0b208 "Make Firebird the (unconditional) default for new databases": "(Curiously, ODsnTypeCollection::getEmbeddedDatabase would read a DefaultEmbeddedDatabase value from the configuration before resorting to the hardcoded default, but `git log -SDefaultEmbeddedDatabase` makes it look like there has never been any code to actually write that setting.)" Digging deeper, the story appears to be as follows: First, "INTEGRATION: CWS hsqldb" commits in 2004 had addded the EmbeddedDatabases group (and accompanying templates) to officecfg/registry/schema/org/openoffice/Office/DataAccess.xcs (ee11cb63), corresponding values (for HSQLDB) to officecfg/registry/data/org/openoffice/Office/DataAccess.xcu (60c5f0af), and code to read those values (lcl_getEmbeddedDatabase in dbaccess/source/ui/misc/dsntypes.cxx; ODsnTypeCollection::getEmbeddedDatabaseURL et al in dbaccess/source/ui/misc/dsntypes.cxx; all a68938bc). This looks like it actually worked. Then, "INTEGRATION: CWS dba24b" commits in 2007 removed the EmbeddedDatabases configuration data from officecfg/registry/data/org/openoffice/Office/DataAccess.xcu (473a3ccf, "during #i80930#: The approach to read the concrete type of the embedded DB from the configuration does not work, there are enough places where we silently assume 'embedded == embedded HSQLDB'") and removed the code reading it (79bbd382), but left the EmbeddedDatabases schema data in officecfg/registry/schema/org/openoffice/Office/DataAccess.xcs untouched. Then, b88a62cc "CWS-TOOLING: integrate CWS dbaperf2" in 2009 reintroduced code that attempts to read the configuration data as ODsnTypeCollection::getEmbeddedDatabase (dbaccess/source/core/misc/dsntypes.cxx). The reason for that may be "2009-05-06 14:22:21 +0200 oj r271589 : #i101587# use config for the drivers" as listed in the commit message. The code added as ODsnTypeCollection::getEmbeddedDatabase back then remained effectively unchanged until today, but looks fundamentally broken: It starts out with trying to read an /org.openoffice.Office.DataAccess/EmbeddedDatabases/DefaultEmbeddedDatabase/ Value property that can never be present per the schema (an /org.openoffice.Office.DataAccess/EmbeddedDatabases/DefaultEmbeddedDatabase property could be); so no data is ever actually read from the configuration by ODsnTypeCollection::getEmbeddedDatabase. (And the commit also didn't add back any configuration data to officecfg/registry/data/org/openoffice/Office/DataAccess.xcu that could have been read in the first place, nor any code to generate such data programmatically.) So remove the broken code to read configuration data from ODsnTypeCollection::getEmbeddedDatabase (which means it can be a static member function now) and also remove the obviously unused EmbeddedDatabases group (and accompanying templates) from officecfg/registry/schema/org/openoffice/Office/DataAccess.xcs. Change-Id: Icc9b34075b9b7e960df6c236d3595b7fabe71f9d Reviewed-on: https://gerrit.libreoffice.org/67494 Tested-by: Jenkins Reviewed-by:
-
Hamish McIntyre-Bhatty yazdı
Change-Id: Ie5c5f6296e54b1118f1182766473f3f70eb37385 Reviewed-on: https://gerrit.libreoffice.org/67722Reviewed-by:
Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by:
-
Hamish McIntyre-Bhatty yazdı
Mostly just clean up with pylint, and changing variable names to comply with the style guide. Change-Id: I7298fbbcf394de19acf66d10447676d7d822d6f0 Reviewed-on: https://gerrit.libreoffice.org/66198Reviewed-by:
-
Balazs Varga yazdı
Export the data label separator XML tag and the separated character to OOXML. Change-Id: I9b3bcb588e42a42494107ebde70f4a72492cfac4 Reviewed-on: https://gerrit.libreoffice.org/67753 Tested-by: Jenkins Reviewed-by:
László Németh <nemeth@numbertext.org>
-
Stephan Bergmann yazdı
Both of Draw's "Insert - Snap Guide..." and "Shape - Duplicate..." dialogs have MetricSpinButtons with ranges set programmatically in the dialogs' ctors. Computing the ranges' min and max values was done via SetMetricValue, which does any necessary unit conversions and then sets the MetricSpinButton's current value, which is then read back out in the dialog ctors (again, doing any necessary unit conversions) and finally set as the min or max range value. However, setting a MetricSpinButton's current value clamps it to the min and max range values that are currently in effect (i.e., before they have been set programmatically), so the corresponding .ui files specified very large initial values for those. Large enough so that any actually set current values will not artificially be clamped, but also so large that weld::MetricSpinButton::ConvertValue, which indirectly gets called during the above computations and converts from sal_Int64 to int, would produce Clang -fsanitize=implicit-signed-integer-truncation warnings (e.g., "implicit conversion from type 'sal_Int64' (aka 'long') of value -56692913386 (64-bit, signed) to type 'int' changed the value to -858338538 (32-bit, signed)" from within the CopyDlg ctor). So don't use SetMetricValue to compute the min/max range values. That way, the MetricSpinButton's current value is not set before the computed min/max range values are actually set, so the .ui file doesn't need to contain any static min/max range values. Also, both dialogs call SetFieldUnit, which also sets the MetricSpinButtons' increment values, so those don't need to be set statically in the .ui files, either. Change-Id: I191cfc3837278530e0c3a87e00708c4c76a76361 Reviewed-on: https://gerrit.libreoffice.org/67734 Tested-by: Jenkins Reviewed-by:
Caolán McNamara <caolanm@redhat.com> Tested-by:
-
Takeshi Abe yazdı
... for My Documents and My Templates. It seems customary to name XDG_*_DIR in all uppercase. This also fixes buffer overrun IIUC, as osl_readLine() does not return the newline delimiter. Change-Id: If85ca7e6abe663e29d36b65a08d358d3d7d27c4b Reviewed-on: https://gerrit.libreoffice.org/67741 Tested-by: Jenkins Reviewed-by:
-
Samuel Mehrbrodt yazdı
Change-Id: Iede1d3321e909329cb0754a26e5b4bee4bb60316 Reviewed-on: https://gerrit.libreoffice.org/67752 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
Change-Id: Id16726ad6f0cd5aeae0b55c817d02b315506e863 Reviewed-on: https://gerrit.libreoffice.org/67747 Tested-by: Jenkins Reviewed-by:
Miklos Vajna <vmiklos@collabora.com>
-
Miklos Vajna yazdı
Fix various cases which trigger this warning: warn:legacy.osl:10975:10975:sw/source/core/txtnode/swfont.cxx:427: Unsupported direction Which means that we tried to work with a VCL direction of 900, without passing around the btlr flag accordingly. Change-Id: I96374fc949f60e8324c5a84de48b710b6461bafb Reviewed-on: https://gerrit.libreoffice.org/67746 Tested-by: Jenkins Reviewed-by:
-
heiko tietze yazdı
Checkboxes moved above the listbox Change-Id: I8f4ef437815741e26032f47c952c32d3e5d7db56 Reviewed-on: https://gerrit.libreoffice.org/67712 Tested-by: Jenkins Reviewed-by:
Mike Kaganski <mike.kaganski@collabora.com>
-
Matteo Casalin yazdı
Change-Id: I38b916d217af05359754925f2ae68351486aa399 Reviewed-on: https://gerrit.libreoffice.org/67639 Tested-by: Jenkins Reviewed-by:
Matteo Casalin <matteo.casalin@yahoo.com>
-
Matteo Casalin yazdı
... image resolution: introduce local method to: * use indexed getToken * avoid getting all tokens in advance * reduce calls to non-trivial getString method Change-Id: Ib47c2e9bb5788132328fbda1b1dce05e495ad3ed Reviewed-on: https://gerrit.libreoffice.org/67638 Tested-by: Jenkins Reviewed-by:
-
Matteo Casalin yazdı
Change-Id: Ibd9d23b914645fdf52403c6c9d90a4058f2cf406 Reviewed-on: https://gerrit.libreoffice.org/67637 Tested-by: Jenkins Reviewed-by:
-
Matteo Casalin yazdı
Change-Id: Iac7b4caf58706e153981be7994cba1929520f44c Reviewed-on: https://gerrit.libreoffice.org/67636 Tested-by: Jenkins Reviewed-by:
-
Matteo Casalin yazdı
Change-Id: I070cd4903a1aae0c5b22f0991ebf274b8dc09974 Reviewed-on: https://gerrit.libreoffice.org/67632 Tested-by: Jenkins Reviewed-by:
-
Matteo Casalin yazdı
Change-Id: Ib018761e35841a5128a2ef1a7318ce7fac448e5c Reviewed-on: https://gerrit.libreoffice.org/67630 Tested-by: Jenkins Reviewed-by:
-
Matteo Casalin yazdı
Change-Id: I393c53d7501afc6cd75a4c463031db94574b4ec7 Reviewed-on: https://gerrit.libreoffice.org/67629 Tested-by: Jenkins Reviewed-by:
-
Matteo Casalin yazdı
nType was defined as sal_uInt32, but initialized by a toInt32 and provided to setAutoloadSecs() which accepts sal_Int32. Change-Id: I78eb5426ddab7726ee538005cc3aa732b66ce1bf Reviewed-on: https://gerrit.libreoffice.org/67628 Tested-by: Jenkins Reviewed-by:
-
Matteo Casalin yazdı
Change-Id: I907c108f4b056d3388464e29ce2fc40b319380c0 Reviewed-on: https://gerrit.libreoffice.org/67627 Tested-by: Jenkins Reviewed-by:
-
Matteo Casalin yazdı
Change-Id: I7a9ee6cb1e5fd9dac917d236bfd612100828c087 Reviewed-on: https://gerrit.libreoffice.org/67626 Tested-by: Jenkins Reviewed-by:
-
Matteo Casalin yazdı
Change-Id: Ia95c9f78978c2299382ffdec603e44b06299549e Reviewed-on: https://gerrit.libreoffice.org/67625 Tested-by: Jenkins Reviewed-by:
-
Matteo Casalin yazdı
Change-Id: Ie5aa54192c537738a37e348d00642f606295d985 Reviewed-on: https://gerrit.libreoffice.org/67624 Tested-by: Jenkins Reviewed-by:
-
Matteo Casalin yazdı
Change-Id: I0233ee1abefa5dc54835a2ce5f7be52ab9586262 Reviewed-on: https://gerrit.libreoffice.org/67623 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I036a41bd4d46973a8b6fb51a90c6506cf3f9b8f0 Reviewed-on: https://gerrit.libreoffice.org/67748Reviewed-by:
Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by:
-
- 12 Şub, 2019 12 kayıt (commit)
-
-
Zdeněk Crhonek yazdı
Change-Id: I0a42b68a29023a12557ac2de523fb80fd970d17b Reviewed-on: https://gerrit.libreoffice.org/67743 Tested-by: Jenkins Reviewed-by:
Zdenek Crhonek <zcrhonek@gmail.com>
-
Caolán McNamara yazdı
Change-Id: I197a917458fdd75b08f888deac1926dc363202d5 Reviewed-on: https://gerrit.libreoffice.org/67735 Tested-by: Jenkins Reviewed-by:
-
Zdeněk Crhonek yazdı
Bug 123231 - Chart set trendline format regression type Power twice Change-Id: Ic3a01af6fe90f1183663551f6c625219a185ccb5 Reviewed-on: https://gerrit.libreoffice.org/67731 Tested-by: Jenkins Reviewed-by:
-
Andrea Gelmini yazdı
Change-Id: I66dcbda8d91d05229b2c6c9185a4d02ce5361294 Reviewed-on: https://gerrit.libreoffice.org/67742Reviewed-by:
Julien Nabet <serval2412@yahoo.fr> Tested-by:
-
Miklos Vajna yazdı
The bulk of this commit is reasonably straightforward, the interesting parts are: - SwFrame::CheckDir() is where the layout reads the doc model, i.e. sets the new SwFrame::mbVertLRBT. - We had 3 text directions previously: horizontal, vertical (implicitly RL) and vertical LR (implicitly TB). This adds a 4th text direction for the LRBT case. - SwTextFrame::SwitchHorizontalToVertical() is responsible for re-locating the origo of a string to be painted from the top left to the bottom left corner (in addition to the height/width swap that's done for all vertical directions). - Finally MapDirection() is the place where we map Writer's new btlr mode (with no character rotation) to VCL's 900 (90 degrees) rotated direction. No functional changes intended for existing text directions. Lots of places are still not yet adapted, but this is good enough to paint a single word in a table cell at the correct position with the correct direction. Change-Id: I465c62db6562d8a2be140c3d37473e590830139e Reviewed-on: https://gerrit.libreoffice.org/67740Reviewed-by:
-
Michael Stahl yazdı
This is not and has never been a unit test; let's remove it to avoid confusion. Change-Id: I42a5e8f9d2f9757bcc9e0c6051e5d86ffc6e023f Reviewed-on: https://gerrit.libreoffice.org/67732Reviewed-by:
Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
-
Caolán McNamara yazdı
Change-Id: I8fc25d254781b31e4ffafcf4397a95d79e042cd8 Reviewed-on: https://gerrit.libreoffice.org/67736 Tested-by: Jenkins Reviewed-by:
-
Jens Carl yazdı
Change-Id: Iaa78c63503748c3c953a39193138239babf7a011 Reviewed-on: https://gerrit.libreoffice.org/67707 Tested-by: Jenkins Reviewed-by:
Jens Carl <j.carl43@gmx.de>
-
László Németh yazdı
(visible sheet) of an embedded spreadsheet, instead of exporting always the first sheet. Change-Id: I5c6f982b1b814a5f3830f08d247f4db3fdc3c384 Reviewed-on: https://gerrit.libreoffice.org/67733 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
The custom code in SwXCell::setPropertyValue() was added in commit 5a559765 (tentative fix for fdo#30474#, 2010-11-26), which suggests that not handling all constants from text::WritingMode2 was not intentional. Later the writerfilter side (which is the only client of this hidden property) was adapted to use text::WritingMode2, so do the same here. This implicitly adds support for the new text::WritingMode2::BT_LR as well. Change-Id: I37d8eaa844847cb19e7503b2d973069f9895e6bc Reviewed-on: https://gerrit.libreoffice.org/67730Reviewed-by:
-
Gabor Kelemen yazdı
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: Ic91b7170b10299001167e78ade1d24c16ce9319e Reviewed-on: https://gerrit.libreoffice.org/67475 Tested-by: Jenkins Reviewed-by:
-
Miklos Vajna yazdı
btLr is not a writing mode that would be used by any natural language, the reason it makes sense to support this is that the Word UI makes it easy to rotate text 90 degrees counter-clockwise for Latin (lrtb) text, which then triggers this feature. This is common in the first column of tables to create text that looks like a row header. An import-time workaround to handle <w:textDirection w:val="btLr"/> was added in commit c2d1ab73 (tentative fix for fdo#30474#, 2010-11-26), but rotating text at a text portion level has various unwanted side effects, just counting my own fixes, I had 7 workarounds on top of that workaround to hide problems where the root cause is this missing writing direction in sw core. This commit just extends the sw core doc model, everything else is to be done in follow-up commits. Change-Id: I89e02cd4b40de78699dbf14885fc128e870de3b8 Reviewed-on: https://gerrit.libreoffice.org/67717Reviewed-by:
-
