Keep the overline color in DevOutState so that it can be
used in text actions later.

Change-Id: Ia584de9b78e1adf6862c09fb50cbed1f16e2ad0b
Reviewed-on: https://gerrit.libreoffice.org/62829
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

Change-Id: Id97c9ead810f266239898cc559172b841bc6902f

In order to eventually get the Calc-specific dialogs in the mobile
app, too.

Change-Id: I30b64512b38d37ceab5706851c211ff5cf73764e

We will call it just a few lines later.

Change-Id: Id979fb7fdaebd05f2432d8917b921d1b1779d8a7

to get rid of one of the initEffectLinePolyPolygon we used.

Change-Id: I04c6e1dc72e1f3936bfd268a3b1092bdc4a9b199
Reviewed-on: https://gerrit.libreoffice.org/62828
Tested-by: Jenkins
Reviewed-by: Mark Hung <marklh9@gmail.com>

..only if java is enabled:

Change-Id: Iaf210e7044e854545518336ed7a40ce615443356
Reviewed-on: https://gerrit.libreoffice.org/62882Reviewed-by: Tamás Bunth <btomi96@gmail.com>
Tested-by: Tamás Bunth <btomi96@gmail.com>

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ic5d0dd8c712e74825ed0d0de6bf366568ca48f25
Reviewed-on: https://gerrit.libreoffice.org/62460
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I9f87913ce537e634f8c10ddfee59002293c1fc3f
Reviewed-on: https://gerrit.libreoffice.org/62872
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I07e57ea7d9e6af1c7543483b1ab54a0b8c5be2d5
Reviewed-on: https://gerrit.libreoffice.org/62640
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>

...as long as they are not WB_NOTABSTOP of course,
just like checkboxes.

Even though all of the radio buttons are now marked
as WB_TABSTOP, the tab still only stops once inside
the radio group. That's perfect.

Without this, if none of the radio boxes was checked,
then the entire group was tab-skipped.

As a copy/paste programmer, I don't know how to
test this because there were no close enough examples
to follow.

Change-Id: I3c559fb274d736cbd2f56a6a8ddc1ca5a2cfe681
Reviewed-on: https://gerrit.libreoffice.org/62822
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Let SbiInstance::GetRTLData() return reference

Change-Id: Iafe7e64f6f296b478003ce66ea66936a65ba9edc
Reviewed-on: https://gerrit.libreoffice.org/62855
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

...after e06afb0c "Simplify containers
iterations in ucb, ucbhelper"

Change-Id: I03b9408ea12be2a1b1b620bd2decf5658356a452

Change-Id: Ie34d8c26bfbf4192cd2067c8315030903edb3fb3
Reviewed-on: https://gerrit.libreoffice.org/62274
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>

The inner check looks suspicious. Still, I don't think that intended
behavior was to check nFillDefault, because in that case the next
line would likely start with "else if".

The change just keeps current behavior; I make this an individual
commit to keep the decision's context.

Change-Id: I67d37aa0fee82190ce4bba5784b76c9f522b97ff
Reviewed-on: https://gerrit.libreoffice.org/62864
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

from all locations other than panel content

Change-Id: I85a113d3001338dd1aff27bac75a5debd4635d59
Reviewed-on: https://gerrit.libreoffice.org/62808
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

Change-Id: Ifa5d52ffed32a4fe0bfe75fb731ee79d0976c0cf
Reviewed-on: https://gerrit.libreoffice.org/61949
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

This patch allows the new background/highlighting tab page and derived
from area tab page to work correctly in the same tab dialog. It also
provides a cleaner way to use the new background tab page by setting
brush item as fill attributes to target set in the background tab page
created method.

Previously if the new background tab page and the area tab page were
used in the same tab page dialog one would affect the other due to the
same use of pool fill items. This patch makes a local copy of the
attribute item set passed and then passes that set along to the parent
class area tab page on each activation/deactivation.

Tab page dialogs that use both the background and area tab pages are:
Writer Paragraph Styles, Impress Presentations Styles and Drawing/
Graphics Styles, and Draw Drawing/Graphics Styles.

All new background tab page merged patches have been reworked in this
patch and remaining old background tab pages, with the exception of
Report Design, have been replaced by the new tab page.

Change-Id: I47f9ae10a0fd967729ff6e83c1a312aa49e1d13c
Reviewed-on: https://gerrit.libreoffice.org/57102
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>

just use OUStringBuffer here, and consequently avoid re-implementing
such string-buffer handling code

Change-Id: I61e39dada6f46478b9d289f0310bb6846eb9868b
Reviewed-on: https://gerrit.libreoffice.org/62646
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Change-Id: I8217b1a0b6ccc29052257d54ba7844c0970ad9a4
Reviewed-on: https://gerrit.libreoffice.org/62859
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I4b48dddeaabf6b321196b537bb7aa55a89ab8fe3
Reviewed-on: https://gerrit.libreoffice.org/62863
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

This partially reverts commit 2a3f5d11
to reimplement the proper index check. Thanks to Svyatoslav Razmyslov.

Change-Id: If0928eed8ff137efbb2d7605135375d147e9accf
Reviewed-on: https://gerrit.libreoffice.org/62862
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

The old implementation grouped radio buttons if their
object name was the same, and didn't have a groupname property.

The old implementation still works - so that still needs to be
supported, which this patch ensures.

Change-Id: Ied6ddc52d1c4ab5bca56b14da51258460ca2120c
Reviewed-on: https://gerrit.libreoffice.org/62812
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

The previous implementation grouped radio buttons if their
object name was the same. Likely this is a very old implementation,
because the current radio buttons have a groupname property which
links them together (although that too needed fixing in doc/docx),
and their object names are unique.

The old implementation still works - so that still needs to be
supported, but I think I'll do that in a separate patch, so
that it can be easily reverted if the old implementation is
deprecated.

Edge cases tested:
-groupID of 0 works fine - doesn't have to be 1-based.
-empty group name works fine (but breaks the old impl).
-writer, calc,

Change-Id: I84aebdac18b9edfa5ffcbfb23c15d0f37fcd47d1
Reviewed-on: https://gerrit.libreoffice.org/62742
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>

This patch is sponsored by ULAKBIM/Pardus project.
Signed-off-by: Mert Tumer <merttumer@outlook.com>

Change-Id: I6361e3d23b03e5463d165f7f02dacad8be9206da
Reviewed-on: https://gerrit.libreoffice.org/62861
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.1004@gmail.com>

Allows to call uno:RenamePage from the android viewer and LibreOffice
online. This patch is sponsored by ULAKBIM/Pardus project.

Change-Id: Ife814846bd7076e9f8830bce4c2451cb6b44a15a
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/62860

Change-Id: Ia073dcbf0a0a4d2f3df1f58d0e140f68e830182b
Reviewed-on: https://gerrit.libreoffice.org/62856Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I2f03cd950d37fc00ab4fe71693e717e82f242254
Reviewed-on: https://gerrit.libreoffice.org/62851Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I200a7be1eefdd2764e79b31ba1950a7b3d97d0b4
Reviewed-on: https://gerrit.libreoffice.org/62850
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I794ec0a173fb20dc0e0d1cf1717a5ad903f9ba7d
Reviewed-on: https://gerrit.libreoffice.org/62848
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: If54c26f66466ee591d198aaf3f8f68ba04e5f4b3
Signed-off-by: Mert Tumer <merttumer@outlook.com>
Reviewed-on: https://gerrit.libreoffice.org/62774
Tested-by: Jenkins
Reviewed-by: Gülşah Köse <gulsah.1004@gmail.com>

Regression from 39e0bbfd

Change-Id: Ibb0dea1a78ccf3ef446bbbaad28945f1ac8bdf48
Reviewed-on: https://gerrit.libreoffice.org/62834
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I5ae1c023bfff4f5d45f8ea8104a58dbd89a5d983
Reviewed-on: https://gerrit.libreoffice.org/62852Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Also fix an infinite recursion when VCLXHatchWindow::getTypes() called
VCLXHatchWindow::getTypes() when initializing its static.

Change-Id: I19b8b1e1b367ddf636f905fb141c7690e21f67f8
Reviewed-on: https://gerrit.libreoffice.org/62825Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ia34b3b326fa48e92f3172b9930c0a985fda6022d
Reviewed-on: https://gerrit.libreoffice.org/62849Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

fixing up the bit that failed the last time

Change-Id: I235f8f92cbc0c3e31837e01a9b094580c6f5aecf
Reviewed-on: https://gerrit.libreoffice.org/62786Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I3432afca1ee9bf9e8adce1d55d58d57bf1a09cb4
Reviewed-on: https://gerrit.libreoffice.org/62847
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

a2058e75 follow-up.

Change-Id: I402cbab4f78daf0de9d1bfa88698d2b071fcabaf
Reviewed-on: https://gerrit.libreoffice.org/62840
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: I1bf67196e97411aeecc13ed4f91d1088a315e323
Reviewed-on: https://gerrit.libreoffice.org/62839
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

Change-Id: Ie1aae7ecbd065a88b371d8c0deb586f54f7eff65
Reviewed-on: https://gerrit.libreoffice.org/62835
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

...after 16b2b4f2 "Simplify containers
iterations in sw/source/ui*"

Change-Id: If94cd1b242debe44871fbaa050d270e06bf0171b