Change-Id: Id276015425ea7de3cf55b9ef21b4e7ce54c2ce47

Change-Id: I3681d119dda85400dbb33c96fab736c262f7ce8a

Change-Id: Iafaaafdabf9fb7947fa0b03cd38d3b4a567a41b9
Reviewed-on: https://gerrit.libreoffice.org/48110Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>

Change-Id: I853a949e68d192c48a90321a8b3b75a5d443638b
Reviewed-on: https://gerrit.libreoffice.org/48111Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>

...as the UNO_QUERY_THROW above would already have caused an exception

Change-Id: Ie0453b67716c64ddaddfa6becd498952a497be63
Reviewed-on: https://gerrit.libreoffice.org/48106Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

A condition was added in order to not make subtotal
functions if category was not checked.

Change-Id: I56f11330fa16bf0d3199576ce2545cbc8d13e864
Reviewed-on: https://gerrit.libreoffice.org/48099Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

Change-Id: I634c1132265295f90f624a53b93dddb2b18eabd5

Change-Id: I74b57cd510b1babbb4a537d307a6ffc9ee1d9ce5

Change-Id: I4b37be72ebec86b9360ea2594b26815ddaab60cd

Change-Id: Ib9595b1e0fe888a6698c3c508a24390d3798b3e4

...instead of having to add it to more and more individual .cxx files, as the
need arises.

Change-Id: If1e893c79abf1c1bb7fb7b89dcb9bd423a7f1b94
Reviewed-on: https://gerrit.libreoffice.org/48108Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: If7942ec9d4cd40f29fae2b9a8f76df1ef08bfc17
Reviewed-on: https://gerrit.libreoffice.org/48120Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>

current android-gradle plugin creates the apk in dimension/flavor/variant
(whatever you want to call it) specific directory

Change-Id: I5514fe53c5c8c556d194a0f06ad6167b0b1cc98e

Change-Id: I5af76b87c3793c7ec7ac41ab25bb4de5d81fc3cf
Reviewed-on: https://gerrit.libreoffice.org/48123Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

...by giving each test its own mxComponent.

At least my Windows builds started to fail CppunitTest_sc_tabviewobj with

> C:/lo/core/test/source/sheet/xviewsplitable.cxx:36:sc_apitest::ScTabViewObj::testSplit
> equality assertion failed
> - Expected: 1
> - Actual  : 0
> - Wrong column

after 95307f2c "tdf#45904 Move
_SpreadsheetViewSettings Java tests to C++" added the call to
testSpreadsheetViewSettingsProperties ahead of the call to testSplit.  (And
allowing multiple tests to work on shared state and interfere like they
apparently do here seems rather brittle in general.)

Change-Id: I73a60ae3c703e59852c8e16b09f5897849f5bdf4
Reviewed-on: https://gerrit.libreoffice.org/48070Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

as floating toolbars aren't movable there.

Change-Id: I543344946f02d5a336ff738b4d6d9f9b21c595e9
Reviewed-on: https://gerrit.libreoffice.org/48096Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

and remove the one from ImplPopupFloatWin. Implemented using
the FloatWinTitleType::TearOff case, which was unused otherwise.

Change-Id: I82a86e5f5897ce1f2e76a2404bb382cbc007700c
Reviewed-on: https://gerrit.libreoffice.org/48095Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>

ImplPopupFloatWin draws the window title and frame directly on the client
window, which is incompatible with .ui layouts, as they try to occupy the
whole available space. Instead just use a plain FloatingWindow whenever
possible, and change the border window code to mimic the behavior of
ImplPopupFloatWin, wrt removing part of the frame of toolbar popups w/o a
title.

Change-Id: If72ea89e31f913470faad7fcb8083f9b9787c9a8
Reviewed-on: https://gerrit.libreoffice.org/48094Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>

since...

commit 84392651
Date:   Wed Jan 3 23:27:16 2018 +0100

    tdf#114173 Preserve size of chart legend during xlsx export

Change-Id: Iebc936a0f490d6b707dfee0343732753f56728e7
Reviewed-on: https://gerrit.libreoffice.org/48147Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I3c0b0603d1e03f1cc19af4324dd2b909320d9d4a
Reviewed-on: https://gerrit.libreoffice.org/47687Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>

Also adjust to dynamic permissions after bumping target-SDK.

There still is some confusion about the concept of "external storage" in
the code. LocalDocuments already is "external storage" - clean that up a
little and use AppCompat function instead of using a legacy class for
ExternalDocuments provider.
Doesn't help for broken ROMs though, that would need guessing pathname
for a mounted SD (in addition to separate storage partition of builtin
storage).

Also c6e8c96d incorrectly changed the
conditional around, making the whole ExternalDocumentsProvider useless/a
copy of the Local one (i.e. the primary, first returned by the system).
Real fix for tdf#99539 likely was 66be4fee

Change-Id: I88ca7742c0f2e89d63c338c8852ad88be0a46e4b
Reviewed-on: https://gerrit.libreoffice.org/45572Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

see 90d21559 for boost fix and
see effe6b3d for bridges fix for mac

Change-Id: Ic6209ce0927dafd39763ef0b2fabbcaa7abf743f
Reviewed-on: https://gerrit.libreoffice.org/46002Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>

Project: help  c4a18626d14426cbd8884d1028eb248fe3b21c44

Fix typos

Change-Id: Idcdc1e802dcca33aa2ed2499d4c5c4d15767026f
Reviewed-on: https://gerrit.libreoffice.org/48138Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>

Project: help  45e20af8857f8bcd5afa30113eea40ceef7aa3a8

Fix typo

Change-Id: If3ae78fab316a0eaab5b0aeecd41824665a4d498
Reviewed-on: https://gerrit.libreoffice.org/48139Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>

This 75-byte horror creates 2 nested tables, where one SwTableBox is in
the SwTableLine of the inner SwTable but in the SwSortBoxes of the outer
table, which is of course invalid.

The root cause is that in SwHTMLParser::SplitAttrTab(), we move the
m_pPam backward once and forward twice, moving it ouside the inner
table.

Change-Id: I63f6508afe1270ccdeb05da6f222b0aba5259889

Change-Id: I633e4921042809c628e55825b70c540767eba1d3
Reviewed-on: https://gerrit.libreoffice.org/48140Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I2e60032c1a306742cd73aef8579a0f082fe1a366
Reviewed-on: https://gerrit.libreoffice.org/48141Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>

Change-Id: I69e3f2145f95424e7c524127492fd7f8a03ed3ca
Reviewed-on: https://gerrit.libreoffice.org/48091Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: I3756bd472b4e54db1d1c9da382d5d655f472bdb7
Reviewed-on: https://gerrit.libreoffice.org/48080Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: Ieaf440abf819d503d388a8b060dbf7fe6548db9e
Reviewed-on: https://gerrit.libreoffice.org/48073Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: Idcdbfb1366db61e247c31eab5cb27a39978b0fd9
Reviewed-on: https://gerrit.libreoffice.org/48055Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

This actually also converts the Style -> Edit Style... at the same time.

Change-Id: I4c09fcdfd7a543cce613eaa3620d0b623540d7e8
Reviewed-on: https://gerrit.libreoffice.org/48043Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>

Change-Id: Ic0e0c6cfd4b6d79f7c3807ac4300f30343269dea
Reviewed-on: https://gerrit.libreoffice.org/48042Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>

gnustl (and others) are to be removed in future versions of the ndk
also bump gradle and build-tools to current versions along with it

arm unfortunately crashes with llvm-c++, so keep with gnustl for now/fix
that later

Change-Id: Ic794c3293b599b77ec48096bf3283a99c09cbb79
Reviewed-on: https://gerrit.libreoffice.org/45163Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>

... otherwise the cursor in the document goes invisible as soon as the
dialog is launched.

Change-Id: I77bc30879550b354e1a9593db3c2db7ad3c68193
Reviewed-on: https://gerrit.libreoffice.org/48126Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>

Change-Id: Ic2b7d139ebb6e88fac5cf9f4cf8dbec26905bcdc
Reviewed-on: https://gerrit.libreoffice.org/48097Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

as this is more l10n/translation friendly

Change-Id: I1050fb24e0d6e94a2f1ad1605003a9c7010ca7cb

Change-Id: I2587fbc4fec39b6f2c8e733331815a2953dee308

Function declaration got lost in the different gerrit patches

Change-Id: Iec2b0449c0c6e41fb1b5568d6f5651b697a2daa5

This reverts the translations submodule change of commit
072e3ce1, which was not intentional.

Change-Id: Icdeefe17e2d70b62221b61419b45e18e1317fb9a