Skip to content

C
core
Dal (branch)/etiket değiştir
  1. 24 Eyl, 2018 1 kayıt (commit)
  3. 17 Eyl, 2018 1 kayıt (commit)
    • Stephan Bergmann's avatar
      New loplugin:external · 206b5b26
      Stephan Bergmann yazdı 
      ...warning about (for now only) functions and variables with external linkage
that likely don't need it.

The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

returns 1, both moving just the struct S2 into an nunnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    namespace { struct S2: S1 { int f() { return 1; } }; }
    int f(S2 s) { return s.f(); }
  }
  int main() { return f(N::S2()); }

as well as moving just the function f overload into an unnamed namespace,

  struct S1 { int f() { return 0; } };
  int f(S1 s) { return s.f(); }
  namespace N {
    struct S2: S1 { int f() { return 1; } };
    namespace { int f(S2 s) { return s.f(); } }
  }
  int main() { return f(N::S2()); }

would each change the program to return 0 instead.

Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      206b5b26
  5. 14 Nis, 2018 1 kayıt (commit)
  7. 23 Eki, 2017 1 kayıt (commit)
  9. 31 Agu, 2017 1 kayıt (commit)
  11. 28 Tem, 2017 1 kayıt (commit)
  13. 06 Tem, 2017 1 kayıt (commit)
  15. 12 Haz, 2017 1 kayıt (commit)
  17. 07 May, 2017 1 kayıt (commit)
  19. 06 May, 2017 1 kayıt (commit)
  21. 21 Nis, 2017 1 kayıt (commit)
  23. 11 Mar, 2017 1 kayıt (commit)
  25. 02 Mar, 2017 1 kayıt (commit)
  27. 26 Ock, 2017 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Remove dynamic exception specifications · e57ca028
      Stephan Bergmann yazdı 
      ...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574Tested-by: 's avatarJenkins <ci@libreoffice.org>
Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      e57ca028
  29. 20 Ara, 2016 1 kayıt (commit)
  31. 09 Haz, 2016 1 kayıt (commit)
  33. 20 Nis, 2016 1 kayıt (commit)
  35. 18 Nis, 2016 1 kayıt (commit)
  37. 13 Nis, 2016 1 kayıt (commit)
  39. 22 Mar, 2016 1 kayıt (commit)
  41. 15 Şub, 2016 3 kayıt (commit)
  43. 09 Şub, 2016 1 kayıt (commit)
  45. 10 Ara, 2015 1 kayıt (commit)
  47. 30 Kas, 2015 1 kayıt (commit)
  49. 26 Kas, 2015 1 kayıt (commit)
  51. 10 Kas, 2015 1 kayıt (commit)
  53. 06 Kas, 2015 1 kayıt (commit)
  55. 04 Kas, 2015 1 kayıt (commit)
    • Noel Grandin's avatar
      yyyyy · 59b072e2
      Noel Grandin yazdı 
      Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
      59b072e2
  57. 29 Eki, 2015 1 kayıt (commit)
  59. 15 Eki, 2015 1 kayıt (commit)
  61. 14 Eki, 2015 1 kayıt (commit)
  63. 12 Eki, 2015 1 kayıt (commit)
  65. 15 Eyl, 2015 1 kayıt (commit)
  67. 07 Agu, 2015 1 kayıt (commit)
  69. 11 Haz, 2015 1 kayıt (commit)
  71. 01 Nis, 2015 1 kayıt (commit)
  73. 23 Mar, 2015 1 kayıt (commit)
  75. 18 Kas, 2014 1 kayıt (commit)