Change-Id: I16e0c1adf854c3a2fa8d945724270d2d87461b39
Reviewed-on: https://gerrit.libreoffice.org/67192Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins

Change-Id: I2040315707674dc99a37aedb96ac61dca274c13a
Reviewed-on: https://gerrit.libreoffice.org/47348Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>

I (tried to) keep the RTF filter style consistent locally with astyle in
the past, but now that's redundant when we have an enforcing
clang-format mechanism in place. So drop the astyle config and switch to
clang-format in the RTF filter case.

To minimize backport pain, do this shortly before the libreoffice-6-0
branch-off.

Change-Id: I708dbeb0b5ad2afacc90029ee5abba9495f4601f

To test: make CppunitTest_writerfilter_rtftok

These crash triggering instances were hidden by the presense of \super
in topcontext-2.rtf - so I copied it, and only removed \super.

My fix for tdf#109382 triggered a unit test failure for one
missing m_xTextFactory. It seemed safe enough to test for all of them
that aren't in try/catch blocks, not just for the specific
instance I can prove with the test.

Change-Id: I1e317e05f9bcbbb14360941ce07af1bdf0edac6a
Reviewed-on: https://gerrit.libreoffice.org/41060Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: Icb3c640e04416f9120d37558646a570daeddf0a4
Reviewed-on: https://gerrit.libreoffice.org/28825Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I033454670d1ee662bc80bc07578690155d97ce28
Reviewed-on: https://gerrit.libreoffice.org/28805Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

but we only use the RTFParserState to use its m_pDocumentImpl and
the m_pDocumentImpl is never changed for the RTFParserState lifetime,
so take the m_pDocumentImpl at ctor time instead and use that
directly later

Change-Id: I15152e3f6d9008553b4a384a5e5da21373904cc9
Reviewed-on: https://gerrit.libreoffice.org/28802Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I8e881871b1ae4dea757263d04796779e62e168dc
Reviewed-on: https://gerrit.libreoffice.org/28693Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: I5d208bb2a85d7aa4eea9b1c950eeb6f35493f759

Change-Id: I2045ce82a1d536ab566e6a1218bea9c6a6696024

Change-Id: Ibb4cadb58aa17eacfc9741f7f13c780be347cd8b

Change-Id: I51736459f9f098d9d793bff3b9a1a403962e099d

and a m_xTextFactory check too

Change-Id: I9352410c42048b4dd7d6dbc3514351ab8f16790b

Change-Id: I4a135a9f9ac2f16f9dab096f5c234ff1d6e5e853

Change-Id: Ic8dd72da175fee656889910b55d31ea161b944cc

Change-Id: If3148cb6e16cff4aad28c4f86467c66ed04bcd05

Change-Id: I84bf3788ac092c491d7c5a9f86421f1cf9f3e814

Change-Id: Icdd71733c4e9f4b36e6e957e4dea772087890faa

rather than spend the rest of my life protecting each one

Change-Id: I181df33b052a0303f072ce0252d98562231569e2

Change-Id: I05dfffced9a8677650a46b43f65a29e9b21c5524

Change-Id: Ia7f7ace8130d5dfe290207e0cd3d2e6a43b8ab46

Change-Id: I16db4e16e5c2fa3aa3bfb22f83d2c36695499b5c

(as some tests derive from the latter only for the Directories part, not for the
setUp/tearDown overrides: those tests will be cleaned up next)

Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f
Reviewed-on: https://gerrit.libreoffice.org/23078Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

Change-Id: Ia62de30ae94bdae87cd5109c44eab40af4d020e5
Reviewed-on: https://gerrit.libreoffice.org/22985Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

to catch calling params with defaults like "= OUSString()"

Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9
Reviewed-on: https://gerrit.libreoffice.org/22932Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

Change-Id: Ia08c184b792ff73d3ed49d6a5d54dec1a35943e9
Reviewed-on: https://gerrit.libreoffice.org/21955Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

Change-Id: Idb0865f4d0db6c4eda33810ab2ef4cff49bc85d1

Experimenting with different non-alpha characters in front of
field, most of them aren't allowed and result in field not
recognized by MS Word: #$%&'()*+,-./:;<>?@[]^_`{|}~
Besides, if backslash "\" is followed by another backslash or
space, it is illegal, too. This patch takes care of it.

On the other side, not closing quotes is allowed by MS Word.
This patch allows this, too.

The patch does not handle another allowed field code "=2+2".
This should be done in another commit.

Change-Id: I842fe59c026b68977e61a7ae0b5495c02803ad83
Reviewed-on: https://gerrit.libreoffice.org/20435Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>

Change-Id: I31a69a997098eb1807361b8049c3312a4f287d75

Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274

Change-Id: I92de8fa6a48dac9a0a09e6ebda4af9b8e4c3a1d7

Especially the 'using namespace std' is scary, now that we have
std::shared_ptr and boost::shared_ptr, too.

Change-Id: Ibb584281f1b9d56103ab5984473eb484157c12d5

Change-Id: I7e53cfc90cefd9da7d6ecd795b09214bd44b1613

of which there are several.

There are some issues here I am unsure of
- the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids
  Perhaps I should change them to use the common values and create new enum values where necessary?
- the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff
   numeric values to the underlying code, but perhaps further fixing is necessary?

Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923

Change-Id: I0238d8f4ae6b92f92f8bb92df33da5552a158cbe

The problem was that in case we had {\revised foo {bar}}, then we only
started a redline before "foo", but we ended it twice: during handling
of both "}". Make sure that the end of the redline is only handled by
the second one.

Change-Id: I41ab8b486e8615d3479fa0fadd6016476859b4b2

Since 9dbf817f (handle scope of
w:pPrChange and w:rPrChange properly (bnc#821804), 2014-10-01), this
caused an assertion failure -> crash.

Change-Id: I680edf58854d0c9be6e77c44c1e6beb1e0442a49

use name CVE-pseudo-2009-0238-1.rtf to record its detected as
Virus:Trojan.Mdropper and pseudo because its just a fuzzed
file from some random .rtf and not an original reproducer for
CVE-2009-0238

Change-Id: I85f6a72e0d32c14ea27cbe03bc4da3c2306fd1f5

Change-Id: I2683dd30d521b91cf026b3553ed4f75ee4172b3a

valgrind + bff

Change-Id: Id3c039a46dec5d2d4a4642dfb53d23a76972dde2