1. 13 May, 2019 1 kayıt (commit)
  2. 02 May, 2019 1 kayıt (commit)
  3. 15 Eki, 2018 1 kayıt (commit)
  4. 08 Eki, 2018 1 kayıt (commit)
  5. 19 Eyl, 2018 1 kayıt (commit)
  6. 10 Eyl, 2018 1 kayıt (commit)
  7. 25 May, 2018 1 kayıt (commit)
  8. 27 Ara, 2017 1 kayıt (commit)
  9. 11 Ara, 2017 1 kayıt (commit)
  10. 05 Ara, 2017 1 kayıt (commit)
  11. 27 Eyl, 2017 1 kayıt (commit)
  12. 13 Eyl, 2017 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Enable -Wunreachable-code · 7f3ca309
      Stephan Bergmann yazdı
      ...motivated by <https://gerrit.libreoffice.org/#/c/41565/2> adding dead code
      at the end of a switch statement, after the last case's "break".
      
      -Wunreachable-code appears to work well on Clang, while it appears to have no
      effect on GCC.
      
      Most of the affected places are apparently temporary/TODO/FIXME cases of
      disabling code via "if (false)", which can be written with an extra set of
      parentheses as "if ((false))" to silence -Wunreachable-code on Clang (which thus
      needed loplugin:unnecessaryparen to be adapted accordingly).  In some cases,
      the controlling expression was more complex than just "false" and needed to be
      rewritten by taking it out of the if statement to silence Clang.
      
      One noteworthy case where the nature of the disabled code wasn't immediately
      apparent:
      
        Sep 12 16:59:58 <sberg> quikee, is that "if (false)" in
         ScExponentialSmoothingDialog::ApplyOutput
         (sc/source/ui/StatisticsDialogs/ExponentialSmoothingDialog.cxx) some work-in-
         progress or dead code?
        Sep 12 17:02:03 <quikee> sberg: WIP, but you can remove it
        Sep 12 17:04:47 <sberg> quikee, I'll wrap the false in an extra set of
         parentheses for now, to silence -Wunreachable-code (I wouldn't want to
         remove it, as I have no idea whether I should then also remove the "Initial
         value" comment preceding it)
        Sep 12 17:07:29 <quikee> sberg: both are different ways to calculate the
         "intital value"... so no
      
      Another case where the nature of the dead code, following while (true) loops
      without breaks, is unclear is sd/source/ui/remotecontrol/BluetoothServer.cxx,
      where I added TODO markers to the workarounds that silence the warnings for now.
      
      basic/source/sbx/sbxvalue.cxx had a variable of type double, of automatic
      storage duration, and without an initalizer at the top of a switch statement.
      Clang warning about it is arguably a false positive.
      
      Apart from that, this didn't find any cases of genuinely dead code in the
      existing code base.
      
      Change-Id: Ib00b822c8efec94278c048783d5997b8ba86a94c
      Reviewed-on: https://gerrit.libreoffice.org/42217Tested-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      7f3ca309
  13. 05 Tem, 2017 1 kayıt (commit)
  14. 03 Tem, 2017 1 kayıt (commit)
    • Jochen Nitschke's avatar
      C++11 remove std::unary_function bases from functors · c4ddf6cd
      Jochen Nitschke yazdı
      std::unary_function is deprecated since C++11 and removed in C++17
      
      90% done with regexp magic.
      removed obsolete <functional> includes.
      
      The std::unary_function base class was used in 3 places:
      * chart2/source/tools/DataSeriesHelper.cxx: lcl_MatchesRole
         is used in a std::not1 function helper who uses the members
         return_type and argument_type.
         - replace deprecated std::not1 with a lambda
      * chart2/source/tools/ModifyListenerHelper.cxx:
         lcl_weakReferenceToSame used the argument_type member in the
         operator() parameter.
         - inline the parameter type.
      * xmloff/source/chart/SchXMLExport.cxx: lcl_SequenceToMapElement
         used result_type and argument_type in operator().
         - inline the types
      
      Also fix compile error with gcc about finding std::for_each.
      
      Change-Id: I073673beb01410c3108e7d0346d9e7d6b9ad2e2f
      Reviewed-on: https://gerrit.libreoffice.org/39358Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      Tested-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      c4ddf6cd
  15. 02 Tem, 2017 2 kayıt (commit)
  16. 31 May, 2017 1 kayıt (commit)
  17. 18 May, 2017 3 kayıt (commit)
  18. 06 Şub, 2017 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Add missing #includes · 6dce9c67
      Stephan Bergmann yazdı
      ...and remove some unncessary using directives/declarations, in preparation of
      removing now-unnecessary #includes from cppumaker-generated files, post
      e57ca028 "Remove dynamic exception
      specifications".
      
      Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
      6dce9c67
  19. 28 Ock, 2017 1 kayıt (commit)
  20. 26 Ock, 2017 1 kayıt (commit)
    • Stephan Bergmann's avatar
      Remove dynamic exception specifications · e57ca028
      Stephan Bergmann yazdı
      ...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
      <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
      "Dynamic Exception Specifications" for details.
      
      Most changes have been done automatically by the rewriting loplugin:dynexcspec
      (after enabling the rewriting mode, to be committed shortly).  The way it only
      removes exception specs from declarations if it also sees a definition, it
      identified some dead declarations-w/o-definitions (that have been removed
      manually) and some cases where a definition appeared in multiple include files
      (which have also been cleaned up manually).  There's also been cases of macro
      paramters (that were used to abstract over exception specs) that have become
      unused now (and been removed).
      
      Furthermore, some code needed to be cleaned up manually
      (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
      configurations available that would actually build that code.  Missing @throws
      documentation has not been applied in such manual clean-up.
      
      Change-Id: I3408691256c9b0c12bc5332de976743626e13960
      Reviewed-on: https://gerrit.libreoffice.org/33574Tested-by: 's avatarJenkins <ci@libreoffice.org>
      Reviewed-by: 's avatarStephan Bergmann <sbergman@redhat.com>
      e57ca028
  21. 10 Ock, 2017 1 kayıt (commit)
  22. 24 Kas, 2016 1 kayıt (commit)
  23. 31 Eki, 2016 1 kayıt (commit)
  24. 13 Eyl, 2016 1 kayıt (commit)
    • Stephan Bergmann's avatar
      loplugin:override: No more need for the "MSVC dtor override" workaround · 91dd2db1
      Stephan Bergmann yazdı
      The issue of 362d4f0c "Explicitly mark
      overriding destructors as 'virtual'" appears to no longer be a problem with
      MSVC 2013.
      
      (The little change in the rewriting code of compilerplugins/clang/override.cxx
      was necessary to prevent an endless loop when adding "override" to
      
        OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();
      
      in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
      OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
      isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
      
      Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
      91dd2db1
  25. 08 Tem, 2016 1 kayıt (commit)
  26. 01 Nis, 2016 1 kayıt (commit)
  27. 24 Mar, 2016 2 kayıt (commit)
  28. 29 Şub, 2016 1 kayıt (commit)
  29. 09 Şub, 2016 1 kayıt (commit)
  30. 29 Ock, 2016 1 kayıt (commit)
  31. 21 Ara, 2015 1 kayıt (commit)
  32. 15 Kas, 2015 1 kayıt (commit)
  33. 10 Kas, 2015 1 kayıt (commit)
  34. 12 Eki, 2015 1 kayıt (commit)
  35. 30 Eyl, 2015 1 kayıt (commit)
  36. 25 Eyl, 2015 1 kayıt (commit)